Re: [secdir] Secdir last call review of draft-ietf-trill-centralized-replication-10

Donald Eastlake <d3e3e3@gmail.com> Tue, 12 December 2017 21:12 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6FF661279E5; Tue, 12 Dec 2017 13:12:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.448
X-Spam-Level:
X-Spam-Status: No, score=-2.448 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrzwY5G7_yoa; Tue, 12 Dec 2017 13:12:34 -0800 (PST)
Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0419129566; Tue, 12 Dec 2017 13:12:33 -0800 (PST)
Received: by mail-oi0-x234.google.com with SMTP id x20so168044oix.12; Tue, 12 Dec 2017 13:12:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G4VwViNAyi2gvyoSSlj2n8BFAVZaXJve71EYPsp0nMY=; b=saeWn3AXHNkdJqSD0LONNtYxI/ekglbswp2lk8VwjlsYYia+0kn711oz6SdaJ4YgHf RXRkpcUm+KIrm4INZfUxk17HQ6nrt9JziZFlONtRSv2wthRbog8QrUb7b0jpbJ83PABQ pX+H8A2izwfjmZAAiblPRmwz4rWwhyHqHRjdVmPPQgbVp46aF2DN5Ok+NdNT/5aeKguw R5QjCbSYlzpRiqvMdp1uhhb1XUiBYGV1md2ve1fPx0RHlZff3QWgNVHKDEbP6SbHA1a4 /arL+X6a3mwl6NvJ6dBODehZscXNIrY1sy5PEbow3wglu6tb3M1e8ILsr+kuYEOhZBuN cdzg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G4VwViNAyi2gvyoSSlj2n8BFAVZaXJve71EYPsp0nMY=; b=KyCxA8ym9Bp4XNAz4saUCIje3N3PiPdMwXPYJMPHK4EFDXnW27+73GzzUvf+MSMYLr bPoumaP13kslI+IZ2OiWzK7fp6EgHUX6ffJxQB8RlzW4p9Yr+QC4wCh7uxbyfyBSUsU2 YK7nevALgc1AUKG5zlDQtStcMXOw84UIJvURFC8+JpxvfrpWDNp9Axp76s75Y3Cm5Tmy kOZW5sVUYoFmfgd+1DHI6EL+QkgLTf/AEf4zwcZZFsPQt2e4bWSLd/02IVTP90e5+uIF r0L/y2NDy9/liKxvHK8rOmCrD6tt8HHM+WccGvRw3o0d520uisR7Nqs7Z/haY68v6Ttm zhLg==
X-Gm-Message-State: AKGB3mLKfvsaYdXc3ZEP/xXSgLlVct/owo68EgGJRLK1PgKM2jKF2mYc YvHLchalyUH7QvQREtXr7KaTfwDOm78i6zDQ2U/af7eY
X-Google-Smtp-Source: ACJfBouyKZf/F/pfgBG6MFOlYoQ0ksrFRpUhkg/DRzIYW8+9ZYhPFWURj+qWVGtwQZzD8WRJfJXOCSnrnL+/7SrsnkI=
X-Received: by 10.202.212.209 with SMTP id l200mr169002oig.318.1513113153082; Tue, 12 Dec 2017 13:12:33 -0800 (PST)
MIME-Version: 1.0
Received: by 10.168.53.129 with HTTP; Tue, 12 Dec 2017 13:12:17 -0800 (PST)
In-Reply-To: <151294155757.21877.6840749517796253347@ietfa.amsl.com>
References: <151294155757.21877.6840749517796253347@ietfa.amsl.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 12 Dec 2017 16:12:17 -0500
Message-ID: <CAF4+nEESYYD_NAHM0Bc8jhVoEDxuNsb=o=u0b_DK5i9G16npCQ@mail.gmail.com>
To: Joseph Salowey <joe@salowey.net>
Cc: "secdir@ietf.org" <secdir@ietf.org>, "trill@ietf.org" <trill@ietf.org>, "iesg@ietf.org" <iesg@ietf.org>, draft-ietf-trill-centralized-replication.all@ietf.org
Content-Type: multipart/alternative; boundary="001a113d2f88fe9adc05602b1b05"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/93_OtkP-sGiJQFPYOh_wZH0yeAs>
Subject: Re: [secdir] Secdir last call review of draft-ietf-trill-centralized-replication-10
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 21:12:35 -0000

Hi Joseph,

Thanks for the review, see below.

On Sun, Dec 10, 2017 at 4:32 PM, Joseph Salowey <joe@salowey.net> wrote:

> Reviewer: Joseph Salowey
> Review result: Has Issues
>
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written primarily for the benefit of the
> security area directors.  Document editors and WG chairs should treat
> these comments just like any other last call comments.
>
> Document is ready with issues.
>
> I think the document has appropriate security considerations.
>
> One issue I see in the document is that in the intro it states:
> "The basic idea is that all ingress RBridges send BUM traffic to a
> centralized
> node, which SHOULD be a distribution tree root, using unicast TRILL
> encapsulation." In section 3 it states : "The centralized node MUST be a
> distribution tree root."
>
> The MUST and SHOULD seem to be at odds here.
>

Indeed, a number of "SHOULD"s were changed in a recent revision to "MUST"s
and it looks like one of the most prominent, in the Abstract, was
overlooked.

Thanks,
Donald (document shepherd)
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com