Re: [secdir] Secdir last call review of draft-ietf-rtgwg-ni-model-06

"Acee Lindem (acee)" <acee@cisco.com> Sat, 03 February 2018 20:03 UTC

Return-Path: <acee@cisco.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD53F12DA23; Sat, 3 Feb 2018 12:03:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.53
X-Spam-Level:
X-Spam-Status: No, score=-14.53 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vD6E3Hugfy_t; Sat, 3 Feb 2018 12:03:19 -0800 (PST)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E7C6F12DA19; Sat, 3 Feb 2018 12:03:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1318; q=dns/txt; s=iport; t=1517688199; x=1518897799; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1peUSAt/o1xM73F9n1Cm/fz32MNpG2yUplVJ+3vkijk=; b=dmIWvEO/t2XaiVD6f6UFwWMfcru/I8QIqeZ5STKwPqcML8ZOQiKL6jIX EO6STI4Qg4pu1ICu2jGXMQZAAnoWXl2Zv0s1VrEi+CowiPoewpYUuuu5D MzAy4qhZudILFK5k5KTyvRoTaA+JSk4YrGhePthJ4v3EnbpHuJ1QhVjUo Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DGAQBgFHZa/4YNJK1cGQEBAQEBAQEBAQEBAQcBAQEBAYNRZnAoCoNbmE+ZSoIYCiOFGAIagh5WFgEBAQEBAQEBAmsohSQGIxFFEAIBCA4MAiYCAgIwFRACBAENBYo1ELwNgieIcIIGAQEBAQEBAQEBAQEBAQEBAQEBAQEBGAWBD4NbghWDaIMFgy8CAoFvgxcxgjQBBKQlAogXjViUN41tiVwCERkBgTsBJQEygVBwFWcBghuEd3gMiwqBFwEBAQ
X-IronPort-AV: E=Sophos;i="5.46,456,1511827200"; d="scan'208";a="351589172"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2018 20:03:17 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id w13K3HPD028062 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 3 Feb 2018 20:03:17 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Sat, 3 Feb 2018 15:03:16 -0500
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1320.000; Sat, 3 Feb 2018 15:03:16 -0500
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Liang Xia <frank.xialiang@huawei.com>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-rtgwg-ni-model.all@ietf.org" <draft-ietf-rtgwg-ni-model.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Thread-Topic: Secdir last call review of draft-ietf-rtgwg-ni-model-06
Thread-Index: AQHTkQc9uq8Yg6SETUWosZYM8aIeVaOTMfyA
Date: Sat, 03 Feb 2018 20:03:16 +0000
Message-ID: <BD365632-31EE-448F-846C-DBF30DDE3290@cisco.com>
References: <151635383693.27079.16419648768867795104@ietfa.amsl.com>
In-Reply-To: <151635383693.27079.16419648768867795104@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.198]
Content-Type: text/plain; charset="utf-8"
Content-ID: <7F823BCB5820B249A554128DCB0EFC72@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/9I11f_vK4rUuPqTWElICJBX2770>
Subject: Re: [secdir] Secdir last call review of draft-ietf-rtgwg-ni-model-06
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Feb 2018 20:03:21 -0000

Hi Liang, 

Thanks for the review. These changes will be in the -07 along with Alia's comments. See one inline.

On 1/19/18, 4:24 AM, "Liang Xia" <frank.xialiang@huawei.com> wrote:

    Reviewer: Liang Xia
    Review result: Has Issues
    
    For the section of Security Considerations:
    1. you may refer to templete in
    https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines to add some
    required general security considerations;
    
    2. According to the above templete, [RFC5246], [RFC6241], [RFC6242], [RFC6536],
    and [RFC8040] must be "normative references";
    
    3. I don't see the security consideration content about the readable data
    nodes. Is it missed, or there are not such readable date nodes need to be
    considered?

No - there are no 'config false' data nodes. There is more thoughtfulness put into these "Security Considerations" than most YANG models. 

Thanks,
Acee