Re: [secdir] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

Barry Leiba <barryleiba@computer.org> Sat, 16 March 2024 00:04 UTC

Return-Path: <barryleiba@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2F543C14F6A9; Fri, 15 Mar 2024 17:04:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.41
X-Spam-Level:
X-Spam-Status: No, score=-6.41 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lfDiKP0ykMkA; Fri, 15 Mar 2024 17:04:47 -0700 (PDT)
Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 81F32C14F6A5; Fri, 15 Mar 2024 17:04:47 -0700 (PDT)
Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-568107a9ff2so3207768a12.3; Fri, 15 Mar 2024 17:04:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710547486; x=1711152286; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BztVvUHXnPBTH6lviUbo7B8+rDTKYj7GdHHLCWaraxI=; b=H+Q0aM0kpY+cyBSeKo2nnOnJzyIHGkrhyznN/jFn2fvm3KksmD99kF6U8swo+EEWm5 Ol89KnEe+VVB07t4EAy0M0Ni9XKb8Ku0P62mUAWv6EwVcfvIx7sn+Av1UCayGU8oT63V 361q89LOIDJkITyiWShcABwyhMwFhiXz4mnM2l8n5PlyD10fjhIUcNK9UfEzKckL6k0A tO5jSmpC2hofPjMRTEVAs3X00hBJqdzJY6JPmblPlL59vzF4HxmleQXuOt6sThRsL67a 6zrfpaZL/LfRctQEa6OrwYXSqMrKAbFhjj/w1k3L6qnhLVnB/8WEwJN5KJ0q7f1wABxm eJmA==
X-Forwarded-Encrypted: i=1; AJvYcCVfUSMfWOFIsr3b0ikbw/ymEkrETE4HYiBdfbEhC8qwww9W8Rx+iGTXgxHDwqQ3xsNvPcHhAPHHymUALHfhp+EV/bO6XxjFHSrjP9Rb01npwyFSduoxMXJtKQIe5fBKEPNLGNBfhgVxrpeQ1Rf0NQ62HrR/lM3QUTf8I1bnPIAYzXywcKHYZaH7eU84xT3vONF/
X-Gm-Message-State: AOJu0Yz2YqQtSAKj+eq478Kvp0oQLdF4d4ZTPEZV8aH/5nA6crJ6Ssm0 uM6poGuozJCzVMKOsrf99AXewiZ6vnAPZjkwogCKbGtDG+ocPKxfEM4DNjc8ErOwxGf+T21NjKr 0rREIJNF+1YWQbcscq7vltfkM+G8=
X-Google-Smtp-Source: AGHT+IGXwM0g5Ouw+ld31JSavpZpV4ruhEZ/kXX7jFhisbKPvTRxr7tAO688KHkHf3h/2uY55AW4rZjIbh2nuQsiybc=
X-Received: by 2002:a05:6402:1945:b0:566:fbf5:a279 with SMTP id f5-20020a056402194500b00566fbf5a279mr4734697edz.20.1710547485307; Fri, 15 Mar 2024 17:04:45 -0700 (PDT)
MIME-Version: 1.0
References: <171039366659.20498.10089613218127593389@ietfa.amsl.com> <AS2PR02MB88393A54D5EEBB620330E429F0282@AS2PR02MB8839.eurprd02.prod.outlook.com> <BY5PR11MB4337D9FC03AA1D467F2D7FFFC1282@BY5PR11MB4337.namprd11.prod.outlook.com> <AS2PR02MB8839E6DBC2B5AB0276049D80F0282@AS2PR02MB8839.eurprd02.prod.outlook.com> <BY5PR11MB433701A1D75A67BA73BA5C83C1282@BY5PR11MB4337.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB433701A1D75A67BA73BA5C83C1282@BY5PR11MB4337.namprd11.prod.outlook.com>
From: Barry Leiba <barryleiba@computer.org>
Date: Sat, 16 Mar 2024 10:04:32 +1000
Message-ID: <CALaySJJRFMfTDdZDTnvh+VyS-zVEKZjHK+0OzbHZrkJTRUj01Q@mail.gmail.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
Cc: DECRAENE Bruno INNOV/NET <bruno.decraene@orange.com>, "draft-ietf-lsr-isis-fast-flooding.all@ietf.org" <draft-ietf-lsr-isis-fast-flooding.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/G3VqSwo4pQrV_yeMJeex0Oe3L1U>
Subject: Re: [secdir] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Mar 2024 00:04:48 -0000

Indeed; given the explanation and the fact that it's copied from
otherwise existing text, I think Les is right: just leave it as is,
and thanks for considering and discussing my question.

Barry

On Sat, Mar 16, 2024 at 6:00 AM Les Ginsberg (ginsberg)
<ginsberg@cisco.com> wrote:
>
> Bruno -
>
> Inline.
>
> > -----Original Message-----
> > From: bruno.decraene@orange.com <bruno.decraene@orange.com>
> > Sent: Friday, March 15, 2024 11:17 AM
> > To: Les Ginsberg (ginsberg) <ginsberg@cisco.com>; Barry Leiba
> > <barryleiba@computer.org>
> > Cc: draft-ietf-lsr-isis-fast-flooding.all@ietf.org; last-call@ietf.org; lsr@ietf.org;
> > secdir@ietf.org
> > Subject: RE: Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07
> >
> > Les, Barry,
> >
> > > From: Les Ginsberg (ginsberg) <ginsberg@cisco.com>
> > > Sent: Friday, March 15, 2024 4:29 PM
> > >
> > > Bruno/Barry -
> > >
> > > In regards to:
> > >
> > > > > — Section 4.4 —
> > > > >
> > > >    > Length: Indicates the length in octets (1-8) of the Value field.  The
> > > >    > length SHOULD be the minimum required to send all bits that are set.
> > > > >
> > > > > The SHOULD seems very odd: what would be a good reason to make it
> > > > longer than necessary?  Is there a real reason not to
> > > > straightforwardly say, “The length is the minimum required…”?
> > > >
> > > > [Bruno] To be honest, that's just verbatim copy from
> > > >
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata
> > > > tracker.ietf.org%2Fdoc%2Fhtml%2Frfc8919%23name-application-
> > identifier-
> > > >
> > &data=05%7C02%7Cbruno.decraene%40orange.com%7Ced0ce7f4ef6f4adb
> > a5ee08dc
> > > >
> > 4504b6dc%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C63846
> > 11337566830
> > > >
> > 44%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> > MzIiLCJBTiI
> > > >
> > 6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Mxn56QB9LdNA%2
> > FBh2bAANCIsky
> > > > Xx1zTir%2FIpTtpRsQbM%3D&reserved=0
> > > > bit-
> > > > At the time, I had assumed that copying an already agreed upon
> > > > sentence from an RFC was simplifier and safer. Looks like I was only 50%
> > right 😉.
> > > > You have a good point. I can't find a legitimate reason.
> > > > I used your proposed wording (although my natural inclination would
> > > > have used a "MUST")
> > > >
> > > [LES:] The reason RFC 8919 uses SHOULD - and why this draft should do the
> > same - is that sending additional bits unnecessarily is not incorrect - it is simply
> > inefficient.
> >
> > [Bruno] Agreed that this is only about efficiency. IMO the question is whether
> > the sender must be efficient or if there a good reason to allow for inefficiency.
> >
> > > If you use "MUST" you are stating that receivers are obligated to reject a
> > correct advertisement simply because it is unnecessarily long.
> > > This is unwise and counterproductive.
> >
> > [Bruno] In theory, there should be a way to Be conservative in what you send
> > and liberal in what you receive.
> > That would require more text. e.g.
> > OLD:  The length SHOULD be the minimum required to send all bits that are
> > set.
> > NEW: When sent, the length MUST be set to the minimum required to send all
> > bits that are set. When received any length below or equal 8 octets MUST be
> > accepted.
> >
> > Would this work?
> [LES:] We have already explicitly stated what the sender SHOULD do - and by using "SHOULD" we indicate that the receiver needs to be "liberal" and accept the advertisement even if it is longer than necessary.
> I do not see what is being accomplished here.
>
> An implementation that is optimal is already following the recommended behavior.
> Do you think that by saying "MUST" you will get more implementations to be optimal?
> I doubt it.
>
> And you now have to use two "MUST" statements:
>
> 1)For the transmitter - to be optimal
> 2)For the receiver - to be liberal
>
> A single SHOULD accomplishes the same thing.
>
> I think this is "much ado about nothing" - or at best "much ado about very little".
>
>    Les
>
> >
> > Regards,
> > --Bruno
> >
> >
> > > As a WG member and co-author I object to this change.
> > >
> > > HTH
> > >
> >    > Les
> > >
> > >
> > ___________________________________________________________________
> > _________________________________________
> > Ce message et ses pieces jointes peuvent contenir des informations
> > confidentielles ou privilegiees et ne doivent donc
> > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce
> > message par erreur, veuillez le signaler
> > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> > electroniques etant susceptibles d'alteration,
> > Orange decline toute responsabilite si ce message a ete altere, deforme ou
> > falsifie. Merci.
> >
> > This message and its attachments may contain confidential or privileged
> > information that may be protected by law;
> > they should not be distributed, used or copied without authorisation.
> > If you have received this email in error, please notify the sender and delete this
> > message and its attachments.
> > As emails may be altered, Orange is not liable for messages that have been
> > modified, changed or falsified.
> > Thank you.