Re: [secdir] Secdir last call review of draft-ietf-sipcore-sip-token-authnz-12
Derrell Piper <ddp@electric-loft.org> Wed, 15 April 2020 18:21 UTC
Return-Path: <ddp@electric-loft.org>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 021A93A0F12; Wed, 15 Apr 2020 11:21:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.499
X-Spam-Level:
X-Spam-Status: No, score=-1.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rWQAUVE8AM1K; Wed, 15 Apr 2020 11:21:42 -0700 (PDT)
Received: from Mail.Yoyodyne.COM (mail.yoyodyne.com [IPv6:2604:4ec0:0:2::d]) by ietfa.amsl.com (Postfix) with SMTP id 628413A0F0F; Wed, 15 Apr 2020 11:21:42 -0700 (PDT)
Received: from [IPv6:2603:3024:1767:6000:549:1025:182e:ed50] ([2603:3024:1767:6000:549:1025:182e:ed50]) by Mail.Yoyodyne.COM via Internet for <christer.holmberg@ericsson.com> (and others); Wed, 15 Apr 2020 11:21:35 PDT
From: Derrell Piper <ddp@electric-loft.org>
Message-Id: <43AFD2E4-0486-4CEB-BBBC-8C7C72B84E09@electric-loft.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_53DD0931-213C-425A-AD17-CFAC8BA26ECE"; protocol="application/pkcs7-signature"; micalg="sha-256"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Wed, 15 Apr 2020 11:21:34 -0700
In-Reply-To: <5BABF46F-6BF2-4296-B035-099BF57E0EBE@ericsson.com>
Cc: "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-sipcore-sip-token-authnz.all@ietf.org" <draft-ietf-sipcore-sip-token-authnz.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "sipcore@ietf.org" <sipcore@ietf.org>
To: Christer Holmberg <christer.holmberg@ericsson.com>
References: <158689842488.27716.15541584374764439587@ietfa.amsl.com> <5BABF46F-6BF2-4296-B035-099BF57E0EBE@ericsson.com>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/L6Pul4I1kIGUpY1ni6yeQ8mqEs4>
Subject: Re: [secdir] Secdir last call review of draft-ietf-sipcore-sip-token-authnz-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 18:21:44 -0000
> On Apr 15, 2020, at 12:58 AM, Christer Holmberg <christer.holmberg@ericsson.com> wrote: > > Hi Derrell, > > Thank You for the review! Please see inline. > >> pp. 3, 1., nit >> >> "...enables the single-sign-on features, which allows the user to..." >> >> "...enables single sign-on, which allows the user to..." > > We can fix as suggested. > > --- > >> pp. 5, last sentence >> >> "previously" means "from the out-of-scope mechanism", just say that. > > I think that sounds a little "clumsy" to repeat it. Would it work if we said "obtained in the step above", or something like that? “the step above” works too. > --- > >> pp. 7, 2.1.1 >> >> "(or with invalid credentials)" >> >> Why continue when a UAC presents invalid credentials? [See below.] >> >> >> pp. 8, 2.1.3 >> >> 2.1.1 says if you get invalid credentials to go REGISTER, and here in >> REGISTER, it says if you get invalid credentials, go to 2.1.1. This >> seems recursive though I'm assuming this ultimately terminates when all >> the schemes are exhausted without success. > > Section 2.1.1 defines generic procedures, while section 2.1.3 defines the procedures specific for the REGISTER request. > > Regards, > > Christer Okay. Derrell
- [secdir] Secdir last call review of draft-ietf-si… Derrell Piper via Datatracker
- Re: [secdir] Secdir last call review of draft-iet… Christer Holmberg
- Re: [secdir] Secdir last call review of draft-iet… Derrell Piper