[secdir] secdir review of draft-ietf-xrblock-rtcp-xr-loss-conceal-11.txt

Stephen Hanna <shanna@juniper.net> Thu, 10 April 2014 13:37 UTC

Return-Path: <shanna@juniper.net>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com []) by ietfa.amsl.com (Postfix) with ESMTP id 8BB351A01AD; Thu, 10 Apr 2014 06:37:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id tzEbL1n43YUZ; Thu, 10 Apr 2014 06:37:53 -0700 (PDT)
Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe005.messaging.microsoft.com []) by ietfa.amsl.com (Postfix) with ESMTP id 5A44F1A01C1; Thu, 10 Apr 2014 06:37:53 -0700 (PDT)
Received: from mail1-am1-R.bigfish.com ( by AM1EHSOBE024.bigfish.com ( with Microsoft SMTP Server id; Thu, 10 Apr 2014 13:37:28 +0000
Received: from mail1-am1 (localhost []) by mail1-am1-R.bigfish.com (Postfix) with ESMTP id 6F8924A035C; Thu, 10 Apr 2014 13:37:28 +0000 (UTC)
X-Forefront-Antispam-Report: CIP:; KIP:(null); UIP:(null); IPV:NLI; H:BL2PRD0510HT004.namprd05.prod.outlook.com; RD:none; EFVD:NLI
X-SpamScore: 1
X-BigFish: VPS1(zz4015Izz1f42h2148h1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6h208chzdchzz2fh109h2a8h839h944hd24hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h19ceh1ad9h1b0ah224fh1d07h1d0ch1d2eh1d3fh1dc1h1de9h1dfeh1dffh1fe8h1ff5h2216h22d0h2336h2461h2487h24d7h2516h2545h255eh25cch25f6h2605h262fh268bh26c8h26d3h9a9j1155h)
Received-SPF: pass (mail1-am1: domain of juniper.net designates as permitted sender) client-ip=; envelope-from=shanna@juniper.net; helo=BL2PRD0510HT004.namprd05.prod.outlook.com ; .outlook.com ;
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009001)(6009001)(428001)(164054003)(189002)(199002)(86362001)(85852003)(74316001)(46102001)(80022001)(81542001)(81342001)(87936001)(76482001)(66066001)(83072002)(92566001)(76576001)(2201001)(50986999)(54356999)(77096999)(2656002)(31966008)(77982001)(80976001)(4396001)(83322001)(74662001)(74502001)(20776003)(99396002)(33646001)(79102001)(24736002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB740; H:BLUPR05MB737.namprd05.prod.outlook.com; FPR:BC28F0AA.8F126508.40D7F14C.46FFC211.20271; MLV:sfv; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received: from mail1-am1 (localhost.localdomain []) by mail1-am1 (MessageSwitch) id 1397137046751906_23680; Thu, 10 Apr 2014 13:37:26 +0000 (UTC)
Received: from AM1EHSMHS010.bigfish.com (unknown []) by mail1-am1.bigfish.com (Postfix) with ESMTP id AA32F30005E; Thu, 10 Apr 2014 13:37:26 +0000 (UTC)
Received: from BL2PRD0510HT004.namprd05.prod.outlook.com ( by AM1EHSMHS010.bigfish.com ( with Microsoft SMTP Server (TLS) id; Thu, 10 Apr 2014 13:37:26 +0000
Received: from BLUPR05MB740.namprd05.prod.outlook.com ( by BL2PRD0510HT004.namprd05.prod.outlook.com ( with Microsoft SMTP Server (TLS) id 14.16.435.0; Thu, 10 Apr 2014 13:37:49 +0000
Received: from BLUPR05MB737.namprd05.prod.outlook.com ( by BLUPR05MB740.namprd05.prod.outlook.com ( with Microsoft SMTP Server (TLS) id 15.0.913.9; Thu, 10 Apr 2014 13:37:46 +0000
Received: from BLUPR05MB737.namprd05.prod.outlook.com ([]) by BLUPR05MB737.namprd05.prod.outlook.com ([]) with mapi id 15.00.0913.002; Thu, 10 Apr 2014 13:37:46 +0000
From: Stephen Hanna <shanna@juniper.net>
To: The IESG <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-xrblock-rtcp-xr-loss-conceal.all@tools.ietf.org" <draft-ietf-xrblock-rtcp-xr-loss-conceal.all@tools.ietf.org>
Thread-Topic: secdir review of draft-ietf-xrblock-rtcp-xr-loss-conceal-11.txt
Thread-Index: Ac9Uwg0TQPUFa/57STOHpKA/9IWsSA==
Date: Thu, 10 Apr 2014 13:37:45 +0000
Message-ID: <d9d27da568914131a084075048c963b9@BLUPR05MB737.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-originating-ip: []
x-forefront-prvs: 0177904E6B
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
Archived-At: http://mailarchive.ietf.org/arch/msg/secdir/MUCUewSVWvHDjveC3yJqJ9vQNbg
Subject: [secdir] secdir review of draft-ietf-xrblock-rtcp-xr-loss-conceal-11.txt
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Apr 2014 13:37:55 -0000

I have reviewed this document as part of the security directorate's 
ongoing effort to review all IETF documents being processed by the 
IESG.  These comments were written primarily for the benefit of the 
security area directors.  Document editors and WG chairs should treat 
these comments just like any other last call comments.

This document is "Ready with nits".

This document defines two RTCP XR Report Blocks that allow the
reporting of concealment metrics for audio applications of RTP.
In layman's terms, this allows an audio receiver to report back
on how much the audio is being mangled by packet loss.

>From a security perspective, this document is fine. The security
considerations section says that this document introduces no new
security considerations beyond those described in [RFC3611].
I agree.

I do have one nit that I wanted to ask about. At the very end of
section 3.2, the Mean Playout Interrupt Size is defined to be
32 bits long. However, the second paragraph of this definition

      If the measured value exceeds 0xFFFD, the value 0xFFFE MUST be
      reported to indicate an over-range measurement.  If the
      measurement is unavailable, the value 0xFFFF MUST be reported.

Shouldn't those constants be 0xFFFFFFFD, 0xFFFFFFFE, and 0xFFFFFFFF?



P.S. I apologize for sending this review late. However, I believe
that it's still before the IESG telechat on this document so I hope
that it will have some value.