Re: [secdir] Secdir last call review of draft-ietf-lisp-pubsub-10

mohamed.boucadair@orange.com Fri, 27 January 2023 07:48 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4DB2BC14F74E; Thu, 26 Jan 2023 23:48:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.096
X-Spam-Level:
X-Spam-Status: No, score=-7.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NsBTwco-WS1h; Thu, 26 Jan 2023 23:48:02 -0800 (PST)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 174C2C14E514; Thu, 26 Jan 2023 23:48:02 -0800 (PST)
Received: from opfednr07.francetelecom.fr (unknown [xx.xx.xx.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfednr27.francetelecom.fr (ESMTP service) with ESMTPS id 4P38nW6pRGz4wlG; Fri, 27 Jan 2023 08:47:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1674805680; bh=XhCVkorlxyGwH8FwCMnYjyzIs7yNHLvNMxvRz+4jLwQ=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=u5dA/+isptf9pCPKROVg01txKcbtjkFO6khow1xXDCBTYKhqum8+PK980pwqoFtPZ kDfFlerv2wj7wKgAI7bN5KByr0RRjHnRzyanZTGOPThuT1w6zV3a808dIpfsQuoEm6 0FyIIsfgCCMwG6ixeGlTFpE0f+zBzKdj43fWvjl6lMa7Szh3gxGef7KQl0k54zM2rs bEXlY0GAgL4fw6Hk2hOw7ccr/uWmXjoKMsuy2aVxYlgUrMquceq9HYmgMHmZU9dLwT d7HhGpdw7dAYSTsxmGtaf+DE+PnAGqAOZPkYVJ0MHMbOF07u1U/Jlur3td1/pRg0q4 EbWcYs+KZIVjQ==
From: mohamed.boucadair@orange.com
To: Chris Lonvick <lonvick.ietf@gmail.com>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-lisp-pubsub.all@ietf.org" <draft-ietf-lisp-pubsub.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lisp@ietf.org" <lisp@ietf.org>
Thread-Topic: Secdir last call review of draft-ietf-lisp-pubsub-10
Thread-Index: AQHZMeunnS0/WrWjv0GlZ5O4xDVks66x4Iow
Content-Class:
Date: Fri, 27 Jan 2023 07:47:59 +0000
Message-ID: <29456_1674805679_63D381AF_29456_197_1_07ce7b436d404c41806fa40841f16dc2@orange.com>
References: <167478161471.38643.9012449323875902900@ietfa.amsl.com>
In-Reply-To: <167478161471.38643.9012449323875902900@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2023-01-27T07:37:27Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=1e16789b-8d7f-4e71-a324-dcd4181d3efe; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.26.52]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/PZ5mgFhtpO9-F0eIr385M-MLM80>
Subject: Re: [secdir] Secdir last call review of draft-ietf-lisp-pubsub-10
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jan 2023 07:48:06 -0000

Hi Chris,

Thanks for the review and for double checking that your initial review was addressed. 

The use of the nonce in the document is consistent with its usage in other LISP specs, especially RFC9301. If there is any change, this would be in these authoritative documents. 

I appreciate that you ACK that this has no operational problem. 

Cheers,
Med

> -----Message d'origine-----
> De : Chris Lonvick via Datatracker <noreply@ietf.org>
> Envoyé : vendredi 27 janvier 2023 02:07
> À : secdir@ietf.org
> Cc : draft-ietf-lisp-pubsub.all@ietf.org; last-call@ietf.org;
> lisp@ietf.org
> Objet : Secdir last call review of draft-ietf-lisp-pubsub-10
> 
> Reviewer: Chris Lonvick
> Review result: Has Nits
> 
> Hi,
> 
> I have reviewed this document as part of the security
> directorate's ongoing effort to review all IETF documents being
> processed by the IESG. These comments were written primarily for
> the benefit of the security area directors. Document editors and
> WG chairs should treat these comments just like any other last
> call comments.
> 
> It appears that the issue that I brought up in my early review of
> the draft has not been addressed. The draft continues to use the
> term nonce in a way that is not consistent with RFC 4949. This is
> likely not an operational problem as the rules defined for using
> it are well described in the document. This could be addressed by
> stating that a nonce is generated in the Map-Request, and the
> value of the nonce is used in subsequent exchanges.
> 
> The TSVART reviewer of the draft seems to be much more familiar
> with LISP than I, and brings up a lot of security issues. I would
> like to see those issues addressed.
> 
> Regards,
> Chris
> 


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.