[secdir] draft-ietf-mpls-ldp-capabilities-03.txt

Donald Eastlake <d3e3e3@gmail.com> Tue, 31 March 2009 21:13 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@core3.amsl.com
Delivered-To: secdir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id AFFEA28C1A6; Tue, 31 Mar 2009 14:13:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.519
X-Spam-Level:
X-Spam-Status: No, score=-2.519 tagged_above=-999 required=5 tests=[AWL=0.080, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V78hGjrbcl4v; Tue, 31 Mar 2009 14:13:40 -0700 (PDT)
Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30]) by core3.amsl.com (Postfix) with ESMTP id BBFB328C1AA; Tue, 31 Mar 2009 14:13:39 -0700 (PDT)
Received: by yw-out-2324.google.com with SMTP id 5so3786547ywh.49 for <multiple recipients>; Tue, 31 Mar 2009 14:14:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=x8Q05P7V/kGgHK/PHbQMNIunV2sz6DiVUtksW5r+bPI=; b=dBYBSgG/z5mvNV3lGSNFP1oEEkp7io6jFbWyiIkLiB/BTKPHtUBEwSp1/9QSzjTunn lgdlvdqjn0OmwDBSy6izxzzhWTQcEwvPaFP6gwGM+VfWEoJzPu6F4YgGM8GNmkX+CbmN 7qN3RmfzJR8yEOeq8iNMZ4/Kt2v6red/T7t7I=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=kV6JHUZKl2DkXU+EHda5HJWWGooPT1TesZazg2BoidXxODLohMWjCr//odQiMK1Thr WCdb7iSWACjnQlEr2w4c3KwY9+kH52IbF3DaFtnGiGdTwf8wRt9QBghPyBYOcW3+YfKg 9F65KDRhC3qJykwiIg2zYFcYsXW1wRYB8iG/w=
MIME-Version: 1.0
Received: by 10.100.8.4 with SMTP id 4mr5377318anh.81.1238534078957; Tue, 31 Mar 2009 14:14:38 -0700 (PDT)
Date: Tue, 31 Mar 2009 17:14:38 -0400
Message-ID: <1028365c0903311414s2a0c63a3v5399b3fdbcba3445@mail.gmail.com>
From: Donald Eastlake <d3e3e3@gmail.com>
To: iesg@ietf.org, secdir@ietf.org, rhthomas@cisco.com, shivani@juniper.net, rahul@juniper.net, jeanlouis.leroux@orange-ftgroup.com, skraza@cisco.com, George Swallow <swallow@cisco.com>, Loa Andersson <loa@pi.nu>, Martin Vigoureux <martin.vigoureux@alcatel.fr>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [secdir] draft-ietf-mpls-ldp-capabilities-03.txt
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2009 21:13:40 -0000

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors. These comments should be treated just like
any other last call comments.

This draft concerns dynamic LDP capability announcement and
withdrawal. It's Security Considerations section simply refers to RFC
5306, the LDP Specification. While it doesn't seem to me that RFC 5306
offers much security, mostly saying only talk to people you trust,
this referral from draft-ietf-mpls-ldp-capabilities-03.txt appears to
correctly summarize the security considerations for this draft.

nits:

Section 2, fourth dash point
OLD
    - Includes an IANA considerations section that requests IANA for
     assignment of code point for the optional parameter corresponding
NEW
    - Includes an IANA considerations section that requests IANA
     assignment of a code point for the optional parameter corresponding

Section 3:
2nd paragraph: insert "a" or "the" after "The format of".
Page 5/6: do not split ASCII art over a page boundary.

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-634-2066 (home)
 155 Beaver Street
 Milford, MA 01757 USA
 d3e3e3@gmail.com