[secdir] Secdir last call review of draft-ietf-dcrup-dkim-crypto-12
Paul Wouters <firstname.lastname@example.org> Mon, 11 June 2018 16:58 UTC
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 51CFC130E76; Mon, 11 Jun 2018 09:58:35 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
From: Paul Wouters <email@example.com>
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
Date: Mon, 11 Jun 2018 09:58:35 -0700
Subject: [secdir] Secdir last call review of draft-ietf-dcrup-dkim-crypto-12
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:email@example.com?subject=unsubscribe>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:firstname.lastname@example.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 16:58:36 -0000
Reviewer: Paul Wouters Review result: Has Nits NITS: I believe the [FIPS-180-4-2015] reference should be replaced with a reference to RFC-6376 Remove or indicate the RFC Editor should remove the following text: Discussion Venue: Discussion about this draft is directed to the email@example.com  mailing list. This sentence doesn't parse easily: This is an additional DKIM signature algorithm added to Section 3.3 of [RFC6376] as envisioned in Section 3.3.4 of [RFC6376]. It should simply say something like "This document adds an additional key algorithm type to the DKIM Key Type Registry and a new signature type to the DKIM Hash Algorithms Registry" This text reads a little odd: Ed25519 is a widely used cryptographic technique, so the security of DKIM signatures using new signing algorithms should be at least as good as those using old algorithms. It seems to suggest that being "widely used" is a guarantee for being "at least as good as older stuff". Better would be to just point to the Security Considerations of RFC 8032 Section 4 and 8 have an introductory lines that says "update as follows" followed by a dot instead of a colon. That is a little confusing to the reader, as if some text is missing before the dot.
- [secdir] Secdir last call review of draft-ietf-dc… Paul Wouters