Re: [secdir] secdir review of draft-ietf-sidr-origin-ops-22

Randy Bush <randy@psg.com> Tue, 19 November 2013 04:22 UTC

Return-Path: <randy@psg.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3353C1AED2E; Mon, 18 Nov 2013 20:22:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.425
X-Spam-Level:
X-Spam-Status: No, score=-2.425 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.525] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T2JzuVWF6r1S; Mon, 18 Nov 2013 20:21:58 -0800 (PST)
Received: from ran.psg.com (ran.psg.com [IPv6:2001:418:8006::18]) by ietfa.amsl.com (Postfix) with ESMTP id C5E651AE667; Mon, 18 Nov 2013 20:21:58 -0800 (PST)
Received: from localhost ([127.0.0.1] helo=ryuu.psg.com.psg.com) by ran.psg.com with esmtp (Exim 4.76) (envelope-from <randy@psg.com>) id 1Vicox-000117-D3; Tue, 19 Nov 2013 04:21:51 +0000
Date: Tue, 19 Nov 2013 13:21:44 +0900
Message-ID: <m21u2dyqav.wl%randy@psg.com>
From: Randy Bush <randy@psg.com>
To: Tom Yu <tlyu@MIT.EDU>
In-Reply-To: <ldv7gc53v7l.fsf@cathode-dark-space.mit.edu>
References: <ldv7gc53v7l.fsf@cathode-dark-space.mit.edu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Cc: draft-ietf-sidr-origin-ops.all@tools.ietf.org, iesg@ietf.org, secdir@ietf.org
Subject: Re: [secdir] secdir review of draft-ietf-sidr-origin-ops-22
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2013 04:22:00 -0000

thanks for the review

> There should probably be an example of the sort of privilege
> escalation attacks that can result from incautious Local-Preference
> attributes.

how about

   Local-Preference may be used to carry both the validity state of a
   prefix along with its traffic engineering (TE) characteristic(s).  It
   is likely that an operator already using Local-Preference will have
   to change policy so they can encode these two separate
   characteristics in the same BGP attribute without negative impact or
   opening privilege escalation attacks.  E.g. do not encode validation
   state in higher bits than used for TE.

or do we need to spell it out with a hammer?

> In Section 4, "along with it's traffic engineering characteristic(s)",
> change "it's" to "its".

<blush>

> Section 5 mentions a block 10.0.666.0/24, which is somewhat
> distracting because that is not a valid IPv4 address block.

it's meant to be clearly invalid.  the standard docco block could not be
used as it was not big enough for the example (ops will laugh at 666 but
freak out and rathole on a prefix longer than a /24).

again, thanks.

randy