Re: [secdir] Secdir early review of draft-ietf-idr-segment-routing-te-policy-18

[Ketan Talaulikar <[e-mail]>]

Hi Vincent,

The draft update has just been posted:
https://datatracker.ietf.org/doc/html/draft-ietf-idr-segment-routing-te-policy-19

Please let us know if it addresses your comments.

Thanks,
Ketan


On Tue, Jul 19, 2022 at 9:44 PM Ketan Talaulikar <[e-mail]>
wrote:

> Hi Vincent,
>
> Thanks for your review.
>
> All the sub-TLVs defined in this document are carried inside the Tunnel
> Encapsulation Attribute which is defined by RFC9012. It is expected that
> the reader is aware of that document and especially Sec 2 of RFC9012 which
> specifies the design of the TLVs/sub-TLVs of this attribute. That said, we
> will describe and clarify the units for the length field.
>
> We'll post an update with these changes once the submission tool reopens.
>
> Thanks,
> Ketan
>
>
> On Mon, Jul 18, 2022 at 9:27 PM Vincent Roca via Datatracker <
> [e-mail]> wrote:
>
>> Reviewer: Vincent Roca
>> Review result: Ready
>>
>> Hello,
>>
>> I have reviewed this document as part of the security directorate’s
>> ongoing
>> effort to review all IETF documents being processed by the IESG. These
>> comments were written primarily for the benefit of the security area
>> directors. Document editors and WG chairs should treat these comments just
>> like any other last call comments.
>>
>> Summary: Ready
>>
>> I have no comment regarding the security part. Most issues seem fairly
>> classic
>> when dealing with BGP peering and the Security Considerations section
>> reminds
>> it's the responsibility of the network operator to guarranty that traffic
>> is
>> restricted to trusted domain/nodes. I don't know the domain but it seems
>> reasonable.
>>
>> Otherwise, a minor comment.
>> Section 2.4.1: I suggest being a bit more informative when describing
>> Type and
>> Length fields (this is the first mention of the packet format): >   o
>> Type: 12
>> >   o  Length: 6.
>>
>> There's no explanation and no unit.
>> As I understand, 12 is a reserved value for a "Preference Sub-TLV", say
>> it, and
>> Length is 6 bytes long, encompassing the Flags, RESERVED, and Preference
>> fields, say that too (at least the 1st time).
>>
>> Cheers,
>>
>> Vincent
>>
>>
>>