Re: [secdir] Secdir last call review of draft-ietf-quic-recovery-32

Lucas Pardue <lucaspardue.24.7@gmail.com> Mon, 02 November 2020 21:07 UTC

Return-Path: <lucaspardue.24.7@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE4EC3A0E5A; Mon, 2 Nov 2020 13:07:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.847
X-Spam-Level:
X-Spam-Status: No, score=-1.847 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2lQUh1_Au-mr; Mon, 2 Nov 2020 13:07:15 -0800 (PST)
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1582C3A0C98; Mon, 2 Nov 2020 13:07:12 -0800 (PST)
Received: by mail-ej1-x634.google.com with SMTP id o9so18721749ejg.1; Mon, 02 Nov 2020 13:07:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qN/IdIkus/RRbGeQuoYaR7sRVAgw/Zh3m7oqKKL8FyY=; b=AEQBJqW3DgnUvTy/99nlLyR7WxRqnPjzOLwktf8WqpfyHEDjxS6Wc9st4EObzitwUb qbPJM/pAMzzvKf02hSt6mcsjjP7fnXbm1NASWlhr24W1xuZxbhII+iFdCH+eH8cyZGct EOpWktf0GNhvSdSRquauPZBWCDHD97/MCUQ+Oi9CBJrtM/J0gOGRZOphFUWfdXCV42PZ gtGDr2zuC6SnYfpk1zgZvp7rj6l2zQFsF6eZ2BVi4rpqBvghjmkVbCMLFR5CZh7WuddM 523J/WfTxR1J0yt22T/iInNgsxm3pC0roPb2W5078Egsu8pHlkBEAYet2upjHRFdKEfw Bhbw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qN/IdIkus/RRbGeQuoYaR7sRVAgw/Zh3m7oqKKL8FyY=; b=ky1Mb7UPNCj2DpTLKYOoUApDqy7nZ4NLtveF7ibV3vfqH7gSiS0n+ibcLWvtwoUJ0j rTAtuOeJE2MhqMhZJRkCH/CTxcFJ+cHbDCNbFoOg7RuK7lvAhNfpn1hsTYEz6YxeROES E2FBB0H+coUAxpN5gxEYn97I8MGb9hm7wwJ6w1BBSQ0YOmxCJL3Enm9hR0K9kjn/H+L4 tTKD7Ke5NUEbLBHekeS8GnbWuSHDawr5aa8r8ab5lf9iFwgPswpo1MyLQ/845zfv8fM+ CvCS9MwY65MYhKQGBknU6OTvi6LjSd6pLDRE2TFVmZDeFlRYWBnaSVdD+eSVD9Xt6YbA Zn0g==
X-Gm-Message-State: AOAM530NthcuPeu/0rWqnqilzQpGmuG2/lmXYEwkLo8Dka4JyW/wJGSo LrWy1btmB0Hq84rLyI6rOcue6+jXsHrUSzyF2xiXwSXnwcs=
X-Google-Smtp-Source: ABdhPJxc/hHWE0LvGBffQqyWgLv6JNmXw8OJBSrZIc3nBqG3Xo2XiG0MOdqn4Fry6+SVXV7Je7x+bIh1ScIrPZwKNyU=
X-Received: by 2002:a17:906:b084:: with SMTP id x4mr17736633ejy.374.1604351230585; Mon, 02 Nov 2020 13:07:10 -0800 (PST)
MIME-Version: 1.0
References: <160434842876.26069.16673628080135964837@ietfa.amsl.com>
In-Reply-To: <160434842876.26069.16673628080135964837@ietfa.amsl.com>
From: Lucas Pardue <lucaspardue.24.7@gmail.com>
Date: Mon, 02 Nov 2020 21:06:58 +0000
Message-ID: <CALGR9obcV-dGxG6yBNJiNv9ir3+wgRa-54NyzmQ-R-prtaNXqw@mail.gmail.com>
To: Derrell Piper <ddp@electric-loft.org>
Cc: secdir@ietf.org, last-call@ietf.org, draft-ietf-quic-recovery.all@ietf.org, QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000031b06a05b32621e2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/b71SGjR9VzMmtZKGdHN1MIal98Q>
Subject: Re: [secdir] Secdir last call review of draft-ietf-quic-recovery-32
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2020 21:07:17 -0000

Hi Derrell,

Thank you for the review. I've opened a GitHub issue for any discussion
related to this review: https://github.com/quicwg/base-drafts/issues/4324

There is also a milestone at
https://github.com/quicwg/base-drafts/milestone/8.

Thanks,
Lucas

On Mon, Nov 2, 2020 at 8:20 PM Derrell Piper via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Derrell Piper
> Review result: Ready
>
> I have reviewed this document as part of the security directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written primarily for the benefit of the security area
> directors.  Document editors and WG chairs should treat these comments just
> like any other last call comments.
>
> The summary of the review is: Ready, with an optional nit.
>
> This document is QUIC's Loss Detection and Congestion Control and is part
> of
> QUIC Last Call.
>
> Pp. 7, "after the epoch starts is acknowledged" should maybe be singular,
> unless the intent is literal and I'm missing what a "starts" is.
>
> There's no explicit security going on here, other than in the larger
> picture
> of QUIC itself, namely that in QUIC-TLS and QUIC-TRANSPORT; this is only
> its
> congestion control.  However, Security Considerations correctly highlights
> some of the major traffic analysis concerns with QUIC and congestion
> control
> in general, and there are some, but these are not unique to QUIC, nor would
> they likely be addressed inside of congestion control, so this is okay.  It
> seems well written and based on a practical understanding of existing TCP
> congestion control along with current academic research on this topic.
>
> Derrell
>
>
>