Re: [secdir] sectdir review of draft-ietf-isis-node-admin-tag-08

Catherine Meadows <catherine.meadows@nrl.navy.mil> Tue, 26 April 2016 20:06 UTC

Return-Path: <catherine.meadows@nrl.navy.mil>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84A1912D56C; Tue, 26 Apr 2016 13:06:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.897
X-Spam-Level:
X-Spam-Status: No, score=-2.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RP_MATCHES_RCVD=-0.996, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JWeo76_jIKQ7; Tue, 26 Apr 2016 13:06:42 -0700 (PDT)
Received: from ccs.nrl.navy.mil (mx0.ccs.nrl.navy.mil [IPv6:2001:480:20:118:118::211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A5F412D0BA; Tue, 26 Apr 2016 13:06:42 -0700 (PDT)
Received: from ashurbanipal.fw5540.net (fw5540.nrl.navy.mil [132.250.196.100]) by ccs.nrl.navy.mil (8.14.4/8.14.4) with ESMTP id u3QK64b7019492 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 26 Apr 2016 16:06:04 -0400
Content-Type: multipart/alternative; boundary="Apple-Mail=_70758162-5CEB-481D-852B-6AC37FDAE20A"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Catherine Meadows <catherine.meadows@nrl.navy.mil>
In-Reply-To: <5719D3FA.4070402@gredler.at>
Date: Tue, 26 Apr 2016 16:06:04 -0400
Message-Id: <7609B084-63E4-4341-912B-2083E88F6CB8@nrl.navy.mil>
References: <A72D09E9-4622-41DB-8EA0-62518AA9CA7A@nrl.navy.mil> <5719D3FA.4070402@gredler.at>
To: Hannes Gredler <hannes@gredler.at>
X-Mailer: Apple Mail (2.3124)
X-CCS-MailScanner: No viruses found.
X-CCS-MailScanner-Info: See: http://www.nrl.navy.mil/ccs/support/email
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/epwYoN5xr_EhX38ZVgi7R1OJrQM>
Cc: draft-ietf-isis-node-admin-tag.all@ietf.org, iesg@ietf.org, secdir@ietf.org
Subject: Re: [secdir] sectdir review of draft-ietf-isis-node-admin-tag-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 20:06:46 -0000

Hannes:

My apologies, I could have been a little more clear.

The security considerations section begins with a security consideration:

 
Node administrative tags may be used by operators to indicate
   geographical location or other sensitive information.  The
   information carried in node administrative tags could be leaked to an
   IGP snooper.

This doesn’t come with a citation of any other document, so I assumed it was “new”, and was confused when the
next sentence said the document does not introduce any new security concerns.   If this security consideration also applies to 
RFC5130 and RFC5305, you could cite those (although they do not address this particular issue in their security
concerns section it would still show that you are not introducing any new security concerns).


Cathy 




Catherine Meadows
Naval Research Laboratory
Code 5543
4555 Overlook Ave., S.W.
Washington DC, 20375
phone: 202-767-3490
fax: 202-404-7942
email: catherine.meadows@nrl.navy.mil <mailto:catherine.meadows@nrl.navy.mil>
> On Apr 22, 2016, at 3:34 AM, Hannes Gredler <hannes@gredler.at> wrote:
> 
> catherine,
> 
> i fail to see how this does introduce *new* security concerns.
> 
> background:
> 
> we have in IS-IS two existing tagging mechanism's:
> 
> 1) admin-groups for links
>   https://tools.ietf.org/html/rfc5305#section-3.1
> 
> 2) prefix-tags for prefixes
>   https://tools.ietf.org/html/rfc5130#section-3.1
> 
> both "tagging-spaces" are local administered and have
> no global significance.
> 
> the purpose of draft-ietf-isis-node-admin-tag-08 is to
> add support for a third tagging method which allows tagging
> of an entire node using local administered tagging space.
> (same operational spirit as in 1) and 2) )
> 
> now my question(s):
> 
> - why is adding of an local-administered tag with no implied
>  semantics considered to be security relevant ?
> 
> - what specific (apparently mis-)wording in
>  draft-ietf-isis-node-admin-tag makes you think
>  it is security relevant ?
> 
> /hannes
> 
> On 4/21/16 19:36, Catherine Meadows wrote:
>> I have reviewed this document as part of the security directorate's
>> ongoing effort to review all
>> IETF documents being processed by the IESG.  These comments were written
>> primarily for the
>> benefit of the security area directors.  Document editors and WG chairs
>> should treat these comments
>> just like any other last call comments.
>> 
>> This draft describes an extension to the IS-IS routing protocol, that
>> allows tagging and grouping of nodes
>> in an IS-IS domain.  This makes it possible to increase the efficiency
>> of route and path selection, since the tags
>> give information about a router’s capabilities.
>> 
>> The Security Considerations section correctly identifies one of the main
>> security risks of using such tags:  they may leak
>> sensitive information about, e.g., geographical location.   However, I’m
>> confused by the statement following that:
>> 
>> “This document does not introduce any new security concerns.  Security
>> concerns for IS-IS are already addressed in
>> [ISO10589], [RFC5304], and [RFC5310] are are applicable to the
>> mechanisms described in this document.”
>> 
>> As far as I can tell, this document *does* introduce new security
>> concerns, because the tags may reveal sensitive
>> information that may not have been made available otherwise.  Moreover,
>> RFCs 5304 and 5310 concern authentication, not
>> secrecy, and so do not address information leakage at all.  My own
>> suggestion
>> for a recommendation would be that implementors should weigh the
>> benefits of putting certain kinds of information on tags
>> versus the risk of its being used by an attacker, and make their
>> decisions accordingly.  This would not be a SHOULD a MUST
>> recommendation by the way, but simply advisory.
>> 
>> I’m not sure what is meant by the last sentence in this paragraph:
>> 
>>  Extended authentication mechanisms described in [RFC5304] or [RFC5310]
>> SHOULD be used in
>>    deployments where attackers have access to the physical networks and
>>    nodes included in the IS-IS domain are vulnerable.
>> 
>> Is this addressing the problem of sensitive information on tags?  If so,
>> you need to say how.   If it is addressing
>> spoofing of tags, it should be given its own paragraph, and the threat
>> you are talking about should be made clear.
>> 
>> In the last paragraph, on the misattribution of tags from different
>> domains, what would you recommend for mitigating against
>> this problem?  Also, since this is in the security considerations
>> section, you should say something about how an attacker
>> could take advantage of it.
>> 
>> In my opinion, the Security Considerations section needs a major
>> revision.  However,
>> I consider this document Almost Ready, because the purpose of the
>> revision would be mainly to make the section more clear, not to address
>> any overlooked security problems.
>> 
>> 
>> 
>> 
>> Catherine Meadows
>> Naval Research Laboratory
>> Code 5543
>> 4555 Overlook Ave., S.W.
>> Washington DC, 20375
>> phone: 202-767-3490
>> fax: 202-404-7942
>> email: catherine.meadows@nrl.navy.mil
>> <mailto:catherine.meadows@nrl.navy.mil>
>>