[secdir] Secdir last call review of draft-ietf-spring-segment-routing-ldp-interop-11
Takeshi Takahashi <takeshi_takahashi@nict.go.jp> Thu, 24 May 2018 15:45 UTC
Return-Path: <takeshi_takahashi@nict.go.jp>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C5FD312EAB7; Thu, 24 May 2018 08:45:11 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Takeshi Takahashi <takeshi_takahashi@nict.go.jp>
To: secdir@ietf.org
Cc: draft-ietf-spring-segment-routing-ldp-interop.all@ietf.org, spring@ietf.org, iesg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.80.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152717671174.29916.15871063863957499908@ietfa.amsl.com>
Date: Thu, 24 May 2018 08:45:11 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/iYGUowp1p8MuxkN_LtHEE5ebNHU>
Subject: [secdir] Secdir last call review of draft-ietf-spring-segment-routing-ldp-interop-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 15:45:12 -0000
Reviewer: Takeshi Takahashi Review result: Ready I have only minor comments. The section said that security issues in this document are mostly inherited from the underlying techniques/specs. Some pointers to RFC documents describing the security issues of MPLS dataplane, routing protocols, and so on (if any) could help readers. Having these pointers in this section will not harm readers. Some typo: In Section 1: "co- exist" (unnecessary space)-> "co-exist" In Section 2.1: "switches it our" -> "switches it out" Spelling out is appreciated: LDP and FEC Clarification question: Regarding the paragraph "P6 does not have an LDP binding from its next-hop P5 for the FEC "PE1". However P6 has an SR node segment to the IGP route "PE1". Hence, P6 forwards the packet to P5 and swaps its local LDP-label for FEC "PE1" by the equivalent node segment (i.e. 101)."(in Section 4.1), I have got the impression that the behavior of P6 is not defined by any other specs (incl, LDP) and is a behavior this document newly defines, correct? If it is correct, must P6 support this behavior? or is it just optional? I am not familiar with these routing protocols, thus clarification is appreciated.
- [secdir] Secdir last call review of draft-ietf-sp… Takeshi Takahashi