[secdir] Review of draft-ietf-dime-diameter-api-08

Sean Turner <turners@ieca.com> Tue, 16 June 2009 15:45 UTC

Return-Path: <turners@ieca.com>
X-Original-To: secdir@core3.amsl.com
Delivered-To: secdir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 2FB5928C197 for <secdir@core3.amsl.com>; Tue, 16 Jun 2009 08:45:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cYXlId1Y-+JU for <secdir@core3.amsl.com>; Tue, 16 Jun 2009 08:45:12 -0700 (PDT)
Received: from smtp108.biz.mail.mud.yahoo.com (smtp108.biz.mail.mud.yahoo.com [68.142.201.177]) by core3.amsl.com (Postfix) with SMTP id 6060328C19A for <secdir@ietf.org>; Tue, 16 Jun 2009 08:45:12 -0700 (PDT)
Received: (qmail 25351 invoked from network); 16 Jun 2009 15:43:39 -0000
Received: from unknown (HELO thunderfish.local) (turners@98.240.94.168 with plain) by smtp108.biz.mail.mud.yahoo.com with SMTP; 16 Jun 2009 15:43:38 -0000
X-Yahoo-SMTP: qPTWNAeswBAtDTSn9GKlmmL3C90ke7grn_5n9To-
X-YMail-OSG: LczwrxQVM1nAV.q3uoqP7BcU9MEn9kjdoXRFeNzzTPrSFRowpJ9cn1Wx2v8Tts5trmzo7btkwA8i.OkMaZ5oWCozHgCc8OoEhTBZDMkv5UdshlHYXqt6Em4P.laf.QVPq3kwlSWrCJTXLgUojSa8oji0MkpxsHGYuVkRE5VkhmiKGSI33sEHN9REo970V0C3GyPUp75A_hAOwmhbLZS9CCzbSiYrXOAVpqh5aBvmAEMi9.Jkb3I8FwZedTqY7TsGKBacR9TJ7MPOC5AFF8BBrNOpjjFTOQG0u5sMhXb_psRI_RIznHCsEdI1pUhvYEngBQt1hCnDG5mh7CaaJd_.n3daBMHNuU4SJGeIomDHgYx2EQ--
X-Yahoo-Newman-Property: ymail-3
Message-ID: <4A37BDAA.50306@ieca.com>
Date: Tue, 16 Jun 2009 11:43:38 -0400
From: Sean Turner <turners@ieca.com>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: secdir <secdir@ietf.org>, draft-ietf-dime-diameter-api@tools.ietf.org, iesg@ietf.org, dime-chairs@ietf.org
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: Hannes Tschofenig <Hannes.Tschofenig@gmx.net>
Subject: [secdir] Review of draft-ietf-dime-diameter-api-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2009 15:45:13 -0000

I have reviewed this document (twice now) as part of the security 
directorate's ongoing effort to review all IETF documents being 
processed by the IESG. These comments were written primarily for the 
benefit of the security area directors. Document editors and WG chairs 
should treat these comments just like any other last call comments.

This version does not address the comments I made against the -07 
version, notably:

The document needs to discuss the security considerations surrounding 
the API in your document, as opposed to just pointing to RFC5388.

Nits:
- Sec 3.1.1: add "." to end of last sentence
- Sec 3.4.3.1 and 3.4.3.2: r/- The NAI of the user./The NAI of the user.
- Sec 3.4.5.7: Move description before C code.

spt