[secdir] Secdir last call review of draft-ietf-quic-bit-grease-03

Russ Housley via Datatracker <noreply@ietf.org> Thu, 19 May 2022 20:39 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 68263C1D351D; Thu, 19 May 2022 13:39:21 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: draft-ietf-quic-bit-grease.all@ietf.org, last-call@ietf.org, quic@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.2.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165299276141.44947.12840727268667154039@ietfa.amsl.com>
Reply-To: Russ Housley <housley@vigilsec.com>
Date: Thu, 19 May 2022 13:39:21 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/tUvQaSVJJPteFbidY7Uc8TD-3yo>
Subject: [secdir] Secdir last call review of draft-ietf-quic-bit-grease-03
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2022 20:39:21 -0000

Reviewer: Russ Housley
Review result: Has Issues

I reviewed this document as part of the Security Directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the Security Area
Directors.  Document authors, document editors, and WG chairs should
treat these comments just like any other IETF Last Call comments.

Document: draft-ietf-quic-bit-grease-03
Reviewer: Russ Housley
Review Date: 2022-05-19
IETF LC End Date: 2022-06-01
IESG Telechat date: Unknown


Summary: Has Issues


Major Concerns: None


Minor Concerns:

Section 3 says:

   Advertising the grease_quic_bit transport parameter indicates that
   packets sent to this endpoint MAY set a value of 0 for the QUIC Bit.

This does not align with the definition of MAY in RFC 2119.
I suggest:

   Advertising the grease_quic_bit transport parameter indicates that
   packets sent to this endpoint will be accepted with a value of 0 for
   the QUIC Bit.
   
Section 3 also says:

   A client MAY forget the value.

This might align with the definition of MAY in RFC 2119.

   The client can either remember or forget, as the implementer chooses?

Section 3.1 says:

   A server cannot remember that a client
   negotiated the extension in a previous connection and clear the QUIC
   Bit based on that information.

and

   An endpoint cannot clear the QUIC Bit without knowing whether the
   peer supports the extension. 

s/cannot/MUST NOT/ (both places)