Re: [secdir] Secdir Review of draft-ietf-manet-olsrv2-dat-metric-08

[Dacheng <[e-mail]>]

Sorry for sending out an unfinished email by mistake. See my comments in line please.

在 2015年11月17日，下午5:14，Henning Rogge <[e-mail]> 写道：

> On 11/15/2015 08:40 AM, Dacheng wrote:
>> Dear all,
>> 
>> I have reviewed this document as part of the security directorate's
>> ongoing effort to review all IETF documents being processed by the IESG.
>> 
>> These comments were written primarily for the benefit of the security
>> area directors. Document editors and WG chairs should treat these
>> comments just like any other last call comments.
>> 
>> This draft is about a new routing  metro for OLSRv2.
>> 
>> 
>> Technical questions/comments:
>> 
>> 1) In this draft, “RFC5444 packet” can be found in many places. I didn’t
>> find the definition of this term. Do you indicate this solution may need
>> to process a packet which is not specified in OLSRv2?
> 
> The header of the Terminology Section contains the following paragraph:
> 
>   The terminology introduced in [RFC5444], [RFC7181] and [RFC6130],
>   including the terms "packet", "message" and "TLV" are to be
>   interpreted as described therein.
> 
> Do you think this paragraph needs to be improved or extended?

Ok, I think ’a packet specified in RFC5444' looks better. But it is not a big problem.
> 
>> 2) There is a good security consideration section in RFC 7181. Since
>> this draft is closely related to OLSRv2 (although this work does not
>> specify any new message or TLV), it will be good to build the security
>> considerations of this work based upon what has been discussed in
>> RFC7181. For example, maybe the authors could say ’there will be some
>> new security issues introduced by this work but not mentioned in RFC
>> 7181, there will be some security issues if we only use the mandatory
>> security mechanism specified in RFC7181, or our work does not introduce
>> any additional security issues..
> 
> I think my security considerations section explicitly says (in the last sentence) that the Mandatory Security Mechanism for OLSRv2 (RFC7183) does NOT protect against modified packet sequence numbers.

It is fine. I just tried to give some comments to make this section looks better, and I understand your point. In addition, maybe you could mention at the end of the fist paragraph that the methods of protecting against the MITM attacks performed by rogue routers are out of scope. 
> 
>> 3) This question is about the last sentencoe in the security
>> consideration—“The signature scheme described in [RFC7183] does not
>> protect the additional sequence number of the DAT metric because it does
>> only sign the RFC5444 messages, not the RFC5444 packet header.” First of
>> all, there is no signature mechanism specified in RFC7183, only HMAC is
>> used to protect the message integrity. In addition, the RFC7183 reuse
>> the process specified in RFC7182 to generate hashes, and so it should be
>> able to cover the message headers.   Open for discussion.
> 
> RFC7183 introduces a RFC5444 message level integrity protection extension for RFC7181 (OLSRv2), based on the ICV Message TLV defined in RFC7182 (see section 9.1 of RFC7182).
> 
> The ICV Message TLV does NOT protect the PACKET header fields of RFC5444 packets, including the RFC5444 packet sequence number.

Ok, you have answered my second question, and I think you are right.  The first comment about this sentence is to replace  “signature mechanism “ with “security mechanism”, because only there is only a HMAC mechanism specified in RFC 7183, right?
> 
>> Editorial:
>> 
>> Section 2:
>> 
>> MAX(a,b) -> MAX(a, b)
>> 
>> Section 3:
>> 
>> The administrator should take care that link layer multicast
>> transmission do not not have ->  The administrator should take care that
>> link layer multicast transmission do not have
>> 
>> Section 4:
>> 
>> The routing decision of most operation systems don't take packet size
>> into account. -> The routing decisions of most operation systems don't
>> take packet size into account.
>> 
>> Section 7:
>> 
>> with a very slow or very fast linklayer -> with a very slow or very fast
>> link layer
> 
> Will be fixed in the next revision.
> 
> Henning Rogge
> 
> -- 
> Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
> Kommunikation, Informationsverarbeitung und Ergonomie FKIE
> Kommunikationssysteme (KOM)
> Fraunhofer Straße 20, 53343 Wachtberg, Germany
> Telefon [phone],   Fax [phone]
> mailto:[e-mail] http://www.fkie.fraunhofer.de