[secdir] Secdir telechat review of draft-ietf-dnssd-push-19

Liang Xia via Datatracker <noreply@ietf.org> Fri, 17 May 2019 07:47 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4380312004E; Fri, 17 May 2019 00:47:19 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Liang Xia via Datatracker <noreply@ietf.org>
To: <secdir@ietf.org>
Cc: draft-ietf-dnssd-push.all@ietf.org, dnssd@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.96.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Liang Xia <frank.xialiang@huawei.com>
Message-ID: <155807923913.14794.15819590021470228961@ietfa.amsl.com>
Date: Fri, 17 May 2019 00:47:19 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/zHBrhCzkL3JJff-8wPjRFj3kz1w>
Subject: [secdir] Secdir telechat review of draft-ietf-dnssd-push-19
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 May 2019 07:47:20 -0000

Reviewer: Liang Xia
Review result: Has Issues

Nit:
1. Section 6.1, s/This connection is made to TCP port 853, the default port for
DNS-over-TLS DNS over TLS [RFC7858]./This connection is made to TCP port 853,
the default port for DNS-over-TLS [RFC7858]. 2. Table 2, RECONFIRM should be
C-U TLV type.

Comments:
1. why are UNSUBSCRIBE and RECONFIRM the client unidirectional message?
2. In UNSUBSCRIBE message, why do you choose to use SUBSCRIBE MESSAGE ID, not
NAME+TYPE+CLASS? 3. In the section of Security Considerations:
    1) you should also mention that TLS provides the anti-replay protection
    service for DNS Push; 2) maybe you need to consider the client
    authentication to achieve policy control and detect illegal client; 3) TLS
    WG are specifying the SNI encryption mechanism, will it influence your TLS
    name authentication?