Re: [Sedate] [Last-Call] Genart last call review of draft-ietf-sedate-datetime-extended-08
Lars Eggert <lars@eggert.org> Fri, 13 October 2023 10:21 UTC
Return-Path: <lars@eggert.org>
X-Original-To: sedate@ietfa.amsl.com
Delivered-To: sedate@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F6EDC19E111; Fri, 13 Oct 2023 03:21:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xIG1nh8huj33; Fri, 13 Oct 2023 03:21:48 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7427C193321; Fri, 13 Oct 2023 03:21:45 -0700 (PDT)
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 833EC8141A; Fri, 13 Oct 2023 13:21:42 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eggert.org; s=dkim; t=1697192502; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=1w/jo10ByYU0SqkLMRhha1Z0prxOROimKElt8gfzDrs=; b=U2NysCIgG3MgB9LIuMTGecj/GeqmjdAcVcuIgK6lvmnP4No0OOVRX5yuZbkdWIfybaobxU lAycxCpwkoy6EHH4HkWzON2IICxz44GxvZY8uQse3ADbWi+Z5Tj1iLt4F0+hIayZ7PCZCN x8tylz5o8/UvFIaWADcTNP5USyT7mziQrK5krOgQiT0PMvEprDfek6ZpHK66BvZut+SaRA 59+BX0i6JFYQrce376QOqbGY4cm4nSgS86EV6qRmLbxDw1IDSiTezdEJ0dycNiRO94xb01 9vGxJEHAbZWw1VGIPw71AmbtrBpIah54DOV/eylg92NDJBUKvwNilzJAaQ80Dg==
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <168669354814.20988.10663719502851932944@ietfa.amsl.com>
Date: Fri, 13 Oct 2023 13:21:42 +0300
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-sedate-datetime-extended.all@ietf.org, last-call@ietf.org, sedate@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <84403A94-5B2C-4154-824E-CF7FC349CD61@eggert.org>
References: <168669354814.20988.10663719502851932944@ietfa.amsl.com>
To: Robert Sparks <rjsparks@nostrum.com>
X-Last-TLS-Session-Version: TLSv1.2
Archived-At: <https://mailarchive.ietf.org/arch/msg/sedate/ihLTgBPhM5xmPvrtCCtHUc0zoKo>
Subject: Re: [Sedate] [Last-Call] Genart last call review of draft-ietf-sedate-datetime-extended-08
X-BeenThere: sedate@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Serialising Extended Data About Times and Events <sedate.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sedate>, <mailto:sedate-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sedate/>
List-Post: <mailto:sedate@ietf.org>
List-Help: <mailto:sedate-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sedate>, <mailto:sedate-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2023 10:21:53 -0000
Robert, thank you for your review and thank you all for the following discussion. I have entered a Discuss ballot for this document based on my own review (which I think will be straightforward to address). Lars > On Jun 14, 2023, at 00:59, Robert Sparks via Datatracker <noreply@ietf.org> wrote: > > Reviewer: Robert Sparks > Review result: Ready with Issues > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. > > Document: draft-ietf-sedate-datetime-extended-08 > Reviewer: Robert Sparks > Review Date: 2023-06-13 > IETF LC End Date: 2023-06-15 > IESG Telechat date: Not scheduled for a telechat > > Summary: Essentially ready for publication as a Proposed Standard RFC, but with > issue to consider before full IESG review (Ready with Issues) > > Issue: > > The ABNF for suffix-key allow productions like "_----", "a---", and "a----b". > I'm guessing at intent, but my guess is that you essentially wanted the same > production you allow for the suffix values, but you want to restrict that to > the set of values that start with either _ or [a-z]. If my guess is correct, I > can help construct alternate ABNF. > > I have a similar question about time-zone-part where you in a comment rule out > the two productions "." and "..". Should you say anything about 14 dots? Or > ".-.+..+.-."? > > And to make sure - you want to allow more than one / in the time-zone-name > production, such as America/Chicago/Canaryville? > > Editorial Nits: > > At scope, you say "way to attach any additional information". I suggest "way to > attach additional information" is enough. > > The definition of UTC has a a short bit of history in it that is interesting, > but unnecessary for this document. Consider removing from "From 1972" to the > end of the first paragraph of the definition. (If you want to point to history, > choose a rich informational reference perhaps). > > At the definition of timestamp, I quibble with using "unambiguous". This > document isn't attempting to address disambiguating which 1:30 am you mean when > there were two of them on a DST end day. How would the document suffer if you > simply dropped the word from the definition? > > In the second paragraph of section 2 - I get lost in "former" and "latter" (I'm > not sure the text is pointing where it intends to point). Please consider just > directly stating the convention you are talking about instead. > > The section heading names under section 3 are not particularly helpful, and the > text doesn't quite follow the intended structure that I think inspired them. > It's not really clear that the section does everything that the first sentence > of section 3 says it will. Please consider a gentle restructuring of the > outline into something like "Format of extended information","Registering > extended information tags", "Requirements for producing extension tags", > "Requirements for consuming extension tags". > > > > -- > last-call mailing list > last-call@ietf.org > https://www.ietf.org/mailman/listinfo/last-call
- [Sedate] Genart last call review of draft-ietf-se… Robert Sparks via Datatracker
- Re: [Sedate] Genart last call review of draft-iet… Carsten Bormann
- Re: [Sedate] Genart last call review of draft-iet… Edward Welbourne
- Re: [Sedate] [Gen-art] Genart last call review of… Carsten Bormann
- Re: [Sedate] Genart last call review of draft-iet… Robert Sparks
- Re: [Sedate] [Last-Call] Genart last call review … John C Klensin
- Re: [Sedate] [Last-Call] Genart last call review … Lars Eggert
- Re: [Sedate] [Last-Call] Genart last call review … Edward Welbourne