[sfc] Shepherd Review of draft-ietf-sfc-oam-framework-10

Tal Mizrahi <tal.mizrahi.phd@gmail.com> Mon, 02 September 2019 05:14 UTC

Return-Path: <tal.mizrahi.phd@gmail.com>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EF8412001B; Sun, 1 Sep 2019 22:14:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mXIDPuA_AewR; Sun, 1 Sep 2019 22:14:18 -0700 (PDT)
Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B19401200E9; Sun, 1 Sep 2019 22:14:18 -0700 (PDT)
Received: by mail-qt1-x836.google.com with SMTP id t12so14400193qtp.9; Sun, 01 Sep 2019 22:14:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+yuZ0GMEReACrYXBxZMRMNMEefkgF2/kyJ8DaLAkufU=; b=bcNEEYFJ5foA8zseTbcQjwWKkA3tHkvlTekBNinI5v5LXELjQeL6GZ9ysP42VEHXcI xVwNRO7cU2K3sVFhtDaSOweLvGp/0I8r5yvppd8uR3ZCZOBak8kn76tP1Xli8edRw4UA /Zda/VVrXo+JhsU8kvH/JaJHEqYQga/svNZj1l3axBaI167u6z8GmxeGjdv1vm6JayBx SGr/Bjp8Jgq1+ZaWYjAkEGNNgxg3SHivhdDFDQ9MVTSoodiUpj+0AN720tvYbHn7WqoC hrj/572XqMcp26JWf5suQCrtT/9KU7vG4yN38Aahk7A214wMBEy2Bv23+DMH5A5pkBa+ hXXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+yuZ0GMEReACrYXBxZMRMNMEefkgF2/kyJ8DaLAkufU=; b=uJM4mbhK2AV761QimCPd2qwXczCOT7Y0VDYEQ3sR/2FLuFfxbPRNd6wSI5bY6WEme6 b2UPnByR7/0gFzxnCtriDE6peKMHdTJJdYaZ14bgWoYgEMhddJK/DSt+yNzox5z6DGu0 vJWQVXwc8TY4xgYxV12Q0FH3ChN3JxgyCYvZmcBDUSFCzPRYTFaV9umHyIHKCCBeQlux Yk5x6or0cdcKIu2K39xSxA1HyCIAA/OB5HG1RaeHsxuewkanjkZawKtX3bi51t9km4k5 e/Yy1kKlYPLE0c4KNm1WeiQQ1+yUy/u5oxWM99LA04p42c1XyCbZwj1lSEk4fz3UVJKB qNJg==
X-Gm-Message-State: APjAAAU5FnWNbCWO3BvsGdIFySFXVP+omr1DIDDKWdLeHkJ/DmTEbYh4 HD53B7KwaP9H4Jkua+nCzuhUzHTaUg/otiWcKa6SmUWUM44=
X-Google-Smtp-Source: APXvYqyeFvT36bmrwf7FwvZWm20ChS6YPkPjqv9VBTSGemy/bg7i+WlS1dsrYTY1Yzt4xjSifPNsnjZIuGoTG/440Ko=
X-Received: by 2002:ac8:5286:: with SMTP id s6mr12116257qtn.376.1567401257617; Sun, 01 Sep 2019 22:14:17 -0700 (PDT)
MIME-Version: 1.0
From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Mon, 02 Sep 2019 08:14:05 +0300
Message-ID: <CABUE3XkrHjhTBnmjnxcV0nUJS9kCZ2p6DYcaHD9v7husBkRvsw@mail.gmail.com>
To: draft-ietf-sfc-oam-framework@ietf.org, Service Function Chaining IETF list <sfc@ietf.org>, sfc-chairs@ietf.org
Content-Type: multipart/alternative; boundary="0000000000002e4b2405918b0b7b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/IyY4g2_boVhVkX1Nj4fObpzp-8U>
Subject: [sfc] Shepherd Review of draft-ietf-sfc-oam-framework-10
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>, <mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>, <mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Sep 2019 05:14:25 -0000

Hi,

I am the assigned shepherd of draft-ietf-sfc-oam-framework-10.
I believe the document is almost ready for publication.
I have a few (mostly editorial) comments, as follows.
It would be great if the authors could post a new version that addresses
these comments, and then we can proceed with the publication process.


   - RFC 7498 is an informative reference, but the introduction says that
   the reader is expected to be familiar with it. I suggest to change either
   one or the other.
   - Is there a reason why RFC 8459 is a normative reference? I suggest to
   make it informative.
   - Regarding IOAM (Section 6.4.3) - the section describes the
   proof-of-transit draft, but should also mention
   - draft-ietf-sfc-ioam-nsh.
   - Section 1 (Introduction) lists the content in the rest of the
   sections, but does not mention Section 6, which suggests candidate tools.
   - "with the same" ==> "this terminology"
   - "The link layer, which is dependent upon the physical technology
   used." ==> "The link layer, which is tightly coupled with the physical
   technology used."
   - "depicts a sample example" ==> "depicts an example"
   - In Tables 3 and 4, it is not clear why some of the columns are
   separated by "|", and some are separated by "+".
   - "Tables 4" ==> "Table 4"
   - "for fast failure detection" - I suggest to remove the word fast, as
   BFD is not necessarily fast.
   - Section 6.4 says that "This section describes the applicability of
   some of the available toolsets in the service layer.", however, section
   "6.4.4 SFC Traceroute" describes a tool that was defined in an expired
   individual submission. I suggest to either remove section 6.4.4., or to
   explicitly mention that this draft has expired, and that a new tool can be
   defined along the lines of this proposal.
   - Section 3 describes three OAM components (SF, SFC, Classifier), but
   then Section 5 and Section 7 (Table 3, Table 4) do not refer to these three
   components, but to Underlay, Overlay, SF and SFC. Please be consistent, so
   that Section 5-7 refer to the same components that were defined in Section
   3.
   - Moreover, in Section 3, for each of the first two components (SF and
   SFC) there is a discussion about availability and performance measurement.
   However, for the third component (Classifier), there is no explicit
   discussion about availability and performance measurement. I suggest to add
   this missing discussion (even if these functions are not required, it is
   still important to mention this).

Cheers,
Tal.