Re: [sfc] Eric Rescorla's No Objection on draft-farrel-sfc-convent-05: (with COMMENT)

"Adrian Farrel" <adrian@olddog.co.uk> Thu, 08 February 2018 20:17 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 840061270A0; Thu, 8 Feb 2018 12:17:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a1y8UFiKOZjX; Thu, 8 Feb 2018 12:17:02 -0800 (PST)
Received: from mta5.iomartmail.com (mta5.iomartmail.com [62.128.193.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 37B44120047; Thu, 8 Feb 2018 12:17:02 -0800 (PST)
Received: from vs1.iomartmail.com (vs1.iomartmail.com [10.12.10.121]) by mta5.iomartmail.com (8.14.4/8.14.4) with ESMTP id w18KGwIR001259; Thu, 8 Feb 2018 20:16:58 GMT
Received: from vs1.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0B212203B; Thu, 8 Feb 2018 20:16:58 +0000 (GMT)
Received: from asmtp5.iomartmail.com (unknown [10.12.10.176]) by vs1.iomartmail.com (Postfix) with ESMTPS id 8B59C2203A; Thu, 8 Feb 2018 20:16:58 +0000 (GMT)
Received: from 950129200 ([193.57.120.78]) (authenticated bits=0) by asmtp5.iomartmail.com (8.13.8/8.13.8) with ESMTP id w18KGujv005895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 8 Feb 2018 20:16:57 GMT
Reply-To: adrian@olddog.co.uk
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Eric Rescorla' <ekr@rtfm.com>, 'The IESG' <iesg@ietf.org>
Cc: draft-farrel-sfc-convent@ietf.org, tal.mizrahi.phd@gmail.com, sfc-chairs@ietf.org, sfc@ietf.org
References: <151797352162.25862.18235247183979141834.idtracker@ietfa.amsl.com>
In-Reply-To: <151797352162.25862.18235247183979141834.idtracker@ietfa.amsl.com>
Date: Thu, 08 Feb 2018 20:16:54 -0000
Message-ID: <09be01d3a119$c48d8660$4da89320$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFqI5IkPYyf4zmQLNQRTemcoGvZYqRt5y/Q
Content-Language: en-gb
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.0.0.1623-8.2.0.1013-23650.002
X-TM-AS-Result: No--7.440-10.0-31-10
X-imss-scan-details: No--7.440-10.0-31-10
X-TMASE-Version: IMSVA-9.0.0.1623-8.2.1013-23650.002
X-TMASE-Result: 10--7.439600-10.000000
X-TMASE-MatchedRID: HXSqh3WYKfunykMun0J1wvHkpkyUphL9AG+WI8pfMRy638ZUY6gSdzvN 6k1DPLJE7vbNU29QkanX+0jbkwoUhGE5mDD5AtZVz5rIW0RbS5hezmeoa8MJ84fAYSb4KlgZvup /d3aJh3h5Zq5B1M+nZAgm5qcgW8yDgYgAQnsnhwNoMLOoNHsM9qI0K26z6c86f7FDYGpyXq2BOj 9MIl3t3EsnypVh05u++qtD56KastmgtZVN50Ccr0fhraIl1Xgxt+hhn8Iy6GWbKItl61J/ycnjL TA/UDoAxpQ77C1A1tqOhzOa6g8KrdHffcqY0OyzfDNC6eq2YlV0puXEpc7bMhciK8qhyyCepTjS syyWfn9DDKa3G4nrLQ==
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/SFdDAtNKLyL36XOHdiQuAtmqbf4>
Subject: Re: [sfc] Eric Rescorla's No Objection on draft-farrel-sfc-convent-05: (with COMMENT)
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>, <mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>, <mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Feb 2018 20:17:04 -0000

Hey Eric,

Thanks for this comment.

>    The need to protect the metadata is not modified by this document and
>    forms part of the NSH definition found in [I-D.ietf-sfc-nsh].
> Nit: I wouldn't limit this to encryption. If you care about integrity/data
> origin authentication, then encryption may not supply that,

If I'm reading you right, you're observing that the mechanism described in the
document might allow an imposter to introduce metadata.

That's sounds like a real problem and we should do something like:

OLD
   The mechanism described in this document might possibly be used to
   introduce packets into the SFC overlay network.  Therefore measures
   SHOULD be taken to ensure authorization of sources of such packets,
   and tunneling of such packets into the network SHOULD be prevented.
   The amount of packets with "Next Protocol" set to "None" on an SFP
   SHOULD be rate limited at each point on the SFP to provide additional
   security.
NEW
   The mechanism described in this document might be used to introduce
   packets into the SFC overlay network and might be used to
   illegitimately introduce false metadata to the nodes on an SFC. 
   Therefore measures SHOULD be taken to ensure authorization of sources
   of such packets, and tunneling of such packets into the network
   SHOULD be prevented. 
   
   The amount of packets with "Next Protocol" set to "None" on an SFP
   SHOULD be rate limited at each point on the SFP to provide additional
   network security.
END

Does that do it?

Cheers,
Adrian