Re: [Sidrops] WG Adoption call for draft-spaghetti-sidrops-rfc6482bis-00 (10/2-10/17)

Russ Housley <housley@vigilsec.com> Mon, 03 October 2022 12:49 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8123EC1522D3 for <sidrops@ietfa.amsl.com>; Mon, 3 Oct 2022 05:49:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.908
X-Spam-Level:
X-Spam-Status: No, score=-1.908 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UgDrAW03fWIB for <sidrops@ietfa.amsl.com>; Mon, 3 Oct 2022 05:49:26 -0700 (PDT)
Received: from mail3.g24.pair.com (mail3.g24.pair.com [66.39.134.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 443F5C1522D1 for <sidrops@ietf.org>; Mon, 3 Oct 2022 05:49:26 -0700 (PDT)
Received: from mail3.g24.pair.com (localhost [127.0.0.1]) by mail3.g24.pair.com (Postfix) with ESMTP id 72E27149059; Mon, 3 Oct 2022 08:49:25 -0400 (EDT)
Received: from [10.0.1.2] (pfs.iad.rg.net [198.180.150.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail3.g24.pair.com (Postfix) with ESMTPSA id 4FC74148F56; Mon, 3 Oct 2022 08:49:25 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <0038762F-9173-4DA4-8547-E5EB27B8E477@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_A64CF0D2-48DA-4B79-B07D-65E58DBD8D7C"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Date: Mon, 03 Oct 2022 08:49:24 -0400
In-Reply-To: <BYAPR18MB269634234CBC85CBD2627589C1589@BYAPR18MB2696.namprd18.prod.outlook.com>
Cc: "sidrops@ietf.org" <sidrops@ietf.org>
To: Keyur Patel <keyur@arrcus.com>
References: <BYAPR18MB269634234CBC85CBD2627589C1589@BYAPR18MB2696.namprd18.prod.outlook.com>
X-Mailer: Apple Mail (2.3445.104.21)
X-Scanned-By: mailmunge 3.09 on 66.39.134.11
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/yUQyEngrTOnfeXEAtzm3jYH05lc>
Subject: Re: [Sidrops] WG Adoption call for draft-spaghetti-sidrops-rfc6482bis-00 (10/2-10/17)
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Oct 2022 12:49:27 -0000

I support adoption.  I also provide a few comments below.

This draft should be consistent with CMS (RFC 5652) about the use of "content-type" and "ContentType" and "content type".

In CMS, "ContentType" is the ASN.1 type for an OID that tells the content type that be being signed, encrypted, or otherwise protected.

In CMS, the "content-type" attribute carries the OID associated with the EncapsulatedContentInfo, which allows the OID to be covered by the signature.

In CMS, the "content type" phrase is used when not talking about the ContentType or content-type attribute.

Therefore, I think Section 3 should be:

3.  The ROA Content Type

   The ContentType for a ROA is defined as routeOriginAuthz and has the
   numerical value of 1.2.840.113549.1.9.16.1.24.

   This OID MUST appear both within the eContentType in the
   encapContentInfo object as well as the content-type signed attribute
   in the signerInfo object (see [RFC6488]).

In Section 4, I do not think the inclusion of empty "CONSTRAINED BY" will help an implementer.  That said, I do think the comments are very helpful.

Russ

> On Oct 2, 2022, at 7:38 PM, Keyur Patel <keyur@arrcus.com> wrote:
> 
> Hi Folks,
>  
> The draft author has requested SIDROPS working group adoption call of “A Profile for Route Origin Authorizations (ROAs)”, https://datatracker.ietf.org/doc/draft-spaghetti-sidrops-rfc6482bis/ <https://datatracker.ietf.org/doc/draft-spaghetti-sidrops-rfc6482bis/>.
>  
> Please send your comments to the list. This adoption call will conclude on October 17 2022.
>  
> Regards,
> Chris & Keyur
>  
> _______________________________________________
> Sidrops mailing list
> Sidrops@ietf.org <mailto:Sidrops@ietf.org>
> https://www.ietf.org/mailman/listinfo/sidrops <https://www.ietf.org/mailman/listinfo/sidrops>