[sip-clf] Fwd: AppsDir review of draft-ietf-sipclf-format-05

Peter Musgrave <musgravepj@gmail.com> Fri, 20 January 2012 10:49 UTC

Return-Path: <musgravepj@gmail.com>
X-Original-To: sip-clf@ietfa.amsl.com
Delivered-To: sip-clf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 58F1C21F85EA for <sip-clf@ietfa.amsl.com>; Fri, 20 Jan 2012 02:49:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.448
X-Spam-Level:
X-Spam-Status: No, score=-2.448 tagged_above=-999 required=5 tests=[AWL=-1.150, BAYES_00=-2.599, HTML_MESSAGE=0.001, MANGLED_DEALS=2.3, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TwuySzsQsyRk for <sip-clf@ietfa.amsl.com>; Fri, 20 Jan 2012 02:49:32 -0800 (PST)
Received: from mail-qw0-f51.google.com (mail-qw0-f51.google.com [209.85.216.51]) by ietfa.amsl.com (Postfix) with ESMTP id 39FDD21F85DB for <sip-clf@ietf.org>; Fri, 20 Jan 2012 02:49:32 -0800 (PST)
Received: by qabj34 with SMTP id j34so260644qab.10 for <sip-clf@ietf.org>; Fri, 20 Jan 2012 02:49:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:content-type:subject:date:references:to:message-id :mime-version:x-mailer; bh=Ia7By8sTe79PLK5P0mRDklFKZSlvghtEuA6UWqf5tpE=; b=oDqct7681cPePCuf7KwiRV/S/ZsOVgrGuuAQKq8AMiSGBo3yRlJLjvzR+aYo07tCGQ sQx3mCa+2cSThfMpXNnzIDnqa0CU+uiBeDMx4eTAG9WRueFgMpGM28nU4+PsHmGIIvbp +AvZBExUn2DTmXHx+FhATLFW/t2Y1bRTAWzKU=
Received: by 10.224.111.6 with SMTP id q6mr32779664qap.65.1327056570417; Fri, 20 Jan 2012 02:49:30 -0800 (PST)
Received: from [192.168.1.105] ([204.237.33.112]) by mx.google.com with ESMTPS id q14sm5873160qap.4.2012.01.20.02.49.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Jan 2012 02:49:29 -0800 (PST)
From: Peter Musgrave <musgravepj@gmail.com>
Content-Type: multipart/alternative; boundary=Apple-Mail-4-857016233
Date: Fri, 20 Jan 2012 05:49:27 -0500
References: <alpine.OSX.2.02.1201161423200.36734@mac-allocchio3.garrtest.units.it>
To: sip-clf@ietf.org
Message-Id: <99979207-4176-46FC-AF7A-3B437D5D3B2B@gmail.com>
Mime-Version: 1.0 (Apple Message framework v1084)
X-Mailer: Apple Mail (2.1084)
Subject: [sip-clf] Fwd: AppsDir review of draft-ietf-sipclf-format-05
X-BeenThere: sip-clf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIP Common Log File format discussion list <sip-clf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sip-clf>
List-Post: <mailto:sip-clf@ietf.org>
List-Help: <mailto:sip-clf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2012 10:49:33 -0000


Begin forwarded message:

> From: Claudio Allocchio <Claudio.Allocchio@garr.it>
> Date: January 19, 2012 5:21:29 AM EST
> To: apps-discuss@ietf.org, draft-ietf-sipclf-format.all@tools.ietf.org
> Subject: AppsDir review of draft-ietf-sipclf-format-05
> 
> 
> I have been selected as the Applications Area Directorate reviewer for this draft (for background on appsdir, please see http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).
> 
> Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft.
> 
> Document: draft-ietf-sipclf-format-05
> Title: Format for the Session Initiation Protocol (SIP) Common Log Format
>       (CLF)
> Reviewer: Claudio Allocchio
> Review Date: 2012-01-18
> IETF Last Call Date: unknown
> IESG Telechat Date: unknown
> 
> NOTE: is there is an IESG telechat which I'm missing, just copy this messae to iesg ML!
> 
> Summary:
> 
> This draft is ready for publication as a Proposed Standard RFC; it just needs one consideration about a minor issue about an external reference, and fixing some Nits.
> 
> Major Issues:
> 
> NONE
> 
> Minor Issues:
> 
> just one !
> 
> * Section "3. Document Conventions"
> 
> The authors have decided "For the sake of clarity and completeness" to quote a full section of RFC4475 into this document. However there were quite long discussions in the Apps Dir in other reviews if this quoting practice is appropriate or not, because it can lead to discrepacies, when the quoted document is updated or obsoleted, resuing in confusion for the readers who just trust the quoted text without checking the state of the referenced document. I would suggest, as in the other cases, NOT to quote the external text, but to use an explicit external reference only, urging the reader to check that "for the sake of clarity".
> 
> Nits:
> 
> * Section "Copyright Notice"
> 
> change the year to 2012.
> 
> * Section "3. Document Conventions"
> 
> remember to change "formatting rules for Internet-Drafts" into "formatting rules for RFCs" when published.
> 
> * Section "4. Format"
> 
> I do understand that it probably does not fit into the I-D formatting line lenghts, but... maybe an attempt to add aside the SIP CLF record depicted in Figure 1 the grouping described as
> 
>                                 <IndexPointers>
>                                 <MandatoryFields>
>                                 <OptionalFields>
> 
> in the figure 1 itself (on the left?) may help in reading the distinction, and maybe may even not require to repeat portions of the figure itself later in the I-D, like in figure 3, figure 4 and figure 5. It is really a nit and just a suggestion. Not really important.
> 
> What I am suggesting:
> 
>       +----------------------------------+
>      /|                                  |
>     / |                                  |
>   P   |                                  |
>   o   |                                  |
> I i   |                                  |
> n n   |                                  |
> d t   |                                  |
> e e   |                                  |
> x r   |                                  |
>   s   |                                  |
>    \  |                                  |
>      \|                                  |
>       +----------------------------------+
>      /|                                  |
>     / |                                  |
> M     |                                  |
> a F   |                                  |
> n i   |                                  |
> d e   |                                  |
> a l   |                                  |
> t d   |                                  |
> o s   |                                  |
> r     |                                  |
> y  \  |                                  |
>      \|                                  |
>       +----------------------------------+
>      /|                                  |
>     / |                                  |
> O     |                                  |
> p F   |                                  |
> t i   |                                  |
> i e   |                                  |
> o l   |                                  |
> n d   |                                  |
> a s   |                                  |
> l     |                                  |
>    \  |                                  |
>      \|                                  |
>       +----------------------------------+
> 
> * Section "5. Example SIP CLF Record"
> 
> Remember to change "Due to internet-draft conventions" into "Due to RFC conventions" when published (and also "to format it for an RFC" later on...).
> 
> * From the DataTracker ID Nits check tool (References Nits):
> 
>  == Unused Reference: 'RFC5612' is defined on line 984, but no explicit
>     reference was found in the text
> 
>  ** Downref: Normative reference to an Informational draft:
>     draft-ietf-sipclf-problem-statement (ref.
>     'I-D.ietf-sipclf-problem-statement')
> 
> Comment: the document shepard is aware and has a solution for these nits. Just apply it.
> 
> ------------------------------------------------------------------------------
> Claudio Allocchio             G   A   R   R          Claudio.Allocchio@garr.it
>                        Senior Technical Officer
> tel: +39 040 3758523      Italian Academic and       G=Claudio; S=Allocchio;
> fax: +39 040 3758565        Research Network         P=garr; A=garr; C=it;
> 
>           PGP Key: http://www.cert.garr.it/PGP/keys.php3#ca