[Sip] Review of draft-ietf-sip-subnot-etags-01

Avshalom Houri <AVSHALOM@il.ibm.com> Mon, 08 October 2007 15:02 UTC

Return-path: <sip-bounces@ietf.org>
Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1Ieu86-0006tj-Gz; Mon, 08 Oct 2007 11:02:46 -0400
Received: from sip by megatron.ietf.org with local (Exim 4.43) id 1Ieu84-0006t8-M3 for sip-confirm+ok@megatron.ietf.org; Mon, 08 Oct 2007 11:02:44 -0400
Received: from [10.90.34.44] (helo=chiedprmail1.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1Ieu84-0006sz-9s for sip@ietf.org; Mon, 08 Oct 2007 11:02:44 -0400
Received: from mtagate4.de.ibm.com ([195.212.29.153]) by chiedprmail1.ietf.org with esmtp (Exim 4.43) id 1Ieu83-0003AY-7H for sip@ietf.org; Mon, 08 Oct 2007 11:02:44 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l98F2eXc102036 for <sip@ietf.org>; Mon, 8 Oct 2007 15:02:40 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l98F2e4s1269794 for <sip@ietf.org>; Mon, 8 Oct 2007 17:02:40 +0200
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l98F2ePi012818 for <sip@ietf.org>; Mon, 8 Oct 2007 17:02:40 +0200
Received: from d12mc102.megacenter.de.ibm.com (d12mc102.megacenter.de.ibm.com [9.149.167.114]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l98F2dZQ012808; Mon, 8 Oct 2007 17:02:39 +0200
To: sip@ietf.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 8.0NP August 02, 2007
From: Avshalom Houri <AVSHALOM@il.ibm.com>
Message-ID: <OFA5371E22.45074A63-ONC225736E.004FBE12-C225736E.0052A5ED@il.ibm.com>
Date: Mon, 08 Oct 2007 17:02:38 +0200
X-MIMETrack: Serialize by Router on D12MC102/12/M/IBM(Release 7.0.2HF71 | November 3, 2006) at 08/10/2007 17:02:39, Serialize complete at 08/10/2007 17:02:39
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 16c9da4896bf5539ae3547c6c25f06a0
Cc: draft-ietf-sip-subnot-etags@tools.ietf.org
Subject: [Sip] Review of draft-ietf-sip-subnot-etags-01
X-BeenThere: sip@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Session Initiation Protocol <sip.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/sip>, <mailto:sip-request@ietf.org?subject=unsubscribe>
List-Post: <mailto:sip@ietf.org>
List-Help: <mailto:sip-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/sip>, <mailto:sip-request@ietf.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============0000209942=="
Errors-To: sip-bounces@ietf.org

Several comments:

-------------
A possible security issue with the following scenario:
a) Subscriber subscribes with Suppress-Body-If-Match header with
etag of e1.
b) The document has changed but what was changed is suppressed from
that subscriber due to privacy.
c) The subscriber will get notify with new tag but with the same
document.

If the subscriber wants to it can compare to the previous value and
understand that something is being suppressed from it.

-------------
Section 5.2 - second paragraph
"the first notification after the SUBSCRIBE" sounds as the first new
notification due to state change after the SUBSCRIBE. Maybe it is better
to write "the immediate notification following the SUBSCRIBE".
Note that there are other occurrences of the usage of "first" if you
decide to change.

-------------
Section 5.2 - Last paragraph before the examples
typo - "simply copies"  should be  "simply copied"

-------------
Section 5.2 - last example

Maybe there should be some explanation of why * is needed earlier
in the document. Liveliness use case is described below but maybe
better to explain earlier in the doc

-------------
Figure 4
          ... poll interval elapses

Should probably be  "... poll interval elapses immediately"
Since it is zero initially.

Section 5.6
Should not this be the first use case described? From bandwidth pov
it is the most important.

-------------
Section 6.1

"
...The notifier MUST remember the entity-tag of an entity as long
   as the version of the entity is current.  The notifier MAY remember
   the entity-tag longer than this, e.g., for implementing journaled
   state differentials (Section 6.4).
"

I understood from the text that the etag can be deleted by the notifier
when there is no current value to the entity. Consider the case when
a subscriber subscribed and got entity e1. Meanwhile the resource has 
become
stale (all previous publishes expired).
After e.g. two days the subscriber tries to subscribe with e1 for
the suppressing condition. What will the notifier selecting e1 as the
current entity tag again? If it does so the subscriber will not get
a notify (or body of notify) while it should have gotten one.
I hope that this is only my misunderstanding.

-------------
Comment from Ofira Tal (IBM)

Should we consider the change of the entity tag as a reason to
send a notify with the entity tag only even though there is no
need to send an actual notify to the subscriber since the change
affects filtered information due to privacy or just filtering.
This will enable avoiding redundant NOTIFY in subsequent
subscribes since the latest entity tag will be used.

--Avshalom




_______________________________________________
Sip mailing list  https://www1.ietf.org/mailman/listinfo/sip
This list is for NEW development of the core SIP Protocol
Use sip-implementors@cs.columbia.edu for questions on current sip
Use sipping@ietf.org for new developments on the application of sip