Re: [sipcore] Activity proposal on: New Version Notification for draft-jesske-update-p-visited-network-03.txt

worley@ariadne.com Sat, 01 April 2023 01:38 UTC

Return-Path: <worley@alum.mit.edu>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B8F9CC14CEE3 for <sipcore@ietfa.amsl.com>; Fri, 31 Mar 2023 18:38:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.682
X-Spam-Level:
X-Spam-Status: No, score=-1.682 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=comcastmailservice.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GffpDJ83eF_0 for <sipcore@ietfa.amsl.com>; Fri, 31 Mar 2023 18:38:48 -0700 (PDT)
Received: from resdmta-h1p-028482.sys.comcast.net (resdmta-h1p-028482.sys.comcast.net [96.102.200.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E236C14F73E for <sipcore@ietf.org>; Fri, 31 Mar 2023 18:38:48 -0700 (PDT)
Received: from resomta-h1p-027919.sys.comcast.net ([96.102.179.208]) by resdmta-h1p-028482.sys.comcast.net with ESMTP id iOEqpotVg9d84iQAgpV6Vs; Sat, 01 Apr 2023 01:36:46 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1680313006; bh=oH4HEmtNBr02hMgDz74G5lfyVhhaMK/723TY8c2zNCc=; h=Received:Received:Received:Received:From:To:Subject:Date: Message-ID:Xfinity-Spam-Result; b=wYKLR/yHe2jUoOBnhcjLw6mC3vJp1xP8fpZ9Yn0NXI4FOiOd8jZDg9VswrC5xL4Is y5LUcOss2pIY5xaWrcdu5fl36YMDsD+FhYR6JOJL0Bpv3Cu1DgDjfb19VE73chM2TH gEmL9I9XLTb77dIF7mxA+Xgxr34TgTGkHsvRqu/udtgfJ7321u78puMnlqA+aq9Kxh F2AyvnkJiyuRVJQ8dLSH0v1ineDTwh3kqZmPphryWi6LCdvBrdT8cLfEmqUV0pcrFS vdg9X1rbL9lpzcJfuajygIkKDuwiQB2TPYKZcJ4xa3APGI9DK5WDrBr9P9upDarvFn NETn04phBt4cg==
Received: from hobgoblin.ariadne.com ([IPv6:2601:192:4a00:430::94f3]) by resomta-h1p-027919.sys.comcast.net with ESMTPA id iQAdpVlY0s0OciQAepj6r8; Sat, 01 Apr 2023 01:36:46 +0000
X-Xfinity-VMeta: sc=0.00;st=legit
Received: from hobgoblin.ariadne.com (localhost [127.0.0.1]) by hobgoblin.ariadne.com (8.16.1/8.16.1) with ESMTPS id 3311agS63142252 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 31 Mar 2023 21:36:42 -0400
Received: (from worley@localhost) by hobgoblin.ariadne.com (8.16.1/8.16.1/Submit) id 3311agti3142249; Fri, 31 Mar 2023 21:36:42 -0400
X-Authentication-Warning: hobgoblin.ariadne.com: worley set sender to worley@alum.mit.edu using -f
From: worley@ariadne.com
To: Brian Rosen <br@brianrosen.net>
Cc: sipcore@ietf.org
In-Reply-To: <704D3725-AD5F-479B-B935-31397236E196@brianrosen.net>
Sender: worley@ariadne.com
Date: Fri, 31 Mar 2023 21:36:42 -0400
Message-ID: <871ql4crit.fsf@hobgoblin.ariadne.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/EIyORAFtjorHQshZiCVofnAw-Ac>
Subject: Re: [sipcore] Activity proposal on: New Version Notification for draft-jesske-update-p-visited-network-03.txt
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Apr 2023 01:38:52 -0000

The draft looks fine to me technically, though I have a couple of
minor exposition issues:

   Abstract

   ... needs to be included in SIP requests and responses.  This
   document updates RFC 7976, in order to allow inclusion of the P-
   Visited-Network-ID header field in responses.

This reads oddly, as the first sentence speaks of requests and
responses in parallel but the second sentence only considers requests.
That makes sense only due to the context "P-Visited-Network-ID is
already allowed in requests".  I think "... needs to be included in
SIP responses as well as requests" reads better.

   1.  Introduction

   The Third Generation Partnership Project (3GPP) has identified cases
   where different Session Initiation Protocol (SIP) [RFC3261] private
   header extensions referred to as "P-" header fields, and defined in
   [RFC7315], need to be included in SIP requests and responses which is
   currently not allowed according to [RFC7315].  This document updates
   [RFC7315], to allow the inclusion of the affected "P-" header fields
   in such requests and responses.  This document also makes updates for
   [RFC7976] to fix misalignments that occurred when [RFC7315] was
   updated for specific "P-" header fields which are mainly used in (and
   in most cases, only defined for) networks defined by the 3GPP.  The
   updates defined in this document will not cause backward-
   compatibility problems in 3GPP networks which are using
   [TS.3GPP.24.229].

This text seems to have *all* "P-" headers as its scope, whereas the
Abstract and section 3 (the core of the document) seem to be limited
to P-Visited-Network-ID headers.  In particular, this paragraph says
"This document updates [RFC7315], to allow the inclusion of the
affected "P-" header fields in such requests and responses." without
making clear whether P-Visited-Network-ID is simply one of the headers
which "need to be included ... which is currently not allowed"
(implying that further update documents will be generated), or whether
it has been determined that this is the *only* such header (implying
that no other update documents will be generated).

Dale