Re: [sipcore] Alexey Melnikov's No Objection on draft-ietf-sipcore-digest-scheme-12: (with COMMENT)
Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> Wed, 30 October 2019 21:50 UTC
Return-Path: <rifaat.ietf@gmail.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F15D2120103; Wed, 30 Oct 2019 14:50:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rCyLDeFJxpNM; Wed, 30 Oct 2019 14:50:42 -0700 (PDT)
Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F1DD1200D6; Wed, 30 Oct 2019 14:50:42 -0700 (PDT)
Received: by mail-il1-x144.google.com with SMTP id s75so3545194ilc.3; Wed, 30 Oct 2019 14:50:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PyV9ID+3EfKd73f0aPMSVJI5LyLNUzvGvE48B/Nwb/I=; b=Myo/JGB6VTQexPmZ8HjC77hfWGanIjcuVqOJDKK41m9sNPMUyxlrhCdTUp8qX9C7Ev 5TqbXSvdu4wqNx5xtJeD3ev8LvTUfNFP6AHilxGY7TXd3qZvONFaXbCcDcQMpfMzp8je qWMu+LdCFSBBw3Y/Qsmcd31Xx8I0trBbp+qaFF1DQJnZMgdH13dYt3HnQ/IXzg4KyeQE +QujX/32oq7smVUk3Tu0d30T1Qtm3eOTuehbYDesFGUxcrKbWO8mBEzoX/AOBqm9njDe +3f5XN/ficDip6AAn5y9LRtZohb/D04C5xLVQdhI1vHR0/HWK27H5QtvbGmjfuc+ssiB xbMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PyV9ID+3EfKd73f0aPMSVJI5LyLNUzvGvE48B/Nwb/I=; b=JpGFrLzznQvkJj7zbysbmRni/KmWiXXOVp7mxOGPzeWRo+YE2GM5UCGyAj09IWiS0A QD1d5ohGSXY9D8iRaJWFmgD+5xDA6+imKpUtCzoDvbXbSCLl/PyAmyYkDh7YZtUFjrTU pgVxXXeJGYgMkaGXs0GNldB+M18vnGR/ZYkOJerrqGpVeF7fxta9dA6j9elHh3WpHm+u 5pr4ZaMz1FtLhvGOys89dVnDYcPPy1m3yYilvUvBUimlXDeKfXUGkzEKN1j1yo5bAGAs RmFFQsL28MKMBPwyU+wJMo2neU600R5/QDTBqvt8zmX0n5aFRYu6+i+WWA187lsssz2b jiGA==
X-Gm-Message-State: APjAAAV3OjSN/XypS+4hIHB+MBOCUz6hp95nq9hcIX+Ob/C5/a/3lC+Q Tsa8tmbGa5iDUamCXC9xR9/AUZwUecpwGEgFsyU=
X-Google-Smtp-Source: APXvYqw/cNasDN4KeNNrHpBiF1vUAdXchT+vgGKBShiFyMwfoFMf06XGvLQhoL9vKGlLX/JwFhUH8+o2c4sQGTLIAJg=
X-Received: by 2002:a92:8394:: with SMTP id p20mr2446798ilk.73.1572472242020; Wed, 30 Oct 2019 14:50:42 -0700 (PDT)
MIME-Version: 1.0
References: <157245577700.32490.10990766778571550817.idtracker@ietfa.amsl.com>
In-Reply-To: <157245577700.32490.10990766778571550817.idtracker@ietfa.amsl.com>
From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Wed, 30 Oct 2019 17:50:32 -0400
Message-ID: <CAGL6epJgyr_VUYgKCgxDcP5ObKWErtDCHxaX7JusUYPXu=a6jQ@mail.gmail.com>
To: Alexey Melnikov <aamelnikov@fastmail.fm>
Cc: The IESG <iesg@ietf.org>, draft-ietf-sipcore-digest-scheme@ietf.org, Jean Mahoney <mahoney@nostrum.com>, sipcore-chairs@ietf.org, SIPCORE <sipcore@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000067a876059627b937"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/xien1xmexxvm2bjdwciaenWf9nw>
Subject: Re: [sipcore] Alexey Melnikov's No Objection on draft-ietf-sipcore-digest-scheme-12: (with COMMENT)
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2019 21:50:45 -0000
Thanks Alexey! I am fine with the first two comments, and will fix these in the coming version of the document. I am not sure I follow the 3rd one. Why do you see the need for a minimum number of hex digits? Regards, Rifaat On Wed, Oct 30, 2019 at 1:16 PM Alexey Melnikov via Datatracker < noreply@ietf.org> wrote: > Alexey Melnikov has entered the following ballot position for > draft-ietf-sipcore-digest-scheme-12: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-sipcore-digest-scheme/ > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > I am agreeing with Alissa's DISCUSS. > > Also, I have a few comments of my own: > > 1) Last para of Section 2.1: > > 2.1. Hash Algorithms > > A UAS prioritizes which algorithm to use based on the ordering of the > challenge header fields in the response it is preparing. > > This looks either wrong or confusing to me. I think you are just saying > here > that the order is decided by the server at this point. > > That > process is specified in section 2.3 and parallels the process used in > HTTP specified by [RFC7616]. > > So based on the above, my suggested replacement for both sentences: > > A UAS prioritizes which algorithm to use based on its policy, > which is specified in section 2.3 and parallels the process used in > HTTP specified by [RFC7616]. > > 2) Last para of Section 2.4: > > If the UAC cannot respond to any of the challenges in the response, > then it SHOULD abandon attempts to send the request unless a local > policy dictates otherwise. > > Is trying other non Digest algorithms covered by "SHOULD abandon"? > If yes, maybe you should make this clearer. > > For example, if the UAC does not have > credentials or has stale credentials for any of the realms, the UAC > will abandon the request. > > 3) In Section 2.7: > > request-digest = LDQUOT *LHEX RDQUOT > > This now allows empty value. I suggest you specify a minimum number of hex > digits allowed in the ABNF. Or at least change "*LHEX" to "2*LHEX". > > >
- [sipcore] Alexey Melnikov's No Objection on draft… Alexey Melnikov via Datatracker
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Paul Kyzivat
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Paul Kyzivat
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg