IETF Logo Mail Archive

Re: [Softwires] I-D Action: draft-ietf-softwire-yang-02.txt

Andy Wingo <wingo@igalia.com> Wed, 08 November 2017 09:48 UTC

Return-Path: <wingo@igalia.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 81C4612EB94 for <softwires@ietfa.amsl.com>; Wed, 8 Nov 2017 01:48:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.121
X-Spam-Level:
X-Spam-Status: No, score=-1.121 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_NEUTRAL=0.779] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=pobox.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id feCRKFd4lqVk for <softwires@ietfa.amsl.com>; Wed, 8 Nov 2017 01:48:07 -0800 (PST)
Received: from sasl.smtp.pobox.com (pb-sasl1.pobox.com [64.147.108.66]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA125129C62 for <softwires@ietf.org>; Wed, 8 Nov 2017 01:48:06 -0800 (PST)
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 764189A9B1 for <softwires@ietf.org>; Wed, 8 Nov 2017 04:48:02 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=UE8HA4R/hjVoRC3iXBMeOFeUAL4=; b=lQR7cY 71xs2gDeQUifqlQCeEe/VHMPUEo5YrwrwzrwlwlhmOFxfD/kbmtqO1kggY8y4UBU 6Ym6tZCTMT9t7UYw0CNnPiM4dHTgx3vx063QMUu9AMzXYIwtyAtauPef+3Cbuaev chhso/5UeKlJ7nUIeH/qWnFgTR6C9c5YriGIs=
Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 6BC9C9A9B0 for <softwires@ietf.org>; Wed, 8 Nov 2017 04:48:02 -0500 (EST)
Received: from sparrow (unknown [151.127.12.20]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 8941D9A9AD for <softwires@ietf.org>; Wed, 8 Nov 2017 04:48:00 -0500 (EST)
From: Andy Wingo <wingo@igalia.com>
To: softwires@ietf.org
References: <150937633651.3401.8976291853315482170@ietfa.amsl.com>
Date: Wed, 08 Nov 2017 10:47:52 +0100
In-Reply-To: <150937633651.3401.8976291853315482170@ietfa.amsl.com> (internet-drafts@ietf.org's message of "Mon, 30 Oct 2017 08:12:16 -0700")
Message-ID: <87shdpyud3.fsf@igalia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: E86A7700-C469-11E7-A1EF-ABEFD5707B88-02397024!pb-sasl1.pobox.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/ADGRsWuAUzyTYY4-Mg3nkQxBxdI>
Subject: Re: [Softwires] I-D Action: draft-ietf-softwire-yang-02.txt
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Nov 2017 09:48:08 -0000

Hi,

On Mon 30 Oct 2017 16:12, internet-drafts@ietf.org writes:

>         Title           : A YANG Data Model for IPv4-in-IPv6 Address plus Port Softwires
>         Authors         : Qi Sun
>                           Hao Wang
>                           Yong Cui
>                           Ian Farrer
>                           Sladjana Zechlin
>                           Mohamed Boucadair
>                           Rajiv Asati
> 	Filename        : draft-ietf-softwire-yang-02.txt
> 	Pages           : 41
> 	Date            : 2017-10-30

I had a look at this for the Snabb lwAFTR and found a few issues.

 1. "hairpin-ipv4-packets" and "hairpin-ipv4-bytes" need to be state
    data, not config data.  Consider moving them inside the
    "traffic-stat" container.

 2. "dropped-ipv4-bytes", described as counting bytes from dropped IPv4
    fragments, should probably be named "dropped-ipv4-fragment-bytes" or
    something.  Note there is already "dropped-ipv4-byte" (sic) for
    dropped IPv4 bytes as a whole.

 3. "dropped-ipv4-bytes" (from (2)), "dropped-ipv4-fragments",
    "hairpin-ipv4-packets" (from (1)), and "hairpin-ipv4-bytes" (from
    (1)) are plural whereas the rest of the counters are singular.  One
    or the other should probably be chosen.

 4. The type of "icmpv6-errors-rate" is "uint16".  This is probably too
    restrictive.

Regards,

Andy

v2.23.0 | Report a Bug | By Email