IETF Logo Mail Archive

Re: [lamps] Genart last call review of draft-ietf-lamps-samples-05

Daniel Kahn Gillmor <dkg@fifthhorseman.net> Tue, 07 December 2021 13:16 UTC

Return-Path: <dkg@fifthhorseman.net>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E19483A160A; Tue, 7 Dec 2021 05:16:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.194
X-Spam-Level:
X-Spam-Status: No, score=0.194 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SORBS_WEB=1.5, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=fifthhorseman.net header.b=9P2ldM59; dkim=pass (2048-bit key) header.d=fifthhorseman.net header.b=Vx4OlIb5
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 562KBJ-knz5e; Tue, 7 Dec 2021 05:16:41 -0800 (PST)
Received: from che.mayfirst.org (unknown [162.247.75.117]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8ABA43A160D; Tue, 7 Dec 2021 05:16:37 -0800 (PST)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1638882995; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=ERBYzWtBQXnuNrRt4S08xp2hlcA1OoavaReMdeSOujw=; b=9P2ldM59u6ZvzEyb/1QfZvd1Bsk/RjNvoyB9FjDGl3qqy5mUK7rk+pUBCzibc9zs5vnmF puTuKSQYkKXlkW+BQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1638882995; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=ERBYzWtBQXnuNrRt4S08xp2hlcA1OoavaReMdeSOujw=; b=Vx4OlIb5PuSlns6/tnBKLs8mJ38vgZiiQukxfav77zuJ42KMSb7qJkrlyQqX42g63VAnJ smuP69FH0s+AAqGTzTlaDJDj1ppDKAGcHKLPp63LdYIOoqpF5loGzcidTtBAqwdeX4teFAp ku+yPV7QlYRzBv33QYJowzd84c7bpfPswhx6QFXvhXqJ/+nUXw3Et4w0L02mH4kxZgM+3Lx pv14TnxuYK4hlWnrYdcyAMp9GBISPhWQCAN/mAEcTq5/CfT3oh4KavErUdJ7kjZcMiPi2Ei jDxr6AWNOKB2FHBvdSdjkQ9KJg7cE9OwLAhq3J7XcL8EOcFg887kqtZLocxg==
Received: from fifthhorseman.net (unknown [94.187.8.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id F3B22F9A5; Tue, 7 Dec 2021 08:16:34 -0500 (EST)
Received: by fifthhorseman.net (Postfix, from userid 1000) id 5A9672043A; Tue, 7 Dec 2021 15:11:57 +0200 (EET)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Stewart Bryant <stewart.bryant@gmail.com>, gen-art@ietf.org
Cc: draft-ietf-lamps-samples.all@ietf.org, last-call@ietf.org, spasm@ietf.org
In-Reply-To: <163707453393.17796.13018883385449077212@ietfa.amsl.com>
References: <163707453393.17796.13018883385449077212@ietfa.amsl.com>
Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH
Date: Tue, 07 Dec 2021 15:11:56 +0200
Message-ID: <87pmq87e5f.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/YxJfBo0IYh4bzlxakhAGrMTIaJc>
Subject: Re: [lamps] Genart last call review of draft-ietf-lamps-samples-05
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Dec 2021 13:16:46 -0000

Hi Stewart--

Thanks for this review.

On Tue 2021-11-16 06:55:33 -0800, Stewart Bryant via Datatracker wrote:
> Document: draft-ietf-lamps-samples-05
> Reviewer: Stewart Bryant
> Review Date: 2021-11-16
> IETF LC End Date: 2021-11-26
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: A well written document ready for publication
>
> Major issues:None
>
> Minor issues:None
>
> Nits/editorial comments:
> The following terms were used without prior definition in the text: PEM, OCSP,
> CRL - they are well known in the security community, but not in the RFC Editor
> list of well known terms not needing expansion on first use.

I appreciate your catching these unexpanded acronyms.  I am happy to add
expansions for them, or maybe just outbound references if that seems
appropriate.

"OCSP" and "CRL" appear in the draft in reference to certificate
indicators, meaning specific X.509 extensions; for OCSP i would refer to
id-ad-ocsp in the Authority Information Access X.509 extension
(i.e., §4.2.2.1 of RFC 5280), and for CRL i would refer to the CRL
Distribution Points X.509 extension (i.e., §4.2.1.13 of RFC 5280).

For "PEM encoding" I would add an informative reference to RFC 7468,
where §5 describes certificates and §10 describes private keys.

Would that be a useful set of changes to the document?

Regards,

      --dkg

v2.23.0 | Report a Bug | By Email