[lamps] Gorry Fairhurst's No Objection on draft-ietf-lamps-rfc7030-csrattrs-20: (with COMMENT)

Gorry Fairhurst via Datatracker <noreply@ietf.org> Mon, 21 April 2025 19:52 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: spasm@ietf.org
Delivered-To: spasm@mail2.ietf.org
Received: from [10.244.8.129] (unknown [104.131.183.230]) by mail2.ietf.org (Postfix) with ESMTP id 8B6311EF794D; Mon, 21 Apr 2025 12:52:59 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Gorry Fairhurst via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
X-Test-IDTracker: no
X-IETF-IDTracker: 12.38.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <174526517943.2003440.12017599083444701168@dt-datatracker-64c5c9b5f9-hz6qg>
Date: Mon, 21 Apr 2025 12:52:59 -0700
Message-ID-Hash: CGNPCP7JRGJYPG3DYGYFRGZVYZHDGXSY
X-Message-ID-Hash: CGNPCP7JRGJYPG3DYGYFRGZVYZHDGXSY
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-spasm.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-lamps-rfc7030-csrattrs@ietf.org, lamps-chairs@ietf.org, spasm@ietf.org, housley@vigilsec.com
X-Mailman-Version: 3.3.9rc6
Reply-To: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Subject: [lamps] Gorry Fairhurst's No Objection on draft-ietf-lamps-rfc7030-csrattrs-20: (with COMMENT)
List-Id: This is the mail list for the LAMPS Working Group <spasm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/iS63t9RKvDyH9I9cWfV1wkubZM4>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Owner: <mailto:spasm-owner@ietf.org>
List-Post: <mailto:spasm@ietf.org>
List-Subscribe: <mailto:spasm-join@ietf.org>
List-Unsubscribe: <mailto:spasm-leave@ietf.org>

Gorry Fairhurst has entered the following ballot position for
draft-ietf-lamps-rfc7030-csrattrs-20: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-lamps-rfc7030-csrattrs/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

This document does not appear to raise transport-related concerns.

I do though have a number of comments - intended to help readability of the
next revision.

The abstract says: “RFC7030 (EST) and clarifies how the CSR Attributes Response
can be used by an EST server to specify both CSR attribute OIDs” - EST, CSR and
OID : please define or expand all acronyms on their first usage for easier
reading of the abstract.

“As a result of some of the implementation challenges, it came to light that
the particular way of that RFC7030 (EST) says to use the CSR attributes was not
universally agreed upon.” - I liked the context, buit this is a little hard to
read, could it please be written simpler?

===

Introduction:

I suggest RFC7030 is referenced when first mentioned, and EST expanded at the
start.

The following text was not clear to me: “it was suggested that it went contrary
to section 2.6”. - I assumed this was a reference to another RFC? The language
could be improved and please cite RFC 7030, if this is being referenced? or
whatever reference if something else?

====

Section 3.2 refers to something that I was unsure about, is this the text that
appears in RFC70303 as: “The syntax for application/csrattrs body is as
follows:” part of the RFC, it would help to clarify in the text what was being
changed.

NiT: There is a missing period after:
“ Many examples for this are given in {#examples}“
- what is #examples?

RDN is used before being defined.
CMRF is not defined.

“If the 'extnValue' is present (which is always the case when type Extension is
used), the client is required to use the given extension value.“ - This seems
like a requirement: Could this be an RFC2119 “MUST” requirement?
====

What does this require: “Otherwise it is  expected to fill in the extension
value.", could this be written in RFC2119 language?

What does this require: “If the 'subjectAltName' extension contains the
'directoryName' choice containing the NULL-DN (i.e., an empty sequence of RDNs)
or the'iPAddress' choice with an empty OCTET STRING, this means that the client
is expected to fill in the respective GeneralName value.”, could this be
written using RFC2119 language?