Re: [lamps] draft-ietf-lamps-cms-shakes-07

"Panos Kampanakis (pkampana)" <pkampana@cisco.com> Fri, 01 March 2019 04:20 UTC

Return-Path: <pkampana@cisco.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1F14130F3E for <spasm@ietfa.amsl.com>; Thu, 28 Feb 2019 20:20:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id en_z5nU_J4ri for <spasm@ietfa.amsl.com>; Thu, 28 Feb 2019 20:20:21 -0800 (PST)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAFD8128B14 for <spasm@ietf.org>; Thu, 28 Feb 2019 20:20:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1774; q=dns/txt; s=iport; t=1551414020; x=1552623620; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=IrfM5VOmEQgUUn+mjA+WXbMHt+LyofmbJKNQcjc1JCI=; b=hwaFG11kcWTSKP1j1ibdSv4gYIwN828J9oIKBiz9c+BlznZnV4YhKKNj LKGtLZbhmRnJigjqZowU4f1sIwlPGPi/7+IWrFPZDmAHjU5KRwuI4NG4S VJFNWKqwXd5wC5G4fwDp/glgexV09NSiTbuoVf4YDpLVbx3LrpCICbfrf 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ADAACasnhc/5RdJa1lGQEBAQEBAQEBAQEBAQcBAQEBAQGBUQQBAQEBAQsBggRogQMnCowYi0+CDZgggXsLAQEYDYRHAoQUIjQJDQEDAQEDAQMCbRwMhUoBAQEBAwEBODQXBAIBCBEEAQEfECcLHQgCBAESCIMZgXIPrReELwGGAQWMSBeBQD+BEYMSgx4BAYdCAqNsCQKHQIsgIZMfil6FV4xBAhEUgSgfOIFWcBU7gmyCJQMXg0uFFIU/QTEKjnuBHwEB
X-IronPort-AV: E=Sophos;i="5.58,425,1544486400"; d="scan'208";a="526695896"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2019 04:19:51 +0000
Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id x214Jpxa031047 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 1 Mar 2019 04:19:51 GMT
Received: from xch-aln-010.cisco.com (173.36.7.20) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Feb 2019 22:19:50 -0600
Received: from xch-aln-010.cisco.com ([173.36.7.20]) by XCH-ALN-010.cisco.com ([173.36.7.20]) with mapi id 15.00.1395.000; Thu, 28 Feb 2019 22:19:50 -0600
From: "Panos Kampanakis (pkampana)" <pkampana@cisco.com>
To: Russ Housley <housley@vigilsec.com>, SPASM <spasm@ietf.org>
Thread-Topic: [lamps] draft-ietf-lamps-cms-shakes-07
Thread-Index: AQHUz7Jy9dijgKCATEmHOHKqPf0BDaX2Kk9A
Date: Fri, 01 Mar 2019 04:19:50 +0000
Message-ID: <ef3ed3a81bff44aa9955d2b7e5774e9f@XCH-ALN-010.cisco.com>
References: <8A2F741C-3E8A-4D7A-B70C-F570932DD96C@vigilsec.com>
In-Reply-To: <8A2F741C-3E8A-4D7A-B70C-F570932DD96C@vigilsec.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.253.241]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.36.7.18, xch-aln-008.cisco.com
X-Outbound-Node: rcdn-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/ni1nt1Bk5UzwKxfnGg4XTJEIrJE>
Subject: Re: [lamps] draft-ietf-lamps-cms-shakes-07
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 04:20:24 -0000

Hi Russ,

Good catch. Coincidentally we just caught this yesterday. id-shake128-len and id-shake256-len were replaced with id-sha128 with 32 bytes output length and id-shake256 with 64 bytes output length. We didn't need the -len OIDs that include parameters any more. It was left in there from previous versions. 

We also fixed a discrepancy between section 3 and 4.4 about the KMAC OIDs that have parameters as optional. 

These two changes are reflected here https://github.com/csosto-pk/adding-shake-to-pkix/commit/d34de0a3903429101bb8e93f4456551c4fb8fc96 

We will push the next iteration by the end of next week. 

Panos

-----Original Message-----
From: Spasm <spasm-bounces@ietf.org> On Behalf Of Russ Housley
Sent: Thursday, February 28, 2019 5:10 PM
To: SPASM <spasm@ietf.org>
Subject: [lamps] draft-ietf-lamps-cms-shakes-07

I was just looking at this document, and an inconsistency jumped out at me.

Section 4.1 says that id-shake128-len and id-shake256-len have no parameters.

However, as used in RFC 8419 has a parameter:

      hashAlg-SHAKE256-LEN  ALGORITHM  ::=  { OID id-shake256-len
                              PARMS ShakeOutputLen }

      id-shake256-len  OBJECT IDENTIFIER  ::=  { hashAlgs 18 }

      ShakeOutputLen  ::=  INTEGER  -- Output length in bits

On the other hand, id-shake256 has no parameters:

      hashAlg-SHAKE256  ALGORITHM  ::=  { OID id-shake256 }

      id-shake256  OBJECT IDENTIFIER  ::=  { hashAlgs 12 }

I think this needs to get sorted out before draft-ietf-lamps-cms-shakes goes to IETF Last Call.

Russ

_______________________________________________
Spasm mailing list
Spasm@ietf.org
https://www.ietf.org/mailman/listinfo/spasm