[lamps] Re: Partial review of draft-ietf-lamps-pq-composite-sigs-04 and draft-ietf-lamps-pq-composite-kem-06
John Gray <John.Gray@entrust.com> Thu, 24 April 2025 20:53 UTC
Return-Path: <John.Gray@entrust.com>
X-Original-To: spasm@mail2.ietf.org
Delivered-To: spasm@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id EF6AE20DF471 for <spasm@mail2.ietf.org>; Thu, 24 Apr 2025 13:53:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -2.794
X-Spam-Level:
X-Spam-Status: No, score=-2.794 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_FONT_LOW_CONTRAST=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=entrust.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PJNa1tIo-fDc for <spasm@mail2.ietf.org>; Thu, 24 Apr 2025 13:53:23 -0700 (PDT)
Received: from mx07-0015a003.pphosted.com (mx07-0015a003.pphosted.com [185.132.183.227]) by mail2.ietf.org (Postfix) with ESMTP id B007B20DF46A for <spasm@ietf.org>; Thu, 24 Apr 2025 13:53:22 -0700 (PDT)
Received: from pps.filterd (m0242864.ppops.net [127.0.0.1]) by mx08-0015a003.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53OGB6Mq021324; Thu, 24 Apr 2025 15:53:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=entrust.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=mail1; bh=3OTXmr3oZircrG9wMSVziXP9vNwT nimOgdkwX2GMfrU=; b=X+rYkV5eT0eQ6Sl49PLZQEpLdawMteDV7xzZAUK5T/5U 1/R+uU8TRqISNQdV04vVsjMSaU/RYrYcAZKr1D9dde1vhn5z0qp6WWfYjR5vCh/e LWj5JdZa1a12lxPdjgsq779wmVXQOfB0bv/07T3lyshSb+dpbQT6VMOujU9ZIdW/ 1+NQg0maz2Ttf6xF8AEnTNhgSHnIaBBRT2WGkf+3RtOaF9SllrwsWAXfDOwy7FP/ hh/jxEW6t4Kic8QtHgn2kw8tkJxV7v0IaFcqgUVGsAd/Ymhcnee45j/s5bIWp0Qu YAGTtJZy4tSlOSmaAIcIR5NVoPPdRoYjIQTEI2XRuA==
Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by mx08-0015a003.pphosted.com (PPS) with ESMTPS id 467k592u7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Apr 2025 15:53:20 -0500 (CDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oTpvoGTQ/dyRZciKhbjDgIQ1TaDZEveo2OW6+sESAhDwE3nctJaoEEBf5GoaDB3w79SteMNRJ9dDdtbwNGJqIqr+x9FvUebR6xTWrVC66OotFCJUI9x9Re+ao4MWNZwHO4FmvnraJWq5IZ9dPZB1wRgc0qxdlg7bQioQLCrTXWzREgxpWjolnAF7CSgRlH6byfCYCNmoDguBzlFTDoRUtyHovBo75SCF2lddZSdvDyFqCxnNSFLURRmAGfKwAtjYCNbzJDLdFPR8QHYa/jRfwTQ/XBr9wgbMb7W5htri3XW+JnRiF6MtieEG+KEQmilmcSPkOSh/aH7kGrsrxzh0vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQFmH0NxGMpwxFH+fIvbTjPzGEOPX4b1LLRXl1QY9Ws=; b=XMneLo/RST0OHYMo+5LTPho5zaUP4YfsZC5q9Z2Bz3Kh7IZF+k75BToMUJi0PnJvtV/0iRnBvb4z/MHO/RatmbBqVJ2jER7g0w4vurqEa+3vHS0BZhg//AdeRFJkHdcMW8AGMboWhDW5ngzWEE2E58YE3WDNXkrdBUGKbljjLJoqKg3DTb8sJb2QZp851fq2z8rOX04gBQuauSNUHikLlZeW2RVuOTzRADijeMaxsUeEgp3LKU4Jw4bKA6ADMJvK9/Er36CAbOx+wbDQ1iVKOLV4VEVdnu2MBD9klptArWyJ0e43yfZLGMIjFQTuE706Fn5Ay4+PbKRmh07jgR5dng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=entrust.com; dmarc=pass action=none header.from=entrust.com; dkim=pass header.d=entrust.com; arc=none
Received: from CYYPR11MB8388.namprd11.prod.outlook.com (2603:10b6:930:c2::6) by CO1PR11MB5169.namprd11.prod.outlook.com (2603:10b6:303:95::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.26; Thu, 24 Apr 2025 20:53:15 +0000
Received: from CYYPR11MB8388.namprd11.prod.outlook.com ([fe80::ae04:cc86:8919:d453]) by CYYPR11MB8388.namprd11.prod.outlook.com ([fe80::ae04:cc86:8919:d453%5]) with mapi id 15.20.8655.033; Thu, 24 Apr 2025 20:53:15 +0000
From: John Gray <John.Gray@entrust.com>
To: Carl Wallace <carl@redhoundsoftware.com>, LAMPS <spasm@ietf.org>
Thread-Topic: Partial review of draft-ietf-lamps-pq-composite-sigs-04 and draft-ietf-lamps-pq-composite-kem-06
Thread-Index: AQHbssI63rfLyX2qwE+vEpvRQygX1rOzTtR2
Date: Thu, 24 Apr 2025 20:53:14 +0000
Message-ID: <CYYPR11MB8388857AD11F08F976DCC55DEA852@CYYPR11MB8388.namprd11.prod.outlook.com>
References: <25784C6F-780C-457F-81CD-4B95850D464F@redhoundsoftware.com>
In-Reply-To: <25784C6F-780C-457F-81CD-4B95850D464F@redhoundsoftware.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CYYPR11MB8388:EE_|CO1PR11MB5169:EE_
x-ms-office365-filtering-correlation-id: c1ed0e65-90e0-4bb9-5267-08dd83720892
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|4022899009|366016|1800799024|376014|38070700018|13003099007|8096899003|7053199007;
x-microsoft-antispam-message-info: AGO0b+3mIuvaxcWTctkp3NdBnnhe0/WAB+ji3DNr7TmwwlyVbUUM0i3BmUK3S3/S+/jTSDTZw41UaV3TRBBhqsEQKSJTuxROcYRJmusId29Kvnptci2RgiIO4eup8xBn1vGW9OW0eTxkTazHcKZK921t0GnHq6qRBJVSqwkTRNM+0gBc0MlpvOahf12dPUwlCyq+vfDnUeeC11vKcoIDTbhKZbMI4y+LqB6EdS5nVeOB8JlKT9i0E1aS9ZRXROmaQSwLXZHsSZ4DI9Y27xlhUMoHhjdbCWS6aUrnYicquKStguECSh/oGENv25gAa1CgB5C2q7zRaNzadjsfwVCUlkd4jKYvIMNQbJP3i8XXFxMFe5yMVeP4sI59Uqp6rvaHA2Or1fVQoM005hn78RfL1qjwsmdRFAPxz96MXn2sM4PNcIlVne/AOTjzMnv7jyc4uBW24Iy+9zQ8ogwq64tU1LVpr8brnCbQdZp+5Zle5emcWNWi4EtOdiaMNMbwAl7dKKOn1haA98duNYbw4Fsn7UILx0AETzUdwYOzXwORVb3hPPtbL75jIP22xESsC4j6jeNi5CibjDC71iEJ3WfJE9sP3AxWyG3X1BDL74W2BtKCedTA7WBv9tSeUI1yv3rG86MpKfet+53zM1KtzuaoTDCP8FGri5k2VWglXKksn0S6dihYp8F+4TgfTMA4tt+1yTu0sbBNbEgtlpQTpW62UvYApBhfGKgjiscecE4a7IZl9b5q39GE6ZyBZSFE4P3eI0UfDg5HbCSmZqHvAV/stx3+ktT7V31he0+bpcTLfG6hJCvgFHTM0E5cMfS6bRHzKGgAMDb45Uu+aXddAUp675tuFvRLG9kObfrlk/BKCq+fu5FzSdu0V/h9TzAdLXi88O4YVSTWK49rdBvzHQhtwUzRKCksdga4kqMmt1rsi1evwHtG2ysm4vYNKoiSbmZkZ6k8VveR0ai9LWF3Q7Ji7K1KWU2VQkXiTRPBfl9RP6NAs3Jh+USsU2vudDJ50u5t/cjeTt9ZCl7Xn845uTplIOBkUdfDidignV6P9BG5flqzrh0UJJPZMW8NuJIr4Py9NWm4hTgA3XKnI54cp46JZQkEwRb3HorDnc/8zPzAvb3kmklfMb/RRckN8NUih+J5jypptIOlJHYJVdmBMZ3mVBQ11VyeCSew+gyNze60zpBbGBYtBZZZMRQ3a0ZkoWazNPPpgNIwT6iDXUXCG/7VkCLqRQtIclBtK+a/zMVVzJztSxWkdNonUy5LTXRim9hbdhkh2IWsxxsoreOS3+BLOARyK4dSIL1adRKMrEbF6bbDGmWt5FtdQAByb08nkCgyt0ZdzxqEgFYTAAssJpSaCBpLlDIvKtNgZtTkhPrReMDlZ404fKEWJvicqRnuQegxrWqdSWyNmP3Hlg9XXdWTMXvgqq/eOOxtS40hGVDchyE=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR11MB8388.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(4022899009)(366016)(1800799024)(376014)(38070700018)(13003099007)(8096899003)(7053199007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: tA+9u352Ki7nXvJEVt7D0KsNXLCpIo0IJmRB1lgzozAVTvYO6c9uzzV7SQq05PxH/Bx65dzC/1Fq5Zx7jLN6J8C7Flhqs+U6hkJgeJmPo2lIljG1nKLV0+L7RYYvEjhqGg/t7cvCshroGK2CC/p/mBaTE0JET5bdDjj2tF7qTQxLDaE5SCHS8BDGLb2E+4xuw1CjqS5Qb+9zonbselU4Gsytiv/cWh+zd9jrBUsUJfD9WtYc9/UrcUF9LYrxGarwTyt2/iCtnoU3U06tOEahsNORkxFReafePAYOvsevTSpMhuA6jkSBEzUHHl7MYksrC4MYZyK60qpNx+OFq7y50R8Wj/2K1q46W+0/OXWHfDwxTJqyfNnVm5ax+0NNkzOo+P5ZEfxwkhKJfHmBSJ59qoClwA34zo7FcFJPU8EjDT78J9ajcotaksHAupgZEIr3v7WttOHYz07HA7vG1RA/ewH+vR6Wi3oroQJFnXqCVhIlKrzb4LLodZVv2dAwfFnXzGZuM2lGYSVwNONrq6O1pD4P0Ir09DQk9RGR1ZbIRuvsr0wKh5HiXnPbuxMnOapOICCD561Ua/YBqVyns3GLsbXviTLfkK8x8+UtBGesJSK1Y9fCD1ZjAoAmyAqD6gaos/A6L8VZDsz04o0ne8jcvdC4cCU0GLrD3BNh8PsUNa97PZ+RdJIRU+uf53bGDGRyB1YTtKG4TwJpOY81O9l9e6pAj6/OqHEGe7AbsM63OTOnWA75OmakBAwmks9p+YojeG0o4rdlVphFEhm40HhY7UX70psEum20p9Oagv1XF12v5y0GPYynMZXZWBoSfC9xSKBB+3PaMxAmzf9p9Cu4+IBTnkqzk5WPOKZgTtqk6MHBxI/ywrZ8NQLCYJjtzc8AfddfEWd8JgjJqMseaLgg6igXTOV+WyoHjmM4ItbOXJ3uLYFuxP7vrbw3ziFF7bXgQFLIz0dKguzcyuhW12SiA7pD7HQfYdZJ7GRbmUNBui3U3loNKEIuFCSbBuPhvVtUFyoPAdGIHhhYI3m+5b149t+3hV6tVMTT9M7Q9s93++oZIjyd7BwXhJru0tNN1dL/rA7PrvvVWdnDV8stANmy4hp7/ZSJ43x5FD97m2GrHkpVnhknvWVopIUova+CB7NGU4gNhFReLgnYF9NnlbWUQoRdxO+Rqg/VvATnG0q9T3zJmqlDGQQxtjXTOQkvHsCRypcleAAlQJokphRb3ZkmIN2e9w/fUpnYvxUQ6Kk9BaaLW9/08u1CFKqKLTS/lU+ktZ8YrrePNqjqo4Zt7c4ZZZhfeqQpUaJCfHaI4D4kzbFP21rNmlP8FtHvee8i+UvYkv9vhhklhap1s7EZWE4/wpRAiANSh9PO64QsIH5rPxOqUS2NuFp/fz/uZoGIfF9u7xcxw4ZyVAKeLjESgCKei9sENJNoYjmlIaxYeW2/IqSvieY/rbT3b013Egn4gLDJ5bRGkHxqfNnOHHJQSnZImfyT7HY1v3mu+RH5cR/RAce7NsP6yEEFWjYKh0oO+k/Ygpk6shXk8SwK5gVNdqoyN4L/fG+/aiDtg6zvnOlxqjqHFWeWUmixnyj32AOyay0+
Content-Type: multipart/alternative; boundary="_000_CYYPR11MB8388857AD11F08F976DCC55DEA852CYYPR11MB8388namp_"
MIME-Version: 1.0
X-OriginatorOrg: entrust.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8388.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1ed0e65-90e0-4bb9-5267-08dd83720892
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2025 20:53:14.9569 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f46cf439-27ef-4acf-a800-15072bb7ddc1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qVnFvjWWIemwyYUGqepqXxLfARsbLkUaIR3j9hu0GoVqOlUwnUdYhnh5xPRmJvZy5UFlsJWAUK8j5ZLkgjZfNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5169
X-Proofpoint-GUID: l8o9fciJhYW6Y6AYYqRoSJ6idmABO1xI
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI0MDE0NyBTYWx0ZWRfX8s2TWi6bYa6R 3YIa9yk9FRUtOrx1KBuuxvyU6mbZOZv3itJob0skK9A37d23WkLv86SsgsARs4/5IcKxpL7AqEX Om+SMcR3322MC9LedMFDe0sjXCRjGKof+s/q0g6zmpnRumSop7h958GjMyxdGesTxXipZbbC5hs UzXjOEf3zPNbZ1owdH9pl2RVp+QIRATCRl6f3BCGVutvEMSLDMZinRLqiA+dih9bznoBw+vw2zx m6ZYM7g8MZKvIfoZKPUd4Vbocq4UlM/ig4pe9QVXUEbxlp3mhkJLBHgjrsH50yy2A/J/mgHH+m3 UkOkmJs4JhQtYQDTCpya7VKpe/ehzi2U4yWTunqbZQJkSftPn3S8ZqechL+8OVgCabhtWq+7WY5 WerMnYSOuOzgi/TvWodSGsntqB4F7U1WXqUULsq/wtwU262wcv1U10oQ3pqRS3qDIy13WorO
X-Authority-Analysis: v=2.4 cv=FtcF/3rq c=1 sm=1 tr=0 ts=680aa4c0 cx=c_pps a=gHjWyi4SN+6fNgZLRl0D7Q==:117 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=XR8D0OoHHMoA:10 a=FEbzDYiKvWYA:10 a=NEAV23lmAAAA:8 a=4H4PNi7YAAAA:8 a=48vgC7mUAAAA:8 a=N08Q0cKLcmc-1NuASQsA:9 a=CjuIK1q_8ugA:10 a=JktEDXJ0ykdBtPGlaTwA:9 a=2q4O/K3rjNU7EHYdBHB6dYyilSc=:19 a=k8vqJ5Wi8pID-vHS:21 a=frz4AuCg-hUA:10 a=_W_S_7VecoQA:10 a=SFsxeN8iWzPLxVZVBD6_:22
X-Proofpoint-ORIG-GUID: l8o9fciJhYW6Y6AYYqRoSJ6idmABO1xI
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-24_09,2025-04-24_02,2025-02-21_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2504070000 definitions=main-2504240147
Message-ID-Hash: XKXBVMTACQSU536IRPZTAZXRH4NNFVQR
X-Message-ID-Hash: XKXBVMTACQSU536IRPZTAZXRH4NNFVQR
X-MailFrom: John.Gray@entrust.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-spasm.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [lamps] Re: Partial review of draft-ietf-lamps-pq-composite-sigs-04 and draft-ietf-lamps-pq-composite-kem-06
List-Id: This is the mail list for the LAMPS Working Group <spasm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/vbx5Il-WHKSSuyD9tJ6mW4HmXNU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Owner: <mailto:spasm-owner@ietf.org>
List-Post: <mailto:spasm@ietf.org>
List-Subscribe: <mailto:spasm-join@ietf.org>
List-Unsubscribe: <mailto:spasm-leave@ietf.org>
Thanks Carl for the detailed review. As Mike already mentioned, we opened this github issue and added your comments: https://github.com/lamps-wg/draft-composite-sigs/issues/148 Before the last publishing deadline, we didn't have time to go over the documents together to make sure everything was consistent between the two documents, so thanks for pointing out the differences for us! We will make sure these comments are addressed! John Gray ________________________________ From: Carl Wallace <carl@redhoundsoftware.com> Sent: Monday, April 21, 2025 9:34 AM To: LAMPS <spasm@ietf.org> Subject: [EXTERNAL] [lamps] Partial review of draft-ietf-lamps-pq-composite-sigs-04 and draft-ietf-lamps-pq-composite-kem-06 Below are some comments on the composite-sigs and composite-kem drafts, with focus on sections up through section 6. I think the drafts have grown internally inconsistent as the definitions of the composite structures have changed and paused Below are some comments on the composite-sigs and composite-kem drafts, with focus on sections up through section 6. I think the drafts have grown internally inconsistent as the definitions of the composite structures have changed and paused my review accordingly. Most of the comments below could be addressed by considering the Serialize/Deserialize methods to be for internal use by the public API and by defining the public APIs (and tightening them up) in terms of the component parts and the defined data structures, i.e., length | pq artifact | trad artifact for public keys and signatures and the CHOICE structure from the peer certs drafts for private keys. Most of these comments are for readability and consistency. There is a question re: use of ML-DSA.Sign/Verify in section 4.3.1 and 4.3.2 that would affect interoperability. draft-ietf-lamps-pq-composite-sigs-04 and draft-ietf-lamps-pq-composite-kem-06 - The SerializeXXX and DeserializeXXX APIs should be noted as for use by the cryptographic primitives only, to be consistent with the view that composite keys, signatures, and ciphertexts are all single values. - The SerializeXXX APIs should each take two parameters, a PQ artifact and a traditional artifact, and should return a byte string of the form length || serialized PQ artifact || serialized traditional artifact (except for private keys, as noted below). - The DeserializeXXX APIs should each take a single parameter, a byte string of the form length || serialized PQ artifact || serialized traditional artifact and should return a tuple with two items (PQ artifact, traditional artifact). - DeserializeKey notes that failure may occur if input is malformed. SerializeKey may also fail if the input is malformed, i.e., wrong number of ML-DSA or ML-KEM bytes. This should be noted as well. - There should probably be a SerializePrivateKey/DeserializePrivateKey that aligns with the agreed upon private key format instead of the concatenation defined here. - There are several references to a "fixed 4-byte length" field. Suggesting dropping "fixed" given the values can change. - Some length checks on keys are against 2^32 instead of the three values that are expected. This seems unnecessarily tolerant. The next three bullets can be generically viewed as "Sections 5 and 6 are out of sync with rest of the document" - In section 5.1 of both drafts, there is no mention of prepending the concatenation with a length. These sections should just reference the SerializePublicKey method with the appropriate structures passed as parameters. Also, the rationale for using BIT STRING from previous drafts no longer applies, so OCTET STRING may be a better choice. - Section 5.2 of both drafts appears to be out of sync with the current definitions of private keys, given in neither case are the components encoded as OCTET STRINGs. - Section 5.3 of both drafts appears to be out of sync with the current definition of the public keys, which are defined as BIT STRINGs. Given public key is a BIT STRING and private key is an OCTET STRING, this section cannot treat both with the same text. Additionally, including a MAY for BER or DER hardly seems like it avoids compatibility issues. - Is section 6.2 still needed? It seems like a vestige of when the components were encoded as an ASN.1 SEQUENCE. draft-ietf-lamps-pq-composite-sigs-04 - Throughout, language about various components being "in the same order as the components" elsewhere seems like vestigial text from when the draft supported arbitrary combinations of algorithms and should probably be removed. - The paragraphs beginning "Note that there are two different context strings ctx" appear four times and probably could just appear once in the introduction. - In section 4.1, SerializeKey and the (currently missing) SerializePrivateKey should be used to prepare the concatenation of length, ML-DSA key and traditional key should be used for each instead (not the names of the structures, i.e., CompositeSignaturePublicKey and CompositeSignaturePrivateKey). - In section 4.1, it seems odd to refer to the inputs as "placeholders." What is meant by this? - In section 4.1, suggest dropping the verbiage allowing for custom structures where interop is not required. This is always an available option. - In section 4.2, the second and third paragraphs are out of sync with the algorithm descriptions. Suggest omitting these paragraphs. - In section 4.2.1 and 4.2.2, the definition of Domain should mention its use as ctx value for ML-DSA. - In section 4.2.x and 4.3.x, the length and endianess of len(ctx) should be stated. - In section 4.2.x and 4.3.x, the OID identifying the composite algorithm should be an explicit input. - In section 4.2.1 and 4.3.1, step 3 in the Signature Generation Process should use DeserializeKey instead of just assigning sk to a tuple value. - In section 4.2.1 and 4.3.1, Step 6 should invoke SerializeSignature instead of passing values as parameters to a structure and the value returned in Step 7 should be a byte string of the form length || PQ signature || trad signature. The current text implies that the return value is a BIT STRING. - In section 4.2.1 and 4.3.1, the first paragraph below figures 2 and 4 may be better placed in the key generation section or introduction to section 4 or in an implementation considerations section. - In section 4.2.2, step 2 in the Signature Verification Process should use DeserializeKey instead of just assigning sk to a tuple value and DeserializeSignature instead of just assigning to a tuple. - In section 4.3.1, should this be the message to be signed or the digest of the message to be signed? - In section 4.3, 4.3.1 and 4.3.2, where ML-DSA.Sign is referenced, should HashML-DSA.Sign be used? Same thing for verify. The parameters are not right if so. If not, it may be worth noting that this is not using HashML-DSA. - Section 4.4 refers to the same variables with three different names. For example, mldsaEncodedKey, mldsaEncodeKey and mldsaEncodedPK all appear to refer to the output of MLDSA.SerializeKey. - Step 5 of the DeserializeKey in 4.4 should note that it is returning the component keys, not the composite key. - In section 4.5, step 3 references key length where it should reference signature length. The line calculating the length of the key can be deleted. - Table 1 in section 4.6 appears to treat the private key as seed, expanded, or seed || expanded but this is not stated anywhere. This is also inconsistent with the private key format described in draft-ietf-lamps-dilithium-certificates. This section should probably simply reference the private key format defined in that specification. - Section 7.3 should include a note that the values are based on the prototyping OIDs and will change when IANA assigns final OID values. The similar section in the KEM draft already has a note like this. draft-ietf-lamps-pq-composite-kem-06 - Section 4.1 returns a tuple of tuples. This is inconsistent with the notion of treating composite keys as a single value, as noted in section 2.2. SerializeKey should be invoked to prepare the concatenation of length, ML-KEM key and traditional key for return. - In section 4.2, step 1 in the Encap Process should invoke DeserializeKey instead of just assigning pk to a tuple value. Step 4 should invoke SerializeCiphertext instead of simply concatenating values. Similar comments apply to the Decap Process in section 4.3. - Step 1 of the Deserialization Process in section 4.4 is underspecified. The "correct length" cannot be determined without first parsing out the length value for the first ML-KEM key. In step 2, change 'MAY be' to 'may be' or even 'is'. Step 5 is not outputting the "composite ML-KEM public key", it is outputting the "component algorithm public keys." - The term "CompositeCiphertextValue", which is an OCTET STRING, appears to be used to refer to concatenated values. It'd probably be best to not use the proper name of an ASN.1 definition for other purposes. - Table 1 in section 4.7 appears to treat the private key as seed, expanded, or seed || expanded but this is not stated anywhere. This is also inconsistent with the private key format described in draft-ietf-lamps-kyber-certificates. This section should probably simply reference the private key format defined in that specification. - In section 5.1, the definition of pk-MLKEM768-ECDH-P384 is not the same as in the ASN.1 module. - The ASN.1 comments regarding public key contents omit the length prefix (as described above for section 5.1). Suggest removing the comments. - In Appendix B, change 2.16.840.1..101.3.4.2.3 to 2.16.840.1.101.3.4.2.3. _______________________________________________ Spasm mailing list -- spasm@ietf.org To unsubscribe send an email to spasm-leave@ietf.org Any email and files/attachments transmitted with it are intended solely for the use of the individual or entity to whom they are addressed. If this message has been sent to you in error, you must not copy, distribute or disclose of the information it contains. Please notify Entrust immediately and delete the message from your system.
- [lamps] Partial review of draft-ietf-lamps-pq-com… Carl Wallace
- [lamps] Re: Partial review of draft-ietf-lamps-pq… Mike Ounsworth
- [lamps] Re: Partial review of draft-ietf-lamps-pq… John Gray