[Suit] Re: AD comments on draft-ietf-suit-update-management

Deb Cooley <debcooley1@gmail.com> Fri, 12 December 2025 12:33 UTC

Return-Path: <debcooley1@gmail.com>
X-Original-To: suit@mail2.ietf.org
Delivered-To: suit@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 45183999406B for <suit@mail2.ietf.org>; Fri, 12 Dec 2025 04:33:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.848
X-Spam-Level:
X-Spam-Status: No, score=-1.848 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZdkEocrcHgVT for <suit@mail2.ietf.org>; Fri, 12 Dec 2025 04:33:42 -0800 (PST)
Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id A19479994054 for <suit@ietf.org>; Fri, 12 Dec 2025 04:33:42 -0800 (PST)
Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-c0224fd2a92so1105092a12.2 for <suit@ietf.org>; Fri, 12 Dec 2025 04:33:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765542815; x=1766147615; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hchtMzW4OrD2U3v0KXCqwQLtaUn7KjikuTQ8KYIHc+U=; b=V25ZEPk5LIzYkFnX5QGqpCDZ/NVoESyG91OvZuuJ7Hpo9zqRyUMASVuN/HKuTEM8gk x2cb5kjlPXZMgj5UFMgqygVWey1hKZb1MawujuAWKeshj5IHY7k28061A024fkFgIaAB Ajn7qIjMTEIFh94Ym6L8AiBTZYkleXeMX5WruzswOo8EBH+2UbeW5Xjp+oulu/dGYInT OpShITwbQQ+C/c/Iaz5BIsEU7XwcTf2J2ji+bcU4Q4XU2Kf5BkRBYDWB9w8pn+d8thAV q/thpEjq8V9uzY+3ZrLxVFac1DYeh9ZXOjtopiKwPMIEUAoPM/c0vMCd+vlGakkmJxM4 osnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765542815; x=1766147615; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hchtMzW4OrD2U3v0KXCqwQLtaUn7KjikuTQ8KYIHc+U=; b=cfxEUnq+/K10uB64tVMkE2YQiyIx+u/JznT97TuZPgfYnorTDleHM9fWgBXxU2WqDc hSZkV3XF1MZktYn0slqr9j5uNr/ZuT9y3E3HZv1RDByEix4cDbw9p+VkuTQcpvcKuqJV ClTNCiJcbKMiB+3x/u+FwGNd3Z68xSd/6wjyk1nogi2vWicTiJuj0uLf93iZ3wJ6ZmBP zzfSxgMs5Hd5NDwaPjYN+xYic7mJWQECWLY+ZeKch9XByKJ//JS08b7w44LNxxmw1x36 wmyfmEmtOKyRJ2F7OjvgmCrX4RvwA7+7RKvNmWxcDHQRslTLTErVLP59LL4045tQBSY4 FgDw==
X-Forwarded-Encrypted: i=1; AJvYcCWjdE1Kyc5z1Lmbw6CmpvJMGTRePKYxaCiAnEwuAO2KVA9v4kvdhHbOyPRfh+vgVo6jxAqs@ietf.org
X-Gm-Message-State: AOJu0YzPw614zA0q6efwwLZbrqvEHjW8LXeQyyixdi5k9vX1s9qQ8ivx qd/8wGmTaYQJq1ZCSolwlSD4RvaJENAz2o+UrKaKS984SvgWoAxm0RN25G5u0NjHtyvAXXFS0Z6 eguEEnWH3PbFGQQu8UlMCOxk2P6Rv4IjT+Rc=
X-Gm-Gg: AY/fxX6B9mp/hBxjX9AoqDPhIeCvU1MyfWSZWRaSwtBLoFOkMrVHu4jJ3mYc/5YaKIq PxPEUrBJUkWZNE8Cj+KyexUHMDaBAyvIHs5JCL+V9nCPCA93/pUoMwdGIY2tFRoZYBmEKIWFJY+ EHWWm+krj6GJgUJc/HyN+oRDy+Xn1u2inbqCPNdCJTTAVR11N09TXnl+kujSOQRR6jMMozYDbKc N0O/kprHxh62KMpD5NPIATjAwQOQ+2Pd9ZITflygaqeliGVcs87wkET+88srxjDgvoTOQnKm49I Li2gGk8EwgYd5iwBzKFwcDb4a332evIpKELf3Yg=
X-Google-Smtp-Source: AGHT+IGOrca4Hnkxu+3TfwA0JPFzgUFLTvVYgaRbSiWui694Ika0b0juXR3W3nb4bQI7c15/kpvuhT9Hyt0ddqDGsHc=
X-Received: by 2002:a05:693c:248a:b0:2a4:6416:7f2e with SMTP id 5a478bee46e88-2ac30120ac4mr1013081eec.35.1765542815188; Fri, 12 Dec 2025 04:33:35 -0800 (PST)
MIME-Version: 1.0
References: <CAGgd1OcV+sFxJFgxJmS79am2orjHUiejLpkahAjsMreMweaRiw@mail.gmail.com> <AM0PR08MB53299F41B84658C64C7BC4FCEAAEA@AM0PR08MB5329.eurprd08.prod.outlook.com>
In-Reply-To: <AM0PR08MB53299F41B84658C64C7BC4FCEAAEA@AM0PR08MB5329.eurprd08.prod.outlook.com>
From: Deb Cooley <debcooley1@gmail.com>
Date: Fri, 12 Dec 2025 07:33:23 -0500
X-Gm-Features: AQt7F2pGfYX7elOXsJdQZpRk_DEFGI5a6Ewis3Knlc0-uTfoF4AG2oAXiNt4dXY
Message-ID: <CAGgd1Of=HNEXd+UKD655y+sSzPvmHraNsXRWvurd8pYsQG28kA@mail.gmail.com>
To: Brendan Moran <Brendan.Moran@arm.com>
Content-Type: multipart/alternative; boundary="00000000000055cc0c0645c07870"
Message-ID-Hash: 6WVI6273S5RZKBMINJFR3N5WYU6P6ALY
X-Message-ID-Hash: 6WVI6273S5RZKBMINJFR3N5WYU6P6ALY
X-MailFrom: debcooley1@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-suit.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-suit-update-management.authors@ietf.org" <draft-ietf-suit-update-management.authors@ietf.org>, "suit-chairs@ietf.org" <suit-chairs@ietf.org>, "suit@ietf.org" <suit@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [Suit] Re: AD comments on draft-ietf-suit-update-management
List-Id: Software Updates for Internet of Things <suit.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/suit/vQXh6PhKQTiA3RcumtNDr6rxbBw>
List-Archive: <https://mailarchive.ietf.org/arch/browse/suit>
List-Help: <mailto:suit-request@ietf.org?subject=help>
List-Owner: <mailto:suit-owner@ietf.org>
List-Post: <mailto:suit@ietf.org>
List-Subscribe: <mailto:suit-join@ietf.org>
List-Unsubscribe: <mailto:suit-leave@ietf.org>

Inline w/ my original comments w/ [DC].  These are very minor - please make
a note of them for a future update.

I will put this draft into IETF Last Call. (huzzah!)

Deb

On Fri, Dec 12, 2025 at 4:55 AM Brendan Moran <Brendan.Moran@arm.com> wrote:

> Hi Deb,
>
> Thank you for your review!
>
> I believe that we have now addressed all the comments that you have made
> on this draft.
>
> Best Regards,
> Brendan
>
> *From: *Deb Cooley <debcooley1@gmail.com>
> *Date: *Friday, 31 October 2025 at 12:46
> *To: *draft-ietf-suit-update-management.authors@ietf.org <
> draft-ietf-suit-update-management.authors@ietf.org>
> *Cc: *suit-chairs@ietf.org <suit-chairs@ietf.org>, suit@ietf.org <
> suit@ietf.org>
> *Subject: *[Suit] AD comments on draft-ietf-suit-update-management
>
> Apologies for sending these right before IETF 124.  The good news is that
> the submission tool reopens on 2 Nov.
>
> General:  If there is a SHOULD, then there needs to be a statement about
> when it might be ok to ignore.  If that statement is hard to determine,
> then why not MUST?  The other option is 'should' vice 'SHOULD'.  I'll try
> and point these out when I see them. Please see:
> https://datatracker.ietf.org/doc/statement-iesg-statement-on-clarifying-the-use-of-bcp-14-key-words/
>
> Introduction, last paragraph:  Is there interoperability guidance for a
> device that either doesn't expect extensions, or does expect these
> extensions but they don't exist?
>
> Section 3.1, para 2:  'version SHOULD be encoded', what is the
> circumstance why this won't be done?  (or why not MUST?)  There is a later
> 'SHOULD NOT' where the addition of the build number will be ignored anyway,
> I'm not sure that we couldn't use 'should not' in this circumstance.
>
> Section 3.1, para 4:  SHOULD?  or MAY?  If SHOULD, then why would it be
> done differently?
>
> Section 3.2, para 2:  'SHOULD' or what?
>
> Section 3.3:  No formatting rules?  Does it have to be printable text?  Is
> there a length requirement?  the 'SHOULD' in this case should be obvious -
> otherwise a device operator will be confused.
>
[DC]  change 'no specific formatting rules'/ 'no additional specific
formatting rules'.

>
> Section 3.4, para 2, last sentence:  free text field with no specific
> formatting rules, seems like this could be used as an attack vector?  If
> the machine version is different from the text-version, which one is the
> authoritative one?
>
> [DC]   change 'no specific formatting rules'/ 'no additional specific
formatting rules'.

Section 4.4, last paragraph:  Isn't this true for all extensions?  Is this
> different from the statement in the Introduction?
>
> Section 4.4.1:
>  - SHOULD: what if they encoded versions aren't semantic versions?
>  - Move the examples to the end of the section.
>  - Add (RC) after '-1: Release Candidate'.
>
> Section 4.5:  ALL isn't a BCP 14 keyword.  How about:  'All wait events
> MUST be satisfied, before the Manifest Processor continues.'  Or just make
> it lower case.  Either will work.
>
> Section 4.5, last paragraph: 'suit-parameter-version-match' does not
> appear to be defined in this specification.  Perhaps it should be
> 'SUIT_Parameter_Version_Match'?  Or maybe just 'suit-parameter-version'?
>
> Section 4.6.1:  No rules for formatting?
>
> Section 5 and all subsections:  Some of these have a statement about being
> OPTIONAL to implement.  Are the other commands mandatory?
>
> Section 7:  The existence of unformatted text fields deserves a mention in
> this section.
>
[DC]  repeated word (Sections)


>
> Appendix A:  It is unusual for an appendix to have BCP 14 key words.  I
> would suggest changing 'MUST' to 'must'.  Lower case 'must' is still
> normative (see above on use of BCP 14 key words in appendices).
>
> Deb
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>