Re: [Supa] ietf-supa-service-flow.yang in draft-chen-supa-eca-data-model-04.txt

["Liushucheng (Will)" <[e-mail]>]

Hi all,

In addition to Benoit’s emails, below please find my review for this draft.

Section 1 and maybe other parts of the doc
Terms related to the architecture such as policy manager, policy agent, service management, etc, in SUPA context was defined in draft-zhou-supa-framework and part of the content of this draft was merged into draft-klyus-supa-proposition. The author may think about to refer them.

Section 2.1
Authors wrote      “<status> <flags> <name> <opts> <type>” , however, ‘type’ was not listed in the explanation next paragraph, while “[<keys>] for the keys of a particular list” is not mentioned at the beginning of this subsection.

Section 3.1
The leafs name in supa-polic-target, such as profileType, asDomainName, etc, should be amended to fit custom of YANG models like profile-type . etc…

The author may consider to add some xml examples to illustrate some of models.

NITS
s/rpcs/RPCs
s/An event or a set of events/ A set of events,   or s/A set of conditions/ A condition or a set of conditions, s/A set of actions/ A action or a set of actions
s/ supa-policy-target target/ supa-policy-target


In spite of these, I believe this draft is indeed a really good and solid start for the group to explore the method of defining policy rules according to the event-condition-action paradigm.

Regards,
Will (Shucheng LIU)

From: Supa [mailto:[e-mail]] On Behalf Of Benoit Claise
Sent: Thursday, October 22, 2015 5:05 PM
To: Tina TSOU; [e-mail]
Cc: [e-mail]
Subject: Re: [Supa] ietf-supa-service-flow.yang in draft-chen-supa-eca-data-model-04.txt

Hi Tina,

It works better
bclaise$ pyang --ietf eca-policy.yang
eca-policy.yang:2: warning: RFC 6087: 4.1: no module name prefix used, suggest ietf-eca-policy

This warning is new with pyang 1.6. You should get it from https://github.com/mbj4668/pyang

Regards, Benoit
Dear Benoit et al,

That’s weird, so I checked the history version, found out that the old version must have been accidentally used.

Therefore, I try to help and make the attachments, which should be fine to pass all the pyang --ietf check. Please have a look again.


Thank you,
Tina

From: Supa [mailto:[e-mail]] On Behalf Of Benoit Claise
Sent: Wednesday, October 21, 2015 10:42 PM
To: [e-mail]<mailto:[e-mail]>
Cc: [e-mail]<mailto:[e-mail]>
Subject: [Supa] ietf-supa-service-flow.yang in draft-chen-supa-eca-data-model-04.txt

Hi,

pyang --ietf produces:
ietf-supa-service-flow.yang:2: warning: RFC 6087: 4.8: namespace value should be "urn:ietf:params:xml:ns:yang:ietf-supa-service-flow"
ietf-supa-service-flow.yang:6: warning: imported module ietf-yang-types not used
ietf-supa-service-flow.yang:10: error: module "eca-policy-0910" not found in search path
ietf-supa-service-flow.yang:10: warning: imported module eca-policy-0910 not used
ietf-supa-service-flow.yang:25: error: RFC 6087: 4.7: statement "revision" must have a "reference" substatement
ietf-supa-service-flow.yang:29: error: bad value "/supa:supa-policy/supa:supa-poliy-
target/supa:instance" (should be schema-nodeid)
ietf-supa-service-flow.yang:33: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:34: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:35: error: keyword "config" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:36: error: keyword "default" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:40: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:41: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:42: error: keyword "config" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:43: error: keyword "default" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:47: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:48: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:49: error: keyword "config" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:50: error: keyword "default" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:54: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:55: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:56: error: keyword "config" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:60: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:61: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:62: error: keyword "config" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:68: error: bad value "/supa:supa-policy/supa:supa-policy-
statement/supa:condition-list" (should be schema-nodeid)
ietf-supa-service-flow.yang:72: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:73: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:77: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:78: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:84: error: bad value "/supa:supa-policy/supa:supa-policy-
statement/supa:action-list" (should be schema-nodeid)
ietf-supa-service-flow.yang:92: error: keyword "when" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:96: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:97: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:101: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:102: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:106: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:107: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:111: error: keyword "description" not in canonical order, expected "type", (See RFC 6020, Section 12)
ietf-supa-service-flow.yang:112: error: keyword "type" not in canonical order, (See RFC 6020, Section 12)

and pyang alone:
ietf-supa-service-flow.yang:6: warning: imported module ietf-yang-types not used
ietf-supa-service-flow.yang:10: error: module "eca-policy-0910" not found in search path
ietf-supa-service-flow.yang:10: warning: imported module eca-policy-0910 not used
ietf-supa-service-flow.yang:29: error: bad value "/supa:supa-policy/supa:supa-poliy-
target/supa:instance" (should be schema-nodeid)
ietf-supa-service-flow.yang:68: error: bad value "/supa:supa-policy/supa:supa-policy-
statement/supa:condition-list" (should be schema-nodeid)
ietf-supa-service-flow.yang:84: error: bad value "/supa:supa-policy/supa:supa-policy-
statement/supa:action-list" (should be schema-nodeid)

Regards, Benoit