Re: [Taps] Erik Kline's Discuss on draft-ietf-taps-interface-22: (with DISCUSS and COMMENT)
Tommy Pauly <tpauly@apple.com> Tue, 14 November 2023 16:54 UTC
Return-Path: <tpauly@apple.com>
X-Original-To: taps@ietfa.amsl.com
Delivered-To: taps@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CFCDC15198C for <taps@ietfa.amsl.com>; Tue, 14 Nov 2023 08:54:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.404
X-Spam-Level:
X-Spam-Status: No, score=-4.404 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=apple.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8047S6TdXyXK for <taps@ietfa.amsl.com>; Tue, 14 Nov 2023 08:54:46 -0800 (PST)
Received: from ma-mailsvcp-mx-lapp01.apple.com (ma-mailsvcp-mx-lapp01.apple.com [17.32.222.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A5EA5C1519AC for <taps@ietf.org>; Tue, 14 Nov 2023 08:54:46 -0800 (PST)
Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma-mailsvcp-mx-lapp01.apple.com (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28 2023)) with ESMTPS id <0S440060FHLJJE40@ma-mailsvcp-mx-lapp01.apple.com> for taps@ietf.org; Tue, 14 Nov 2023 08:54:45 -0800 (PST)
X-Proofpoint-GUID: N8L6xqBZZRUS0AP55ADbDvETR7dALei0
X-Proofpoint-ORIG-GUID: N8L6xqBZZRUS0AP55ADbDvETR7dALei0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.619, 18.0.987 definitions=2023-11-14_16:2023-11-14, 2023-11-14 signatures=0
X-Proofpoint-Spam-Details: rule=interactive_user_notspam policy=interactive_user score=0 mlxscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311140128
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=3lM/cQDN+be1ITPYp/ST4MCfNpNE3wlUYytZnQp62m8=; b=YhePjm7709SnhP+kkge1SuVfybzpjWJw22fkWrbKWz76+6qrg5eAZ6Fa3HAV6FrV/aDq c8/kc37tSQakwcIzBEH/i8bjVtGU1BOgiMbgvETuJ+nUl/5Jn9QE/qZyACxqDfExlOwr SLpBVvvM4ZY8YN+4/qDV1qz1fnKp0/fPOGY5NFEg23IC+WMpPSpdZheIo/ZaDrFK4ioE sC3C9Las87n1Qhcp/QPsOwhxOtx0fslevbdsHuGXaEvExNrg4QMdL7NZ64DckDcdtwsl JDvP/qTGgxvFwNW/fUrthNE/FjRoCILRYddoJNU4QxdZctWYm5VCyTMroEpD2rIScjjm mw==
Received: from rn-mailsvcp-mmp-lapp02.rno.apple.com (rn-mailsvcp-mmp-lapp02.rno.apple.com [17.179.253.15]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28 2023)) with ESMTPS id <0S4400699HMX2TI0@rn-mailsvcp-mta-lapp03.rno.apple.com>; Tue, 14 Nov 2023 08:54:34 -0800 (PST)
Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp02.rno.apple.com by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28 2023)) id <0S4401100HBVJ500@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Tue, 14 Nov 2023 08:54:33 -0800 (PST)
X-Va-A:
X-Va-T-CD: 43a1126a6581cd63d903173a70428f1a
X-Va-E-CD: 6c3c1c46dddce0591f64b265d3cf41b3
X-Va-R-CD: f03fc47a645adb59ec4c75c640c229e8
X-Va-ID: 330f38cf-5801-4216-badb-e7c9d43e6d5b
X-Va-CD: 0
X-V-A:
X-V-T-CD: 43a1126a6581cd63d903173a70428f1a
X-V-E-CD: 6c3c1c46dddce0591f64b265d3cf41b3
X-V-R-CD: f03fc47a645adb59ec4c75c640c229e8
X-V-ID: 26ba64eb-2cd6-4274-b808-4d4099f827d3
X-V-CD: 0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.619, 18.0.987 definitions=2023-11-14_16:2023-11-14, 2023-11-14 signatures=0
Received: from smtpclient.apple ([17.234.111.152]) by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28 2023)) with ESMTPSA id <0S4400KF1HMX5Z00@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Tue, 14 Nov 2023 08:54:33 -0800 (PST)
From: Tommy Pauly <tpauly@apple.com>
Message-id: <387B51BA-294E-435F-AAB8-5C60ED209467@apple.com>
Content-type: multipart/alternative; boundary="Apple-Mail=_064952A9-78DB-46D2-BECE-9A0402257A60"
MIME-version: 1.0 (Mac OS X Mail 16.0 \(3774.300.22\))
Date: Tue, 14 Nov 2023 08:54:22 -0800
In-reply-to: <169406568172.34717.179063317058184372@ietfa.amsl.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-taps-interface@ietf.org, taps-chairs@ietf.org, taps@ietf.org, anna.brunstrom@kau.se
To: Erik Kline <ek.ietf@gmail.com>
References: <169406568172.34717.179063317058184372@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3774.300.22)
Archived-At: <https://mailarchive.ietf.org/arch/msg/taps/k8Vz457xenO5j1JSamJxKNW-GE0>
Subject: Re: [Taps] Erik Kline's Discuss on draft-ietf-taps-interface-22: (with DISCUSS and COMMENT)
X-BeenThere: taps@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "IETF Transport Services \(TAPS\) Working Group" <taps.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/taps>, <mailto:taps-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/taps/>
List-Post: <mailto:taps@ietf.org>
List-Help: <mailto:taps-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/taps>, <mailto:taps-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2023 16:54:50 -0000
Hi Erik, Thanks very much for your review! The authors have just posted a -23 version that addresses all of the IESG comments, including your DISCUSS. https://www.ietf.org/archive/id/draft-ietf-taps-interface-23.html For your particular DISCUSS comment on PvD Identifiers, we submitted this PR: https://github.com/ietf-tapswg/api-drafts/pull/1427. That change: - References RFC 8801 - Explains that the FQDN defined there can be used, but that other PvD IDs may be available that are locally defined on a system Best, Tommy (on behalf of the authors) > On Sep 6, 2023, at 10:48 PM, Erik Kline via Datatracker <noreply@ietf.org> wrote: > > Erik Kline has entered the following ballot position for > draft-ietf-taps-interface-22: Discuss > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ > for more information about how to handle DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-taps-interface/ > > > > ---------------------------------------------------------------------- > DISCUSS: > ---------------------------------------------------------------------- > > # Internet AD comments for draft-ietf-taps-interface-22 > CC @ekline > > * comment syntax: > - https://github.com/mnot/ietf-comments/blob/main/format.md > > * "Handling Ballot Positions": > - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/ > > ## Discuss > > ### S6.1.12 > > * "there is currently no portable standard format for a PvD identifier" > > RFC 8801 should be considered here. > > An argument can be made that there is no *single* format, but there > certainly is a string FQDN PvD ID standard. > > I think it's fair to require that the FQDN PvD ID strings be considered > MTI here, or that an implementation have some way to use handles that > refer to these. Maybe that's what's meant here by the integer option > mention and I'm just not getting the clue. > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > # Internet AD comments for draft-ietf-taps-interface-22 > CC @ekline > > * comment syntax: > - https://github.com/mnot/ietf-comments/blob/main/format.md > > * "Handling Ballot Positions": > - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/ > > # Comments > > ### S3 > > * "The application should not assume that ignoring events..." > s/should not/SHOULD NOT/? > > ### S6.1 > > * "Connection can perform name resolution" > > Does the Connection do name resolution? I would have expected this to > either be done by Preconnection or just "the API implementation". > > ### S6.1.3 > > * If calls like NewPreconnection() take an array of RemoteEndpoints why > is it necessary to add one RemoteEndpoint to another via .AddAlias(), > rather than just tossing into the []RemoteEndpoints array? > > ### S6.2 > > * It's probably too late for a bikeshed, but I find a Preference named > "Ignore" to not mean "No Preference", as I read it. I would have expected > something like a Preference of "None". > > To me, "Ignore" feels kinda somewhat like "Avoid" (or "Eschew" :D ). > > ### S6.2.1 > > * "without corruption"? > > I think I would have expected "without loss"; "without corruption" implies > to me that there's some extra level of integrity checking go on (vis. > S6.2.7). > > ### S6.2.13 > > * Why should the preference be Avoid for Rendezvous use cases? It seems > to me like many Rendezvous uses are not necessarily long-lived and so > might be Preference None (Ignore), or even Prefer. > > ### S9.1.3.7 > > * Same question as S6.2.1 above. > > ## Nits > > ### S5 > > * "Actions, events, and errors in implementations" -> > "Action, event, and error objects in implementations" > > ### S6.1, S6.1.4 > > * "Port (a 16-bit integer)" > > Perhaps "unsigned integer", or "non-negative integer"? > > * ":0a" -> ":a", I think > > ### S6.1.5 > > * "newPreconnection(...)" -> "NewPreconnection(...)"? > > ### S9.1.3.10 > > * s/endpount/endpoint/ > > > > _______________________________________________ > Taps mailing list > Taps@ietf.org > https://www.ietf.org/mailman/listinfo/taps
- [Taps] Erik Kline's Discuss on draft-ietf-taps-in… Erik Kline via Datatracker
- Re: [Taps] Erik Kline's Discuss on draft-ietf-tap… Tommy Pauly
- Re: [Taps] Erik Kline's Discuss on draft-ietf-tap… Tommy Pauly