Re: [tcpm] Changes to draft-ietf-tcpm-hystartplusplus after WGLC

Praveen Balasubramanian <pravb.ietf@gmail.com> Mon, 12 December 2022 23:31 UTC

Return-Path: <pravb.ietf@gmail.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB02FC14CE25; Mon, 12 Dec 2022 15:31:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.093
X-Spam-Level:
X-Spam-Status: No, score=-2.093 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kg-kx47bwanY; Mon, 12 Dec 2022 15:31:42 -0800 (PST)
Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EFB9FC14CF14; Mon, 12 Dec 2022 15:31:41 -0800 (PST)
Received: by mail-oi1-x242.google.com with SMTP id c129so12804224oia.0; Mon, 12 Dec 2022 15:31:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7QT2PWQunL1xX+sqOUB7owBc89XGMGEvfIX2miOBiGU=; b=onxIgA+DgmGXLqUy24geAzuYzBn7ewy7ZOUVbCGlThDIluxj+ECr4t2J8i0MmTr3X4 9XbNlwlelNlpUKnnWHJyh40X3dYMg5U17S4rCYQej7Mde0LDNsheXg9EHQBhqoIcW86+ xHysm87Ll52cclSQrXmSnrMZhC4MBciMleyqRY5XFloefP74ta9RxEC7lx7D06bm3cDG c9MPvHLqclwF2IrU87BkXMCsuhjmXWjSb0zxn6XLcnbaQ+PvEAMNsW7SGpfgY5rZmYP2 32FT64nZpMAoAWzW8HXS82J/So3AIDqhb9qEfDg3P2uFRDsBbIET1EhySE8/to+B6V/v 434A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7QT2PWQunL1xX+sqOUB7owBc89XGMGEvfIX2miOBiGU=; b=ibqCAbClHl650xBRp2HsVEkaWMUUz4vbAIndJ4VJU2Fzv+/0NaLSROK9ZFwEliTFs6 FnswsUGWppBfy3pTdu6zzw1iBca+jvVQsIfIWCmnQhXbrQgjRaV0j09e2EWWY1xNz2Z3 pUU+8VracBDT7ZU1Tm6M2D7Zts3bmM6CHxfIVdkvJy3mR24PKaQ9X0tYWW5i3Ls/k2r+ RdmzwnfcJhf4h1Vbq/On29wE441lRzH04Berv6YvndmdaxC3AxAYoAz2IclNsRZ4ariM ZqWucCEnYLGaivHwoa5lPNjEyLiAWe6gNavdSSTam6cFQ7jJHVFLNyapJasHVJBbCZqn GE4g==
X-Gm-Message-State: ANoB5pkodC0lACV3fD/A2zpZ2IBouSVOej1YpOkeySDjOsOXh8IpN66i vvzXHjpuyQFDlQ/2Hi60ZD2rH0vcDA9/m1N3DtM=
X-Google-Smtp-Source: AA0mqf6qKSUH/UMBR2MWG5/R1QGqZShB2BetQ+N0K0AJYb6XFV1LsLbwto36MLCp34NOsW+JxwYAfTA2v/I+eIbP8HA=
X-Received: by 2002:a54:418b:0:b0:35a:2de8:70b1 with SMTP id 11-20020a54418b000000b0035a2de870b1mr52056oiy.94.1670887901168; Mon, 12 Dec 2022 15:31:41 -0800 (PST)
MIME-Version: 1.0
References: <BB532E01-A5E2-47EC-A1DF-0B7F08D709A0@fh-muenster.de> <CADVnQynWfSwwMw-3mrT8c7t6h9Trytj6RB=pspZf3iZe6VStGg@mail.gmail.com> <588E62C3-6501-4D74-BE5A-B27425675071@fh-muenster.de> <33736d61-99c6-d26f-0af7-d8292902e13b@erg.abdn.ac.uk> <CADVnQyk512ctrdAPxTy43-E9pAHp625e66f_oKvWzN8b1huJEQ@mail.gmail.com> <537436f4-e531-67c6-62c4-63e4768a52e4@erg.abdn.ac.uk> <CADVnQynvJiYRDUxCteCbJNddSNcWrdyQKyCbQiKDXVg1-kLHHQ@mail.gmail.com> <40edbedf-95ce-c291-fea2-4d1440a2f8f9@erg.abdn.ac.uk>
In-Reply-To: <40edbedf-95ce-c291-fea2-4d1440a2f8f9@erg.abdn.ac.uk>
From: Praveen Balasubramanian <pravb.ietf@gmail.com>
Date: Mon, 12 Dec 2022 15:31:30 -0800
Message-ID: <CAL=F3yKT6N0vi33t1kMTeyQNR2zDTYwjM0UEVCEkFNnD_2x-0A@mail.gmail.com>
To: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Cc: Neal Cardwell <ncardwell@google.com>, tuexen@fh-muenster.de, tcpm <tcpm@ietf.org>, draft-ietf-tcpm-hystartplusplus.all@ietf.org
Content-Type: multipart/alternative; boundary="000000000000cf0a7705efa9e7cd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/-X4Y13EItMuhP8VBO7KlmSdcntg>
Subject: Re: [tcpm] Changes to draft-ietf-tcpm-hystartplusplus after WGLC
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2022 23:31:42 -0000

We will add text that disambiguates what the default was for.

On Wed, Dec 7, 2022 at 10:01 AM Gorry Fairhurst <gorry@erg.abdn.ac.uk>
wrote:

> On 06/12/2022 15:00, Neal Cardwell wrote:
>
>
>
> On Tue, Dec 6, 2022 at 4:09 AM Gorry Fairhurst <gorry@erg.abdn.ac.uk>
> wrote:
>
>> On 05/12/2022 20:07, Neal Cardwell wrote:
>> > On Mon, Dec 5, 2022 at 4:48 AM Gorry Fairhurst <gorry@erg.abdn.ac.uk>
>> wrote:
>> >> On 05/12/2022 09:03, tuexen@fh-muenster.de wrote:
>> >>>> On 29. Nov 2022, at 19:31, Neal Cardwell <ncardwell=
>> 40google.com@dmarc.ietf.org> wrote:
>> >>>>
>> >>>> On Tue, Nov 29, 2022 at 7:05 AM <tuexen@fh-muenster.de> wrote:
>> >>>> Dear all,
>> >>>>
>> >>>> during the AD review, some changes have been made to
>> draft-ietf-tcpm-hystartplusplus-09
>> >>>> in relation with RFC 3465 (TCP Congestion Control with Appropriate
>> Byte Counting (ABC))
>> >>>> to avoid referencing an informational document from a standards
>> track document.
>> >>>>
>> >>>> These changes can be reviewed using:
>> >>>>
>> https://www.ietf.org/rfcdiff?url1=https://www.ietf.org/archive/id/draft-ietf-tcpm-hystartplusplus-09.txt&url2=https://www.ietf.org/archive/id/draft-ietf-tcpm-hystartplusplus-11.txt
>> >>>>
>> >>>> Please indicate within a week, whether you are fine with these
>> changes or provide
>> >>>> some comments.
>> >>>>
>> >>>> Thanks for posting the diff!
>> >>>>
>> >>>> Regarding this part of section 5, "Deployments and Performance
>> Evaluations":
>> >>>>
>> >>>> The original Hystart has been default-enabled
>> >>>> for all TCP connections in the Linux operating system using the
>> >>>> default congestion control module CUBIC ([RFC8312]) for a decade with
>> >>>> L = infinity with pacing enabled.
>> >>>> The "with pacing enabled" part looks inaccurate. Linux TCP thus far
>> has not enabled pacing by default. This passage would be correct if
>> modified to read: "for a decade with L = infinity with pacing disabled by
>> default."
>> >>> Now I'm confused. I thought the reason for "SHOULD use L=Infinity
>> when pacing enabled" was that
>> >>> this setting is used in Linux for years as the default. So what is
>> the reason now?
>> >>>
>> >>> Best regards
>> >>> Michael (as an individual)
>> >> I'm also now wondering what is the case:
>> >>
>> >> To me at least, the pacing text describes a way we can more concretely
>> >> say that that bursts were mitigated (albeit without saying how to
>> pace).
>> >>
>> >> Is the use of the word "default" in some way confusing?
>> > IMHO it is not confusing. :-) If someone could outline how it is
>> > confusing, that could be useful.
>>
>> When I first read this, I thought I read  "when pacing is enabled",
>> which seems consistent with what you say, but the ID did not actually
>> read that way. The text says:
>>
>> "The original Hystart has been default-enabled
>>     for all TCP connections in the Linux operating system using the
>>     default congestion control module CUBIC ([RFC8312]) for a decade with
>>     L = infinity with pacing enabled."
>>
>> - my question was therefore about whether Linux distributions have then
>> enabled pacing by default ?
>>
>
> I mentioned this in my first e-mail in this thread (from Nov 29):
>
>    The "with pacing enabled" part looks inaccurate. Linux TCP thus far
>    has not enabled pacing by default. This passage would be correct if
>    modified to read: "for a decade with L = infinity with pacing disabled
> by default."
>    ...
>    ...the "pacing enabled" part is only true of Linux installations that
> use
>    the "fq" qdisc, which is not the default for the Linux kernel or any
> major
>    Linux distribution that I'm aware of ("fq_codel" is increasingly common
>    among major Linux distributions, but it does not implement pacing).
>
> If you need more detail: I just checked, and of the most recent versions
> of the most popular Linux distributions the default qdiscs used are:
>
>    + Ubuntu 22.04 and CentOS Stream 9 use fq_codel
>    + Debian 11 and RHEL 7 use pfifo_fast
>
> Neither fq_codel nor pfifo_fast implement pacing. So this seems to confirm
> that pacing is still not enabled by default on major Linux distributions.
>
> neal
>
> >> I was hoping
>> >> there had been experience in some specific networks using "L=Infinity
>> >> when pacing was enabled",
>> > Yes, there is extensive experience with large-scale deployment of this
>> > approach (paced CUBIC with Hystart and L = infinity.), including all
>> > YouTube and Google TCP traffic (both internally and over the public
>> > Internet) in the 2013-2016 era.
>> >
>> Good - that is what I thought about these using pacing.
>> >> and was expecting that the spec only permitted
>> >> when bursts were avoided, e.g., pacing was enabled?
>> > Yes, the Hystart++ spec already does this; it says:
>> >
>> >    L = infinity if paced, L = 8 if non-paced
>> >
>> > best regards,
>> > neal
>>
>> Best wishes,
>>
>> Gorry
>>
>>
>> >> Gorry
>> >>
>> >>
>> >>>> To be clear, the algorithm variant mentioned here (Linux TCP with
>> CUBIC Hystart and L=infinity and pacing enabled) has had plenty of air
>> miles, including YouTube and Google TCP traffic in the 2013-2016 era. But
>> the "pacing enabled" part is only true of Linux installations that use the
>> "fq" qdisc, which is not the default for the Linux kernel or any major
>> Linux distribution that I'm aware of ("fq_codel" is increasingly common
>> among major Linux distributions, but it does not implement pacing).
>> >>>>
>> >>>> The rest of the update looks good to me.
>> >>>>
>> >>>> Thanks!
>> >>>>
>> >>>> best regards,
>> >>>> neal
>> >>>>
>> >>>> Best regards
>> >>>> Michael_______________________________________________
>> >>>> tcpm mailing list
>> >>>> tcpm@ietf.org
>> >>>> https://www.ietf.org/mailman/listinfo/tcpm
>> >>>> _______________________________________________
>> >>>> tcpm mailing list
>> >>>> tcpm@ietf.org
>> >>>> https://www.ietf.org/mailman/listinfo/tcpm
>> >>> _______________________________________________
>> >>> tcpm mailing list
>> >>> tcpm@ietf.org
>> >>> https://www.ietf.org/mailman/listinfo/tcpm
>> >>
>>
>> OK, I think I udnerstand and this is close to what I expected, thanks for
> explaining.
>
> My comment arose from the current text that read:
>
> "The original Hystart has been default-enabled
>
>    for all TCP connections in the Linux operating system using the
>    default congestion control module CUBIC ([RFC8312]) for a decade with
>    L = infinity with pacing enabled."
> - Which I took as saying that pacing was by default enabled, I still read it this way.
>
> Do you think we can rephrase this, depending on what was the case?
>
> For example:
>
>    "There has been over a decade of experience using the original Hystart in
>      Linux deployment with pacing that default-enabled the original Hystart
>      with L = infinity for all TCP connections using the
>      default congestion control module, CUBIC [RFC8312]."
>
> Or something similar that clearly says where the default was for the pacing?
>
> Gorry
>
>
>
>
>
>
>
>