Re: [tcpm] WG Last Call for ICMP Attacks

[Joe Touch <[e-mail]>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Some additional feedback:

- --
2.1 indicates reasons why ICMPs are not reliable; it should include
reasons why ICMPs could be late - so late that, e.g., sequence numbers
aren't relevant.
- --
In Sec 4.1:
   It should be note that as there are no timeliness for ICMP error
   messages, the TCP Sequence Number check described in this section
   might cause legitimate ICMP error messages to be discarded

This should also note that it is also possible to end up acting on ICMPs
that are old even when such checks are in place, depending on the
lateness of the ICMP and the width of the valid sequence number window.
- --
top Page 13, space is missing:
   synchronized states (ESTABLISHED, FIN-WAIT-1, FIN-WAIT-2, CLOSE-WAIT,
   CLOSING, LAST-ACK or TIME-WAIT)as "soft errors".  That is, they do
                                  ^
- --
Section 8 would benefit from a summary of the different techniques used
(e.g., parameter checking to drop ICMPs, state checking to drop ICMPs,
etc.) and a description of how each basic technique affects the system -
i.e., they (in general) make the system more robust to deliberate
attacks, but could make the system react less rapidly to legitimate
network errors. This is a deliberate trade-off, and perhaps a reasonable
one, but worth noting, IMO.

Joe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqm4swACgkQE5f5cImnZrt64QCfYfRuDcVPdClVjcpIxSyWd9IL
Q54AoMzxa0pGftaA8YcIODNmoLeipC2a
=BQ+x
-----END PGP SIGNATURE-----