Re: [tcpm] [Editorial Errata Reported] RFC5925 (5347)

Mirja Kühlewind <mirja.kuehlewind@tik.ee.ethz.ch> Wed, 05 September 2018 14:53 UTC

Return-Path: <mirja.kuehlewind@tik.ee.ethz.ch>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3D58130E52 for <tcpm@ietfa.amsl.com>; Wed, 5 Sep 2018 07:53:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XGltL-Djqxns for <tcpm@ietfa.amsl.com>; Wed, 5 Sep 2018 07:53:42 -0700 (PDT)
Received: from virgo01.ee.ethz.ch (virgo01.ee.ethz.ch [129.132.2.226]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C1DD130E3C for <tcpm@ietf.org>; Wed, 5 Sep 2018 07:53:42 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by virgo01.ee.ethz.ch (Postfix) with ESMTP id 4256CT0X25zMnjj; Wed, 5 Sep 2018 16:53:41 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at virgo01.ee.ethz.ch
Received: from virgo01.ee.ethz.ch ([127.0.0.1]) by localhost (virgo01.ee.ethz.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wCOuP46UuaBC; Wed, 5 Sep 2018 16:53:39 +0200 (CEST)
X-MtScore: NO score=0
Received: from [82.130.103.20] (nb-10688.ethz.ch [82.130.103.20]) by virgo01.ee.ethz.ch (Postfix) with ESMTPSA; Wed, 5 Sep 2018 16:53:39 +0200 (CEST)
To: Joe Touch <touch@strayalpha.com>, Ignacio Goyret <ignacio.goyret@nokia.com>
Cc: mankin@psg.com, rbonica@juniper.net, touch@isi.edu, tcpm@ietf.org, ietf@kuehlewind.net, spencerdawkins.ietf@gmail.com, tuexen@fh-muenster.de, RFC Errata System <rfc-editor@rfc-editor.org>
References: <20180503203252.D2005B82AA4@rfc-editor.org> <fcbc3182691fb2d763d4966b79a48591@strayalpha.com> <201805040027.w440R3ji011041@cliff.eng.ascend.com> <f210b12a-ca8d-4323-05b2-193cceb88669@strayalpha.com>
From: =?UTF-8?Q?Mirja_K=c3=bchlewind?= <mirja.kuehlewind@tik.ee.ethz.ch>
Message-ID: <518c945f-201d-3e20-4406-4135e182c6af@tik.ee.ethz.ch>
Date: Wed, 5 Sep 2018 16:53:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <f210b12a-ca8d-4323-05b2-193cceb88669@strayalpha.com>
Content-Type: multipart/mixed; boundary="------------78E34ACC84D16EF045482813"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/ORZbGZrQvv6vralS1lwTWYXjn_k>
X-Mailman-Approved-At: Wed, 05 Sep 2018 08:53:06 -0700
Subject: Re: [tcpm] [Editorial Errata Reported] RFC5925 (5347)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2018 14:53:56 -0000

Hi Joe, hi Ignacio,

is this something that I should set in the "Hold for Update" state?

Mirja



On 04.05.2018 03:54, Joe Touch wrote:
> 
> 
> On 5/3/2018 5:20 PM, Ignacio Goyret wrote:
>> The reason for the errata is because it happened: someone read
>> that text and interpreted that the tcp checksum would only need
>> to be cleared when only the TCP-AO option was included because the
>> text stated "when included, only the TCP-AO MAC field is zeroed".
>> Your suggested text addition does not address this incorrect
>> interpretation.
> It actually does directly, with this phrase: "within those options".
> 
>> I also encountered someone that insisted that when only the TCP-AO
>> option was included, that it was only the option data, not its header.
> That is already addressed in the existing text directly here:
> 
>    "When TCP options are not included, all TCP options except for TCP-
>    AO are omitted from MAC processing."
> 
> 
>> That's why a reference to section 2.2 sounds reasonable to me.
> Adding the reference might be useful, but should not be strictly
> necessary to interpret the existing text.
> 
>> IMO, this is *exactly* the reason for an "editorial" errata.
>> Technical details are not altered, just language clarifications
>> to promote interoperability. I am not suggesting rewriting this or
>> any other RFC.
> There are many RFCs that have been misinterpreted. That doesn't always
> warrant suggested alternate text.
> 
> Joe
> 
>>
>> -Ignacio
>>
>>
>> At 14:38 5/3/2018, Joe Touch wrote:
>>
>>> I do not agree that this is suggested text represents a clarification.
>>>
>>> At best, only the one sentence warrants clarification:
>>>
>>> From: When included, only the TCP-AO MAC field is zeroed.
>>>
>>> To: When TCP options are included, within those options only the TCP-AO MAC field is zeroed.
>>>
>>>
>>> However, that context is implicit in the existing text. Yes, we could completely rewrite every RFC to be more clear, but that is not the purpose of errata nor is it productive, IMO.
>>>
>>> Joe
>>>
>>> On 2018-05-03 16:32, RFC Errata System wrote:
>>>> The following errata report has been submitted for RFC5925,
>>>> "The TCP Authentication Option".
>>>>
>>>> --------------------------------------
>>>> You may review the report below and at:
>>>> <http://www.rfc-editor.org/errata/eid5347>http://www.rfc-editor.org/errata/eid5347
>>>>
>>>> --------------------------------------
>>>> Type: Editorial
>>>> Reported by: Ignacio Goyret <<mailto:ignacio.goyret@nokia.com>ignacio.goyret@nokia.com>
>>>>
>>>> Section: 5.1
>>>>
>>>> Original Text
>>>> -------------
>>>> 3. The TCP header, by default including options, and where the TCP
>>>>    checksum and TCP-AO MAC fields are set to zero, all in network-
>>>>    byte order.
>>>>
>>>>    The TCP option flag of the MKT indicates whether the TCP options
>>>>    are included in the MAC.  When included, only the TCP-AO MAC field
>>>>    is zeroed.
>>>>
>>>>    When TCP options are not included, all TCP options except for TCP-
>>>>    AO are omitted from MAC processing.  Again, the TCP-AO MAC field
>>>>    is zeroed for the MAC processing.
>>>>
>>>>
>>>> Corrected Text
>>>> --------------
>>>> 3. The TCP header and TCP options, where the TCP checksum and TCP-AO
>>>>    MAC fields are always set to zero, all in network-byte order.
>>>>
>>>>    The TCP option flag of the MKT indicates which TCP options are
>>>>    included in the MAC. When TCP options are not included, only the
>>>>    TCP option for TCP-AO (as described in Section 2.2) is included
>>>>    in the MAC. Otherwise, all the TCP options are included in the MAC.
>>>>
>>>>
>>>> Notes
>>>> -----
>>>> Rewording for clarity and simplification.
>>>> The original text could lead to confusion re '...When included, only the TCP-AO MAC field is zeroed.'
>>>>
>>>> Instructions:
>>>> -------------
>>>> This erratum is currently posted as "Reported". If necessary, please
>>>> use "Reply All" to discuss whether it should be verified or
>>>> rejected. When a decision is reached, the verifying party
>>>> can log in to change the status and edit the report, if necessary.
>>>>
>>>> --------------------------------------
>>>> RFC5925 (draft-ietf-tcpm-tcp-auth-opt-11)
>>>> --------------------------------------
>>>> Title               : The TCP Authentication Option
>>>> Publication Date    : June 2010
>>>> Author(s)           : J. Touch, A. Mankin, R. Bonica
>>>> Category            : PROPOSED STANDARD
>>>> Source              : TCP Maintenance and Minor Extensions
>>>> Area                : Transport
>>>> Stream              : IETF
>>>> Verifying Party     : IESG
> 
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm
>