Re: [tcpm] AD review of draft-ietf-tcpm-converters-14
<mohamed.boucadair@orange.com> Fri, 10 January 2020 15:38 UTC
Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE03512006B; Fri, 10 Jan 2020 07:38:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sxDD-MneLhji; Fri, 10 Jan 2020 07:38:05 -0800 (PST)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.34]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3405F120048; Fri, 10 Jan 2020 07:38:05 -0800 (PST)
Received: from opfednr07.francetelecom.fr (unknown [xx.xx.xx.71]) by opfednr20.francetelecom.fr (ESMTP service) with ESMTP id 47vRvb5J4kz1y9C; Fri, 10 Jan 2020 16:38:03 +0100 (CET)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.35]) by opfednr07.francetelecom.fr (ESMTP service) with ESMTP id 47vRvb4cbzzFpWV; Fri, 10 Jan 2020 16:38:03 +0100 (CET)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBM6C.corporate.adroot.infra.ftgroup ([fe80::f58e:8e9d:ae18:b9e3%21]) with mapi id 14.03.0468.000; Fri, 10 Jan 2020 16:38:03 +0100
From: mohamed.boucadair@orange.com
To: Mirja Kuehlewind <ietf@kuehlewind.net>, "draft-ietf-tcpm-converters.all@ietf.org" <draft-ietf-tcpm-converters.all@ietf.org>
CC: tcpm IETF list <tcpm@ietf.org>
Thread-Topic: AD review of draft-ietf-tcpm-converters-14
Thread-Index: AQHVx8T3k0Q2q/9dJU+VDQF+wEx0IKfkBc6g
Date: Fri, 10 Jan 2020 15:38:03 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B933031407777@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <4DF47B41-2A8F-4FC1-8734-4D133F3EBBE5@kuehlewind.net> <52F7B691-AB5F-4C63-BC8D-CFB5E569D085@kuehlewind.net>
In-Reply-To: <52F7B691-AB5F-4C63-BC8D-CFB5E569D085@kuehlewind.net>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/TQwSTDVzGxPH6trFWMpWJ356E1c>
Subject: Re: [tcpm] AD review of draft-ietf-tcpm-converters-14
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2020 15:38:07 -0000
Hi Mirja, Thank you for detailed review (as usual!). We will get back to you ASAP. Please see inline. Cheers, Med > -----Message d'origine----- > De : Mirja Kuehlewind [mailto:ietf@kuehlewind.net] > Envoyé : vendredi 10 janvier 2020 15:48 > À : draft-ietf-tcpm-converters.all@ietf.org > Cc : tcpm IETF list > Objet : Re: AD review of draft-ietf-tcpm-converters-14 > > Hi again, > > Of course if have more question/comments. However these are easy ones: > one nit, and two question about why the text is in the appendix :-) > > One more thought: Looking at the SOCKS6 document again, I think what you > have defined here, can actually be seen as a light-weight SOCKS. I think > that’s fine but maybe it would be better to acknowledge it this way…? > There will also be reviews by the INT ADs in IESG Evaluation and I don’t > think this has been otherwise reviewed by any INT area working group > yet, right? > > After all thanks for a well-written document and also for the good > shepherd write-up! > > Mirja > > > > -------------------- > 1) Appendix B.1: > " o 0x4: (client) send data in the opening SYN regardless of cookie > availability and without a cookie option. > > By setting this configuration variable to 0x5, a Linux client using > the above code would send data inside the SYN without using a TFO > option.” > 0x4 or 0x5 ? > [Med] 0x5 is correct because these are bitmap values. > 2) This is fully editorial, but given appendix C is really short, I > think this could have also be just be place somewhere in the body of the > document like e.g. in section 5.2.7 or the intro text in section 5. [Med] Works for me. > > 3) Further I also don’t fully see why appendix D is in the appendix. I > think most of this is mentioned in the body of the document already but > in less detail which makes it actually harder to understand (in think I > had at least one question to this below). I think having this text as > subsections in 3.3. would actually be helpful to understand the usage > better. > [Med] We put it there because we thought this is getting down into deployment options/considerations. We can move it to the main text if we maintain the same level of details. Hope this is OK with you.
- [tcpm] AD review of draft-ietf-tcpm-converters-14 Mirja Kuehlewind
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… Mirja Kuehlewind
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… mohamed.boucadair
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… mohamed.boucadair
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… Mirja Kuehlewind
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… Olivier Bonaventure
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… Mirja Kühlewind (IETF)
- Re: [tcpm] AD review of draft-ietf-tcpm-converter… Scharf, Michael