Re: [Teas] I-D Action: draft-ietf-teas-ietf-network-slice-nbi-yang-06.txt

[[e-mail]]

Hi all, 

Thanks for the continued effort on this spec. 

I submitted right now some edits/nits via https://github.com/lana-wu/ietf-ns-nbi/pull/54/files and https://github.com/lana-wu/ietf-ns-nbi/pull/57/files. Not sure though if that repo is where you maintain the latest version of the spec. BTW, please update the additional resources to point to the github repo.

I need to review more in detail the updated version, but please find some quick comments on this version:

* As a pointer to an ac-svc-name is supported, and given that some parameters may be redundant between what is provisioned as part of the ac-svc vs directly included in nssm, I suggest that some text is included to indicate that when parameter overlapping is included in a request, the ac-svc-name takes precedence. The rationale is that an ac can support many services and it is safe to control ac-related parameters as part of the procedure of managing the ac-svc-name.

* I suggest to define typedefs for the leafrefs you have in the module. This will also ease referencing in future extensions.

* For all "unique identifiers", please indicate the scope under which an identifier is intended to be unique.

* Many items in the module (identities, etc.) lack a clear description. Some of them do not even have a description. 

* I suggest to remove I-D.liu-teas-transport-network-slice-yang from the draft, especially that the scope of this I-D is still not clear.
 
* For items such as (leaf incoming-bw-value { type te-types:te-bandwidth;), please check this is the right type to use. I was expecting a gauge value, rather than what you have currently in the model. 

* BTW, we used to have similar (inbound/outbound) prefixes in L3SM, but there were comments from implementers that this is confusing. This is why LxN abandoned those prefixes and went for 

            +--rw pe-to-ce-bandwidth?   uint64 {vpn-common:inbound-bw}?
            +--rw ce-to-pe-bandwidth?   uint64 {vpn-common:outbound-bw}?

Using explicit names would be useful here as well. 

* Please use reference and unit statements instead of having those in the description. 

* For '*-qos-policy' (which is btw more about BW), the model does not allow to control the bw per QoS class, port, etc. (RFC9181)

In order to ease mapping the NSSM with the AC/L2NM/etc., it would make sense to align with the following structure:

                +--rw svc-pe-to-ce-bandwidth {vpn-common:inbound-bw}?
                |  +--rw bandwidth* [bw-type]
                |     +--rw bw-type      identityref
                |     +--rw (type)?
                |        +--:(per-cos)
                |        |  +--rw cos* [cos-id]
                |        |     +--rw cos-id    uint8
                |        |     +--rw cir?      uint64
                |        |     +--rw cbs?      uint64
                |        |     +--rw eir?      uint64
                |        |     +--rw ebs?      uint64
                |        |     +--rw pir?      uint64
                |        |     +--rw pbs?      uint64
                |        +--:(other)
                |           +--rw cir?   uint64
                |           +--rw cbs?   uint64


Cheers,
Med

> -----Message d'origine-----
> De : I-D-Announce <[e-mail]> De la part de
> [e-mail]
> Envoyé : lundi 10 juillet 2023 14:38
> À : [e-mail]
> Cc : [e-mail]
> Objet : I-D Action: draft-ietf-teas-ietf-network-slice-nbi-yang-
> 06.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories. This Internet-Draft is a work item of the Traffic
> Engineering Architecture and Signaling (TEAS) WG of the IETF.
> 
>    Title           : A YANG Data Model for the IETF Network Slice
> Service
>    Authors         : Bo Wu
>                      Dhruv Dhody
>                      Reza Rokui
>                      Tarek Saad
>                      Liuyan Han
>                      John Mullooly
>    Filename        : draft-ietf-teas-ietf-network-slice-nbi-yang-
> 06.txt
>    Pages           : 107
>    Date            : 2023-07-10
> 
> Abstract:
>    This document defines a YANG data model for the IETF Network
> Slice
>    Service.  The model can be used in the IETF Network Slice
> Service
>    interface between a customer and a provider that offers IETF
> Network
>    Slices.
> 
> The IETF datatracker status page for this Internet-Draft is:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> datatracker.ietf.org%2Fdoc%2Fdraft-ietf-teas-ietf-network-slice-
> nbi-
> yang%2F&data=05%7C01%7Cmohamed.boucadair%40orange.com%7Cd99428bcc6
> f04e4d10e808db8142a3d8%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%
> 7C638245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdat
> a=GdwcH5Z3icSKDdygMb2fIdXaCJeTpb5IV1qbUCIG%2By8%3D&reserved=0
> 
> There is also an htmlized version available at:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> datatracker.ietf.org%2Fdoc%2Fhtml%2Fdraft-ietf-teas-ietf-network-
> slice-nbi-yang-
> 06&data=05%7C01%7Cmohamed.boucadair%40orange.com%7Cd99428bcc6f04e4
> d10e808db8142a3d8%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638
> 245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2F
> f0C5F8u9tHSMY2vGLm2t%2BKIqteDQB%2FBa0IeuaA1%2Bf4%3D&reserved=0
> 
> A diff from the previous version is available at:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> author-tools.ietf.org%2Fiddiff%3Furl2%3Ddraft-ietf-teas-ietf-
> network-slice-nbi-yang-
> 06&data=05%7C01%7Cmohamed.boucadair%40orange.com%7Cd99428bcc6f04e4
> d10e808db8142a3d8%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638
> 245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ltI
> IwBf0dfDNpMfYscNYYMiCHpOjfhArVaf9aFmLvD4%3D&reserved=0
> 
> Internet-Drafts are also available by rsync at
> rsync.ietf.org::internet-drafts
> 
> 
> _______________________________________________
> I-D-Announce mailing list
> [e-mail]
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> www.ietf.org%2Fmailman%2Flistinfo%2Fi-d-
> announce&data=05%7C01%7Cmohamed.boucadair%40orange.com%7Cd99428bcc
> 6f04e4d10e808db8142a3d8%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0
> %7C638245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda
> ta=FtIAMu5eF46Et%2FJX16mBxBGCP6%2FPt6KwBvi2cKe%2Fkvs%3D&reserved=0
> Internet-Draft directories:
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
> ww.ietf.org%2Fshadow.html&data=05%7C01%7Cmohamed.boucadair%40orang
> e.com%7Cd99428bcc6f04e4d10e808db8142a3d8%7C90c7a20af34b40bfbc48b92
> 53b6f5d20%7C0%7C0%7C638245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&sdata=uTjmsyFknYKxwI3GZsn7s8Uz%2BNJ0JPnC4Irwdcr%2Bkd
> g%3D&reserved=0
> or
> https://eur03.safelinks.protection.outlook.com/?url=ftp%3A%2F%2Fft
> p.ietf.org%2Fietf%2F1shadow-
> sites.txt&data=05%7C01%7Cmohamed.boucadair%40orange.com%7Cd99428bc
> c6f04e4d10e808db8142a3d8%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C
> 0%7C638245895435168168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
> iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
> ata=w%2BYsFlIyflcmN5F7IVlPLYfQhsHqRGDipggO8blrQMs%3D&reserved=0
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.