Re: [Teas] 2nd WG Last Call: draft-ietf-teas-yang-te-34

[Italo Busi <[e-mail]>]

Hi all,

Please find below my WG LC comments (mainly editorial):

1) The draft has dependency on draft-ietf-teas-rfc8776-update: the normative reference to RFC8876 should be replaced with a normative reference to draft-ietf-teas-rfc8776-update

2) The description of the secondary-reverse-path in the list of candidate-secondary-reverse-path should be updated as follow:

OLD
                     description 
                       "A reference to the reverse secondary path when 
                        co-routed with the secondary path.";
NEW
                    description
                      "A reference to the secondary reverse path that
                       may be utilized when the containing primary
                       reverse path is in use.";

See: https://github.com/tsaad-dev/te/issues/231

3) The description of the secondary-reverse-path in the container secondary-paths should be updated as follows:

OLD
              description
                "A reference to the secondary reverse path that
                 may be utilised when the secondary path is in use.";
NEW
           description
             "A reference to the reverse secondary path when 
             co-routed with the secondary path.";

See: https://github.com/tsaad-dev/te/issues/231

4) The comment about the need to add support for path loss and delay variation metrics has not been completely addressed

My proposed resolution would be to:

a) Move path loss metric to te-packet-types (in draft-ietf-teas-rfc8776-update)
b) Add path delay variation metric to te-packet-types (in draft-ietf-teas-rfc8776-update)
c) Move clarification that the unit of path metric bound is interpreted in the context of the metric-type from this draft to draft-ietf-teas-rfc8776-update

OLD
    uses te-types:common-path-constraints-attributes {
      description
        "The constraints applicable to the path. This includes:
         - The path bandwidth constraint
         - The path link protection type constraint
         - The path setup/hold priority constraint
         - path signaling type constraint
         - path metric bounds constraint. The unit of path metric
           bound is interpreted in the context of the metric-type.
           For example for metric-type 'path-metric-loss', the bound
           is multiples of the basic unit 0.000003% as described
           in RFC7471 for OSPF, and RFC8570 for ISIS.
         - path affinity constraints
         - path SRLG constraints";

    }
NEW
    uses te-types:common-path-constraints-attributes;

See: https://github.com/tsaad-dev/te/issues/103

Thanks, Italo

> -----Original Message-----
> From: Lou Berger <[e-mail]>
> Sent: lunedì 16 ottobre 2023 23:41
> To: TEAS WG <[e-mail]>
> Cc: TEAS WG Chairs <[e-mail]>
> Subject: [Teas] 2nd WG Last Call: draft-ietf-teas-yang-te-34
> 
> All,
> 
> This starts the 2nd working group last call on
> https://datatracker.ietf.org/doc/draft-ietf-teas-yang-te/
> 
> Given the size of the document and the upcoming meeting, this will be an
> extended LC. The working group last call ends on November 3rd.
> Please send your comments to the working group mailing list.
> 
> Positive comments, e.g., "I've reviewed this document and believe it is ready
> for publication", are welcome!
> This is useful and important, even from authors.
> 
> Thank you,
> Lou (Co-Chair & doc Shepherd)
> 
> PS Note that another IPR call is being started and will run in parallel with the
> last call.  The last IPR call reported no IPR.
>