Re: [Teas] Yangdoctors early review of draft-ietf-teas-yang-path-computation-11

tom petch <ietfa@btconnect.com> Wed, 24 February 2021 10:23 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 049F53A1353; Wed, 24 Feb 2021 02:23:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ao_tqGSFDVQQ; Wed, 24 Feb 2021 02:23:44 -0800 (PST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40116.outbound.protection.outlook.com [40.107.4.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D90C63A1355; Wed, 24 Feb 2021 02:23:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYil5XoMkOzrILCYFLLLXPzY5M93AxDAz1veQ4CeQyBJLpckZipYas3qRULeaaIc3LqYyem1SDAJ5MyUjWcpUnWrr0E4TvDTIBD8y0CBKzGJYufVwneBLbjNG5bYLLcHH3mkEqzAj27nKLESigjqi0tzC0ETUQGfy4OziWYr8V/RimpaSUHYxXai5Pscb8yIYodCwCigz9KtWgKLP4BvzH8vLRXUsXGpxksWV/fVLsgHsazxpV42a1uJ0WK+469l0f9wezHIw17asg6KXdM1RNgLqsWVjNaUBEXZc7fmto6kx3Wvpa9I5EGYKRprln3G5iWHpkJqirwUa5w29wXPiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pB+BCISLuIOmtF2pDxEtxHhIxqIiTgfDVRo1c9Gr08=; b=Q71c9XyjfuQOySJ5JOR4Dn4ucyYo7xiv51mtPyPId+YcIj1EvLv6AJtCcXAf1KMK1vc5/7v1ITDUaZKdNfZurzATvmW1B8vh+PX8Bqm8V9W6iC+in23gso0Ahcs0w7xxFtU5k8bhGdxp79dZKmQ7N68hiKA72DNeq6NuMHOOWIGsagJbHk0wuOZKC/ZSyykn7LE2ufnvoXdlSUykYdW2eVlb2cAQj0kSVuZ9IsxSoW86mV2mySyRyewYgpRgi4Et08W5aB5udzwjxoF/Bj3Dfghw9MVw5scz/Mq4JgqL41QCVJq14U0NUYXKS4C0e9dqdwGk8HXdKHvfX2tFe32daA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pB+BCISLuIOmtF2pDxEtxHhIxqIiTgfDVRo1c9Gr08=; b=Kt5q9BAR82+BRl7QRzSelf8nwNArApPuvqEr16DmoL17lPxCQLw7QDkX6vKOHEqkBeWuzQubrC9w5/neSVpZRRzNDoaf+n1mlsdN+iVlN+b9wpa3uytdcpwDhzi3NnnDIr5M50T+U7kgRjFQiiXk3ZUJp8vdoF/qyjCFsJyFNME=
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23) by DB8PR07MB6345.eurprd07.prod.outlook.com (2603:10a6:10:137::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.11; Wed, 24 Feb 2021 10:23:41 +0000
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e079:baec:373c:824f]) by DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e079:baec:373c:824f%7]) with mapi id 15.20.3890.014; Wed, 24 Feb 2021 10:23:41 +0000
From: tom petch <ietfa@btconnect.com>
To: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, =?iso-8859-1?Q?Martin_Bj=F6rklund?= <mbj+ietf@4668.se>
CC: "draft-ietf-teas-yang-path-computation.all@ietf.org" <draft-ietf-teas-yang-path-computation.all@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] Yangdoctors early review of draft-ietf-teas-yang-path-computation-11
Thread-Index: AQHW1KanJVtlWmVVc0Sw2jlX0eRzR6png5hj
Date: Wed, 24 Feb 2021 10:23:41 +0000
Message-ID: <DB7PR07MB5546474ADCC583030EFDF7BEA29F9@DB7PR07MB5546.eurprd07.prod.outlook.com>
References: <160823152245.15025.13731491639863650578@ietfa.amsl.com>
In-Reply-To: <160823152245.15025.13731491639863650578@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
x-originating-ip: [86.146.121.140]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 83a9e0e5-6a27-4f10-2b24-08d8d8ae41bf
x-ms-traffictypediagnostic: DB8PR07MB6345:
x-ms-exchange-minimumurldomainage: ietf.org#9482
x-microsoft-antispam-prvs: <DB8PR07MB6345B5F0E3249C4960A6F737A29F9@DB8PR07MB6345.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: k1cOiazGKYb9D8f6Xg92MmLkPZN9pPFkSYFiHk+F1GCJYkItvlpEDOzHlSYeeLyyhojvWgCo/H7CB0tAzZgeirSkNl7zqRuj3pbNv/tT/yOtS2EGfCnzLIUTUEEc11skGW+svQKRSlJ/+Pi0GTnvgevgXqTUEifUegVCL6RMEh0CO0vP3Mi3wDA1WRaYOyXTmmo66zCwZesXyouD7OCYQ36/VS4D2vCJbINrTBbfVE5mcW+4iFRDDOWFFG1ncOCsBuPcidBfqU1gDTKzLryDRk0cRpdQRcf4k6UsfmpDEF9esJi3mtHCM5QRz1PurndlEYZntVhioHubWz8y0/cHC9ZatOAVBoCwFgiCgVH16OjIAVn8SloAtEYJXfQ1tBgpYlqOgU/0OragTG6Lw85Qb/neqZiVC59xOh83EgE5k0yiPeoPKV8g2DC63/zoSzmm3C8U7krQtLsWa22++WLfrwyWtNFomwE6Do7BNy5MeEaSMhQ5gQpm88siVm2pwO1T7L1dRCDR66Rn4CXEnLFVcU8COAXoamJpv4eDKYAF2OhX4W/89EvdeX/Rh/N5IxTfeej1gj769FDrHjujhj90XB55uUtb26tvzVy6tNGO/g0=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR07MB5546.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(366004)(376002)(39860400002)(136003)(8936002)(83380400001)(26005)(55016002)(86362001)(6506007)(966005)(66946007)(52536014)(33656002)(71200400001)(54906003)(76116006)(9686003)(64756008)(8676002)(186003)(4326008)(66556008)(2906002)(66476007)(5660300002)(478600001)(91956017)(66574015)(316002)(110136005)(66446008)(7696005); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?dl8IuEyMK9nZOdGmdHIwDnl1pvabvL2rglmTJfpejnLaojMtvoaG7C8Jo6?= =?iso-8859-1?Q?FoEfXuuKn678m0b4oLIt9s5PwJHjzCZ8JJLHhj413DEiXc608eVgV8Ktx/?= =?iso-8859-1?Q?QvuHTsJaZvlCu+7LszGnvW1ll+Y4GwgY/f+8rqMrJOPptvaXh8CH3O1YqO?= =?iso-8859-1?Q?sYLl6tOCETUc5iXCTE3FVvcl/fJabxBNgpL71sIfoEH29xWbrcTLXHd05v?= =?iso-8859-1?Q?EP2DMHwkwlrKjqweZq291B95h3gp15Qktjn9cU+qYOVcwZIsv1AZw0QzVk?= =?iso-8859-1?Q?wvtKfV09nxhZmfRlQQg+y9PapFyLNSsi34Ud5bx4k+d6k/D2tbBecLTUCU?= =?iso-8859-1?Q?e15AY/mcTPfoDIHgznaqmF5MqissDdn4vZO41aDR3zT1lzI2Vu/IVWyAe5?= =?iso-8859-1?Q?Nn2r7BWhIs9U6ULXD4BZlCIAMFPA6toujWKrPZ0aHtEXuY5vj0F2icnMTU?= =?iso-8859-1?Q?Kshx6CbUa9DzFuN4aWYi6vVr7k+R8mpp/SFq+ZsqYHlK8Yq40228pilmdi?= =?iso-8859-1?Q?7o1dUUTZgWTfE9uXswF2otW+Plb9SYjPcCvRWoJDji9lrmMtC8W28pmCW2?= =?iso-8859-1?Q?OWPUH0PGBHWYCbEEHjI0N1IKifn4T8ZNypKYDnV0PCUz9Ve/6R7lrf/imX?= =?iso-8859-1?Q?OcwQoZpIqqFL/x3i9zoVynAYYOpT6jRC9e61q41Rwp8MNqnAq4wJTYno2h?= =?iso-8859-1?Q?FhKMnPAAOs2g60bOR6z2OfFEPYqN+DeaB0Kg17+7E33xn3HId6kr5ULs5Y?= =?iso-8859-1?Q?kRluHwVrhuJJ46mhbwsAOWHqgQHRwD0To9ykSyY200ZlsM8dLwuWu4CTei?= =?iso-8859-1?Q?9foYVRFwipPjnrCQGeT0Hw/t8+PPwdNfpJK12DZd+u/NRFttp3acHRLc/V?= =?iso-8859-1?Q?ErJ0DJVBE7j33eo1Kefn9h0EcFKIi1QaxT4P9osGscDyzLouXhQkcy73LQ?= =?iso-8859-1?Q?OpwS9V5/n9ac4GklHVD2DoZqHz9d7R11JkEahtxbb5/SnuWHB3i+dkdtmS?= =?iso-8859-1?Q?gMxhNDNGVXeu3VG0uQ7aysfhskF6eUs0oibSyY+7UsAHMSO70PVLAQzcrI?= =?iso-8859-1?Q?JvTp/xm0jpbg/S2nJkRsdL9hwoCJr4QigrHij8kZKG8MXNNlPEGvYdjdzB?= =?iso-8859-1?Q?rV3m+chXmSfSDc9XkzUtCmBHO40/u2xvtdSoQQAcZn1WZKJyHYU+fgalw/?= =?iso-8859-1?Q?4AGKUvX2mPg8qxp9WYPV/ybSCijDQCkzLV34+xeHdpm9MSMXMYZSEmWPPT?= =?iso-8859-1?Q?ajaGSVA8Vw3BHBJor5PxW2sgz0M4bzgwbuBr+wY2sVjyWPJqA8U6X/MHo5?= =?iso-8859-1?Q?+l3UrUJHMz2bIiYl3ZuY1MFZjo+uzw+Tq1CiRCESz3owXg4=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB7PR07MB5546.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83a9e0e5-6a27-4f10-2b24-08d8d8ae41bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 10:23:41.0552 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KHPy+9C0nPBKRizNOrn7HZ6A/xyUSd7hVDhA/2p4WpSAr/urmsdZmgjhDuQ42iWOyzbiqXiqtOBWak07FhPwSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR07MB6345
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/JnFSM-WwSBZrbNvrpVkYpLvwrgI>
Subject: Re: [Teas] Yangdoctors early review of draft-ietf-teas-yang-path-computation-11
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2021 10:23:48 -0000

From: Teas <teas-bounces@ietf.org> on behalf of Martin Björklund via Datatracker <noreply@ietf.org>
Sent: 17 December 2020 18:58

Reviewer: Martin Björklund
Review result: Ready with Nits

<tp>

Martin's review flagged an error in the ietf-te module whereby a path statement lacked prefixes causing validation to fail  That module is updated in teas-yang-te-26 to add those missing prefix which may overcome  that issue.

Tom Petch

o  General

  The language is called "YANG", not "Yang".


o  1.2. Tree Diagram

  The text says:

    A simplified graphical representation of the data model is used in
    section 6.1 of this this document.  The meaning of the symbols in
    these diagrams is defined in [RFC8340].

  Tree diagrams are used also in chapter 5.  I suggest:

    Tree diagrams used in this document follow the notation defined in
    [RFC8340].


o  Tree diagrams in general

   You can use pyang -f tree --tree-line-length 68 ... in order to
   avoid long lines in the RFC.


o  6.1

  This section presents a fully expanded tree diagram of the module.
  Tree diagrams are mainly used to give an overview of a module's
  structure.  The tree diagram in this section spans 13 pages and is
  quite hard to read.

  I also note that a majority of the nodes in this tree diagram come
  from the expansion of groupings that aren't defined in this
  document.  Hence, I suggest that you might want to run:

    pyang -f tree --tree-line-length 68 \
      --tree-print-groupings --tree-no-expand-uses


o  There are a number of groupings that are used only once, and do not
   seem to be defined to be reused by other modules, e.g.,
   "requested-info", "requested-state", "svec-metrics-bounds" and more.

   If they are intended to be reused, it should be made clear in their
   description statements.  If not, I think they should be inlined and
   removed.


o  grouping svec-exclude

   This grouping has an ordered-by user list.  Why is this list user
   ordered?  If the order matters, it should be explained how it matters.

   Also, the index leaf has this description:

     "XRO subobject index"

   What is "XRO"?  Is this description sufficiently clear?


o  path-request

   In the path-request, there is construct for path-refs:

                   list primary-reverse-path-ref {
                     key index;
                     min-elements 1;
                     description
                       "The list of primary reverse paths that
                        reference this path as a candidate
                        secondary reverse path";
                     leaf index {
                       type uint32;
                       description
                         "The index used by the
                          primary-reverse-path-ref list";
                     }


  What is this index?  Is it only used as an arbitrary index, or
  something else?  If it is an arbitraty index, it should be explained
  in the descriptions.

  Also note that lists in rpc input don't need an index.


o  Validation

   The module fails YANG validation, but that is really due to errors
   in ietf-te@2020-07-12.yang.  Specifially, the leafref in the
   grouping "path-compute-info" must have prefixes in its path.
   Without prefixes, the path refers to nodes in the module that uses
   the grouping.  (same for other groupings in that module).


o  Layout

  I suggest you run the module through

    pyang -f yang --yang-canonical --yang-line-length 68

  in order to have the module indented and formatted consistently.

  This will make the RFC editor's job easier.



/martin



_______________________________________________
Teas mailing list
Teas@ietf.org
https://www.ietf.org/mailman/listinfo/teas