[Teas] draft-ietf-teas-yang-path-computation-28 early Rtgdir review

[Sue Hares via Datatracker <[e-mail]>]

Document: draft-ietf-teas-yang-path-computation
Title: A YANG Data Model for requesting path computation
Reviewer: Sue Hares
Review result: Has Nits

This is an early review for draft-ietf-teas-yang-path-computation-28.txt.
Reviewer: Susan Hares 
Caveat: I am not a yang doctor. I have not implemented or operated 
code that uses this model. 

Summary: Ready with NITS 
Excellent technical work that is logically consistent with previous work. 
Thank you to authors for excellent work! 

What is covered in this early review: Technical concepts, logical consistency, and yang concept
What is not covered in this review:
1) detailed editorial review of sentence grammar - tools 
2) detailed yang grammar - hopefully the Yang tools 

I did note two things editorial in passing: 
section 1.2 - PCE definition phrase "on an out-of-network-server, etc"
seems to be confusing.  Please check against PCE RFCs. 

Yang text: Does not seem to have complete sentences with periods in all descriptions. 

NITS: 
issue 1:  section 5.3, tunnel attribute list, binary type for 2 variables 

why are are these two variables binary? It is unclear from the text why these
two variables are binary.  A sentence on why these are binary would be helpful. 
I suspect it is to indicate wheter you are using source and destination - respectively. 

+--src-tunnel-tp-id  binary 
+--dst-tunnel-tp-id  binary

Issue 2: use of choice path-role in Yang statement 

It is not clear why you are using the yang form 
"choice path-role {
    When 'not (./source) and (.destination)'{
	
I think it is because you tried to do something in section 5.3. 
This tries to implement the constraint you are placing in the 
description in issue 1.  I'm just not sure if this is logically correct or 
incorrect.  Please add text explaining it for issue 1. 
Plesae double check this yang "when" statement. 

Issue 3: Augmentation of RPC filter types 

The augmentation of: 

Augment "/te: tunnels-actions/te:input/te:tunnel-info/" + "te:filter-ty pe"

uses a when statement of 
"when "derived-from-or-self"(../te:action-info:/te:action,"
     +"'tunnel-acitonm-path-comput-delete"

I think you are trying to add a path-delete function to the path-compute-delete group. 
I do not know if this correct. 

Issue 4: Security section 

It is not clear if you should be specifying some additional NACM handling and 
datastorage for the information you have identified as sensitivie. 
Is sensitive equivalent to network "critical information?"