Re: [Teas] Yangdoctors early review of draft-ietf-teas-sf-aware-topo-model-08

Xufeng Liu <xufeng.liu.ietf@gmail.com> Fri, 18 March 2022 23:08 UTC

Return-Path: <xufeng.liu.ietf@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B2363A12E4; Fri, 18 Mar 2022 16:08:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sw8W4LKcF3_6; Fri, 18 Mar 2022 16:08:08 -0700 (PDT)
Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 828213A12DA; Fri, 18 Mar 2022 16:08:05 -0700 (PDT)
Received: by mail-vs1-xe31.google.com with SMTP id 62so8216876vsx.0; Fri, 18 Mar 2022 16:08:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y+wfbbq2ltRrFer69piwBzBsBUlrvJ4AAMl4qPgXBek=; b=lhd4SXTjkternBYZSByQZQtWbUJXoD3MuWvyDQ4cO4pOCPMgWBB3m0d+Ep/fEHCyYh feRNojLxuAe9vXrQYAHeM8zrTucXP7/nTfK1ZixnHWH9SntaW4pA3JndikTAppBsQK7z 6VCBoiAYN1v9V5FrP5ri+wxvrJ6Zg3p83850O8E4VvUXneuhA6d+uRrbSVEtm2SpCFWz 6sEuZcgekffQ/7gBGYZKZNwGwZEQAiwNyZ0HwEiQQWS9ZHVcVlaX1qRjKcCcQm2smOqO nJ/WhCovspQz3W3mtIjJ0WdNd+Pbu0Z048w66MFeaR9N06yhNm3NN/hSjdTWhrYG6apv SE0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y+wfbbq2ltRrFer69piwBzBsBUlrvJ4AAMl4qPgXBek=; b=BejpBzQKbSb42ksgRLW9y18CEvLmYmuQnLRv1IQkXKqRGaAgAaNEQnasHJ1zDVBzbx J7yVfWEjrS9k6Hw6gh2Mi5/GDD6NV1WIQThzqPe7F5Sw+Tk9ietvx8EtvBDlhYHxKAx6 c1XU9fFpzKwrTS+brY99Q9g9gNcy/eCIVEUjAmf8eqsxr0+SzqjpDaAvkYDhTt441dp2 ymHZq2ScyMt/A+lHblNq2nW/u9k0m6PbT7PoIl0LuDw0HqZmKzu16HaykPt3tGsIW/sl 9oSHVHgEsr43QSKvoIFs3/rD/U0WbU3FC4U1x/kIK45ddT3ZlzFGffgC8k7XMrytJrZm g2rg==
X-Gm-Message-State: AOAM531Of5NkG6rOIQs9sHyqSNr1K8pkZARycUq4mZ3ntiYmtX5AbInx 4twPbgJ9dTM+62LnWXkrnSV38nIInke4utevnv8Wz9I9cBY=
X-Google-Smtp-Source: ABdhPJydCTa5g9TOh4vqWdxal/ufJfGnItkoeAgNR5DUIqYIgJsJ5S95nknaxwJpdnigRK48PTgzD88DuK/affGu/Uo=
X-Received: by 2002:a67:b14a:0:b0:324:c014:d98e with SMTP id z10-20020a67b14a000000b00324c014d98emr4677818vsl.19.1647644883881; Fri, 18 Mar 2022 16:08:03 -0700 (PDT)
MIME-Version: 1.0
References: <163951504060.716.5402845840042613349@ietfa.amsl.com>
In-Reply-To: <163951504060.716.5402845840042613349@ietfa.amsl.com>
From: Xufeng Liu <xufeng.liu.ietf@gmail.com>
Date: Fri, 18 Mar 2022 19:07:52 -0400
Message-ID: <CAEz6PPT8imYEZ5rQsw-YxMNgwugx4s3yr60OCmqNxmMJ+Y2AMg@mail.gmail.com>
To: Andy Bierman <andy@yumaworks.com>
Cc: yang-doctors@ietf.org, draft-ietf-teas-sf-aware-topo-model.all@ietf.org, TEAS WG <teas@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000005108d05da86382f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/Ta5XYzdBmCSRdh5gdRVeDy7MA_A>
Subject: Re: [Teas] Yangdoctors early review of draft-ietf-teas-sf-aware-topo-model-08
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Mar 2022 23:08:14 -0000

Hi Andy,

Thanks a lot for the review and comments. We have posted an updated
revision
https://datatracker.ietf.org/doc/html/draft-ietf-teas-sf-aware-topo-model-09,
trying to address the comments, with some explanations below in-line.

Thanks,
- Xufeng

On Tue, Dec 14, 2021 at 3:50 PM Andy Bierman via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Andy Bierman
> Review result: Ready with Issues
>
>
> Draft:    draft-ietf-teas-sf-aware-topo-model-08.txt
> Module:   ietf-te-topology-sf
> Revision: 2021-06-28
>
>
> General:
>
> This document is well written and understandable, even though
> the topic is complex.
>
>
> Issues:
>
> 1)
> Not clear why
> information-source-entry/service-function/link-terminations/link-termination/from
> is just an empty NP-container. Description says "Reference to the link
> termination point.";
> Not clear how this empty NP-container is a reference to anything.

[Xufeng]: Thanks for pointing this out. A leaf was mistakenly missing.
Fixed.

>
> 2)
> The "service-function-id" and "sf-connection-point-id" leafs are each used
> in 4 places.
> Perhaps use groupings instead of cut-and-paste?
>
[Xufeng]: Right. A grouping is better, and added.


> The type is a plain string. Is this really what is desired?
> It is not clear if these leafs are administrative labels or real linkage.
> The description is (e.g.) "Reference to a network service or a network
> function."
> This implies some linkage to another YANG object somewhere, but no mention
> of any
> such objects. Should this be a leafref to a specific node (or union of
> leafrefs
> to multiple objects)?
>
[Xufeng]: Fixed by using leafref statements.

>
> 3)
> The service-function key (id) is also a plain string.
> Should the type "yang-identifier" be used instead?
> Or maybe a different common type.  Is is not unusual to limit the length
> of string identifiers provided by a client.  Obvious;y a server can
> return a "too-big" error but it might be useful to pick a length
> every server must support (e.g. 1..64).
>
[Xufeng]: Such IDs are not defined within IETF. The usually accepted
definition is from ETSI (
https://www.etsi.org/deliver/etsi_gs/NFV-IFA/001_099/007/03.05.01_60/gs_NFV-IFA007v030501p.pdf)
There are multiple existing data models, which may be YANG, or TOSCA, or
others. We are not trying to limit the service-function implementation to a
particular model, so a service-function model is not referenced here. ETSI
does not impose any restriction on the format and length, so this topic was
discussed and the type string was chosen.

>
>
> Module:   ietf-te-topology-sf-state
> Revision: 2021-06-28
>
> This is a non-NMDA version of the ietf-te-topology-sf module.
> It appears to completely correct and no new issues exist.
>
> (There should be a YANG extension to tell compilers and other tools
> that module foo-state is really the non-NMDA variant of foo, and
> not just a different module with a name that matches a common pattern.
> Not an issue for this draft.)
>
>
>
>
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
<#m_-7613731194565471283_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>