Re: [Teas] "admin-group" in draft-ietf-teas-yang-te-04

"Tarek Saad (tsaad)" <tsaad@cisco.com> Tue, 27 September 2016 04:04 UTC

Return-Path: <tsaad@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA30312B057; Mon, 26 Sep 2016 21:04:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.837
X-Spam-Level:
X-Spam-Status: No, score=-16.837 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.316, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RZL-elJ47IbW; Mon, 26 Sep 2016 21:04:10 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F136E12B040; Mon, 26 Sep 2016 21:04:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2164; q=dns/txt; s=iport; t=1474949050; x=1476158650; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nmC2FZ95z9JfJWLlUxDq1RFGrwmHDNHaIQidAB1c2X4=; b=be8QA0A50eCTgyJcchfr0nTuL7SNmllwPNMxiM0WV4ERpJOs+VJrR6Fe 9gVId8fAFKoMPT9T/GHBrWvo75f5vDDuDmurg5b8QRPKFrxDdNQxLvpbw JJhkvdBxtWcO7cq2dbXwn0AlJhYkHCdffb6ZbpP4kTpV5q3aLCJz0Yn0S 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ClAQDW7ulX/4UNJK1dGQEBAQEBAQEBAQEBBwEBAQEBgz0BAQEBAR5XfAeNLKtPggQZC4V6AhyBRjgUAQIBAQEBAQEBXieEYgEBBAEBASAROgsQAgEIGgImAgICJQsVEAEBBAENBYhLDrMdjG0BAQEBAQEBAQEBAQEBAQEBAQEBAQEXBYEGhTGBfIJYhEQXgm0rgi8BBJQehVgBj2mBbo19hwmFYoN7AR42hQVyhmB/AQEB
X-IronPort-AV: E=Sophos;i="5.30,403,1470700800"; d="scan'208";a="326990444"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Sep 2016 04:04:09 +0000
Received: from XCH-RTP-003.cisco.com (xch-rtp-003.cisco.com [64.101.220.143]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id u8R448HI032306 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 27 Sep 2016 04:04:09 GMT
Received: from xch-rtp-001.cisco.com (64.101.220.141) by XCH-RTP-003.cisco.com (64.101.220.143) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 27 Sep 2016 00:04:08 -0400
Received: from xch-rtp-001.cisco.com ([64.101.220.141]) by XCH-RTP-001.cisco.com ([64.101.220.141]) with mapi id 15.00.1210.000; Tue, 27 Sep 2016 00:04:08 -0400
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>
To: "Scharf, Michael (Nokia - DE)" <michael.scharf@nokia.com>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] "admin-group" in draft-ietf-teas-yang-te-04
Thread-Index: AdIYBKQ62gYe+l08Rj6Axc3eXKMI1wAb42wA
Date: Tue, 27 Sep 2016 04:04:08 +0000
Message-ID: <9FC7ED93-EC2F-4C01-83C9-9C806C3B7007@cisco.com>
References: <655C07320163294895BBADA28372AF5D48AB7B9F@FR712WXCHMBA15.zeu.alcatel-lucent.com>
In-Reply-To: <655C07320163294895BBADA28372AF5D48AB7B9F@FR712WXCHMBA15.zeu.alcatel-lucent.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.19.0.160817
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.86.250.144]
Content-Type: text/plain; charset="utf-8"
Content-ID: <FAB19EE81CBE6F49BAF4E8F5605A80B3@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/iAyFtHQmR3-J4nWRONMo0umdeP4>
Cc: "draft-ietf-teas-yang-te@ietf.org" <draft-ietf-teas-yang-te@ietf.org>
Subject: Re: [Teas] "admin-group" in draft-ietf-teas-yang-te-04
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2016 04:04:12 -0000

Hi Michael,

Thanks for reporting this. You are right, since length is in octets, the correct one is 4. We will fix this in our next update.
BTW, the type admin-groups is a union for the classic 32-bits and extended admin groups (variable length multiple of 4-octets).

  typedef admin-groups {
    type union {
      type admin-group;
      type extended-admin-group;
    }
    description "TE administrative group derived type";
  }

Regards,
Tarek


On 2016-09-26, 10:45 AM, "Teas on behalf of Scharf, Michael (Nokia - DE)" <teas-bounces@ietf.org on behalf of michael.scharf@nokia.com> wrote:

    Hi all,
    
    I try to understand this definition of draft-ietf-teas-yang-te-04:
    
         typedef admin-group {
           type binary {
             length 32;
           }
           description
             "Administrative group/Resource class/Color.";
         }
    
    Is this definition correct? Or would this be "length 4"?
    
    Both RFC 6020 and RFC 7950 define the length parameter of binary as follows: "The length of a binary value is the number of octets it contains."
    
    As a result, this definition seems to imply a 32 octet value. Is this the intention?
    
    Until draft-saad-teas-yang-te-01, the value apparently was uint32. What was the motivation for changing this in draft-saad-teas-yang-te-02?
    
    Thanks a lot!
    
    Michael
    
    _______________________________________________
    Teas mailing list
    Teas@ietf.org
    https://www.ietf.org/mailman/listinfo/teas