Re: [Teas] [**EXTERNAL**] Review of draft-geng-teas-network-slice-mapping

"Rokui, Reza" <rrokui@ciena.com> Tue, 24 May 2022 17:55 UTC

Return-Path: <prvs=0143001228=rrokui@ciena.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2196C1D4692; Tue, 24 May 2022 10:55:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ciena.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zWny42cXNc7k; Tue, 24 May 2022 10:55:29 -0700 (PDT)
Received: from mx0a-00103a01.pphosted.com (mx0a-00103a01.pphosted.com [67.231.144.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83675C1D3C49; Tue, 24 May 2022 10:55:27 -0700 (PDT)
Received: from pps.filterd (m0222747.ppops.net [127.0.0.1]) by mx0a-00103a01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24OHUtPV006876; Tue, 24 May 2022 13:55:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ciena.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=06252019; bh=TJhk7P/+fzEPjLMGFoKVfQxAKGvEMz2Sto14SC6uz1w=; b=UrLKvZmS+YBrjZcpQTW48otW35IGHrwznxuV1f4AMItwDGyF5m7aeNx6GmYKcfc/9FX8 9wapUa1dlBNmTadM0iX1+cfE6bezWigPGBG98RcQPNgz/w0oh+MHP+qEVbuR0rNudtqc TgsXfKCy0a6u51nhn5PxaEyW9IWD2x9sksaw604WAh/u4EHeJ5wf/7m842kfjLZrQ7HF /yaxvr7lh9VWsFc0n2BA8VHYGVWpcxny42/idPCEshgfYKZC9P6Uk3qNWqp3IVSsZ1yZ y044oew5roxu19YaUknSs9EJycScKnDzAGgK5ZLWYQ0K1awno8rQHHv+zuf34aSgX5zc 5w==
Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2049.outbound.protection.outlook.com [104.47.56.49]) by mx0a-00103a01.pphosted.com (PPS) with ESMTPS id 3g93u2820u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 13:55:26 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkmpIbb5eFoyHfmD2LqHxT82az0YYoMWUjTl9rsXJXBV4+BdD8fMb+tETHaqE/DLSHXzMvYi+JQdY5pQVmwYuFOvd5EFQ7acIe2z2pxRUFDPUTDsYHDtyj7AUks6O8foJVbMers5SonYrwcLw/cp5NGBtzmBpysN1TRdpJmZ3FaC8LODnRMKDvZw4FTC9den74rzN0DYKv0unT3D9P5i6kTgpuV9Y8emi5o13V5GbYt8t+hYz9iLdRFo8jiIgo2vNuX1c6RShX+sRC9DQbzBr9Oo33K9ayKmTiJC7t4UxTiDT27YhZSpXtWvb6QbitY88v6RaWvkpqq8ifNlPsPoig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJhk7P/+fzEPjLMGFoKVfQxAKGvEMz2Sto14SC6uz1w=; b=YjT8sCpph65pGQHg/51VltDkq6l5Euw5JeeIOiR2bwIR/ikBk4fEguyuS+CfhDesnOaRoSGRfdcZGlpDDv4NRktOXfF//ViHEmsMZuZOmBNtmxj76JuCKuQFtMq0OYHdfQw04kEF8mwdkD30NhtK/Zr7boIVbi0Nnwm3U8Su5XCLX6X+nJmDcKpXtKM2wGMhvTzdsJC5eGVV5sE9iVpUTkn4RZIeXy7BqK2SOLUnzkN++A+t/ldO1SbEY+2V55OJZSOfjhefx6lBZzjUKmsYgTzOfl6CYwcYZakVMpGF1569pNqDkRtKOQrO1Z6aVBqo862GlwI8dONYmS0MdjAfKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ciena.com; dmarc=pass action=none header.from=ciena.com; dkim=pass header.d=ciena.com; arc=none
Received: from SJ0PR04MB8391.namprd04.prod.outlook.com (2603:10b6:a03:3e1::22) by CY4PR04MB0969.namprd04.prod.outlook.com (2603:10b6:910:55::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 17:55:24 +0000
Received: from SJ0PR04MB8391.namprd04.prod.outlook.com ([fe80::9c60:972:d6e4:9d13]) by SJ0PR04MB8391.namprd04.prod.outlook.com ([fe80::9c60:972:d6e4:9d13%7]) with mapi id 15.20.5273.021; Tue, 24 May 2022 17:55:23 +0000
From: "Rokui, Reza" <rrokui@ciena.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "draft-geng-teas-network-slice-mapping@ietf.org" <draft-geng-teas-network-slice-mapping@ietf.org>
CC: "teas@ietf.org" <teas@ietf.org>, "Rokui, Reza" <rrokui@ciena.com>
Thread-Topic: [**EXTERNAL**] Review of draft-geng-teas-network-slice-mapping
Thread-Index: AdhuoYgx+uhginc6T2K2AJFlO2dbqQA9YIDy
Date: Tue, 24 May 2022 17:55:23 +0000
Message-ID: <SJ0PR04MB8391F4A3DAE347C407987C71CDD79@SJ0PR04MB8391.namprd04.prod.outlook.com>
References: <00ac01d86ea2$179c5bb0$46d51310$@olddog.co.uk>
In-Reply-To: <00ac01d86ea2$179c5bb0$46d51310$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-CA
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 21a96840-5391-43f6-befa-08da3dae93a6
x-ms-traffictypediagnostic: CY4PR04MB0969:EE_
x-microsoft-antispam-prvs: <CY4PR04MB09690151E34D02D76E89353FCDD79@CY4PR04MB0969.namprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: /Qt8lNLX0PkyDNk+HKyCHUHHrsfU/a8pkjjbRT8HjEu4Qz2/VLyEPDMSVj/a0Mp8pkYJoBw0YLgiOJcBraHI5Wlh4Nohc+T4lLOzrYv6NfgGK7TMXveiZZxEn0UVsMDetBY3loNEw1ouayKsl7oSSPSdtSqh2TFZUku1rxUPFQr8VEB+JGIvdLAiahX1ukpsmNDe1HavPkJs/REibiQwRmYyQ5Kv0O2mEtPclGW8tVHjRBfaZ4beVl+S86On4JHOb9pGK6wm1YmOYm3iGX3ovUk23pjGI/YVM5mTeL0WRXtRMJfEJdmUrwqjaUXxY3ZUvkgCaVlQaYe9L1R1TkkrtoJGJ4YKK+i87wJyqvUhs4AEKNLHVxKzzNDnJgpI4Ldw+SCrTZSO2KIVd8zkLaqLhjKeRzG/g2LzqpeOopMIWZqEN9XkLNMrt8N58EzDkk7Kjpkl/WKXVifQOK9qiOUB8gK0EK2oURJ0bDbDHy9+MccMwfRf+3UPVvAf8L5Quk2kFx63eUEYDeeHPMjoWgB/bzPz2sBxfVieGv7GYLTqDocEeTFWN/AibaqWzW3pHlRLY/TpG5vrhAyNVRbi+O9VhcWgSYhmeC94SKgRkJkWjL6elbYbksBwCSJ8vP6XTzSczUnnhF8GdK7suv3oY39PF0tInZlEJN8Oy5niuHFhKu6Eb+eDA1F/mK7eD5kQz5ZS/v1F8MpgiXW7qjUfqCJMphVMmdZWARnOn3CcqzS9y0AJqXuByr3UekIMiwADYJ7EBDY/na+WhwirhtStyXQ3Z/xipqp7hPTAVccW6qJy9Q2zNJFuCgBaeXKuVfSwTvMy5hsVZUa2PeD3x4CZKM1eSQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR04MB8391.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(966005)(508600001)(71200400001)(83380400001)(55016003)(110136005)(86362001)(38070700005)(186003)(33656002)(122000001)(107886003)(9686003)(7696005)(55236004)(53546011)(316002)(30864003)(6506007)(26005)(64756008)(66556008)(66446008)(66476007)(52536014)(8936002)(8676002)(4326008)(66946007)(76116006)(2906002)(5660300002)(166002)(38100700002)(91956017); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: lo45cjlMqemNnA3SLKK1aauQCut+VbdGuOtyYIydOS3n1K601BxEGiaq7vuqg5rAO/T+sym0vey09UbmLxDFR+lUqaoJ/P++7B5vKqasvAR0X+POZKfhERh09iKm82GVxoZKm7nDgVlmTe4BNnf5LmUeZsPKyMp28+NXlpx6+9GSvOtyalMW5iq6hm3vB89LiPbBJFYSXDWtm+iJyFcMCgQIux3Rcx7h1PFeglJZVpqTBUfVamf8AEMinr1Ra5dwe8S8X/IqYQR36OyM8BZ8UhPtzXxr5m3ARd4i80D4iv03NPxMZkLFxLCEH2qE9ZOD3ZAXmrcd+5+E/AV5+C7YVA2HoQZ9hD9tbYILY5urI+wc7eOBXJeykuk5N01UADCCjotCcs7T5gd2tfz/ZFHMrhnAVPVSmmuAgSbLvgvs5iMQu1G35Y2TydoJGW+tYmN6apkwai8Dxg5bKa1O77PqWqGJUKcqBOXZJRR3b5oZUl22fFnzTiyyI08EGF8CCw6L7RwZ6tehhhCEwdV3QTSKVEtXvw9dvkO6YDhlHpClIjmjUzPEJOxcjFTw3Tk5b96TsaHJ3yIMT75audIAgoGW0h2nzfsAl44gQJHohjlg5JNFu1dDEZmKN8jowS6hrKEeim2HwqdLS8vjWfxlbZVQyhfDQBZO4UbdcXkw0SA/jjMYFr2eoJjybGYr5kLEIWkg19JPnizwNeTvm1Qq6Or/5yUyLivbg/vhu9grD3RB5EO/ERR64IBtLAomDM5+y9hgczdxHHlrZoicSwddOetNLOtJo3QUzfE/1A8pzDw51dKCBqA8xfeGa4osJwlnjdy/XkuMB4p6qahok5wXZ1Ldd1oN+ICijErReYGWfWuO+KBTqmPP1WITdycxU+GX0PPBbcrmPbtZpEDRPy6jR6NGU4bpecLDE4SjsN9+xKTBCjaGPD0Z2edmaPpamByRN3leyfy8XHpV9MQ/1WOTIFz4XymtKVsneQQDNOia/qCQqohaIJCrfqyhvfDT+kQCVYapfd1TphlHFtMZL/XiE45F4NqGSxmi4jQbUK2KTY8tTM+Opmrv6hAiJvX7482vYeEPZzvibdjGxeC7h2OCg6x1D/V2OXu2/4eZYfVMDWW06qiy3b0LPA8CbieRYdl2if+wfjWTG7vV9XXLLo37lFT0xujOdpfYuyWtIO7TaobKTV6QCTegkxkcRsLmqV3ovRCLcC5KWkEkjQCz9w7i2rrjLji+vwFYvV0BBj+1BRRhEc3UBO5A/GDkSzVs1CSpw4kIXxFYrxQPEQkEO3Gpu2dpJ7untOF2YMS5i6LYtE1tnn++TRBIvlpb8MGOoktDFBl0au3aiou9MBTfLR4OjJ8az28QnFaBLixVoC9lyASChnZvYJERqXQmz3czD6hXClJu3NWKlMhnEiIeDEf+kgRFhppVDMySOav00en5SBEtb1R0iZHa5fbFEkY96vsr/PSTmauHVjU/Vuw/bt7ZgFhmurammJ+1EB7ONbAgkLwJFcfeYdfpQrxe3FkwjwLkxEti7vU6G4AhYVn101YAv/Yxc/aANEN+fhobe6YIaPgS0sM8lHb5udeV1rHSHrj1jYpFRLU4OqXmDrIBgV1lEiOQ+l07iQlqIAgFH2ILr0BBbTIlnOdn8JgAtaecfk5faGno6o/9+IAiaYcZ+PVSvCzJydr9mCji6plOs67VCiHDIkgrRpk5buu4JUqIjnMSiuZZS6ghSrJFd1RGyI3NfLUklI3NvrjT0hHLr+fNM36kwLY=
Content-Type: multipart/alternative; boundary="_000_SJ0PR04MB8391F4A3DAE347C407987C71CDD79SJ0PR04MB8391namp_"
MIME-Version: 1.0
X-OriginatorOrg: ciena.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB8391.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a96840-5391-43f6-befa-08da3dae93a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 17:55:23.6816 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 457a2b01-0019-42ba-a449-45f99e96b60a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hnvsNO00t4qENy26rcrgRc4HUCocrIRcDdHX3+RO0K/rP9fUWqY/Rz+b2pLRVRY7gQLgbBcK0spgkL6xFEztcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0969
X-Proofpoint-GUID: 95JD13Do68DeZwfh8GwNESTfbtim4qGO
X-Proofpoint-ORIG-GUID: 95JD13Do68DeZwfh8GwNESTfbtim4qGO
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_08,2022-05-23_01,2022-02-23_01
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/YFCvoQasFhputd3pPVQH6jnn6K0>
Subject: Re: [Teas] [**EXTERNAL**] Review of draft-geng-teas-network-slice-mapping
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2022 17:55:33 -0000

Hi Adrian and authors,

Agreed with your proposal. As one potential suggestion, the following draft might be used as a basis for the new applicability document.
Please reach out if there are any suggestions/comments.

 https://datatracker.ietf.org/doc/html/draft-rokui-5g-ietf-network-slice-00

Cheers,
Reza

From: Adrian Farrel <adrian@olddog.co.uk>
Date: Monday, May 23, 2022 at 8:39 AM
To: draft-geng-teas-network-slice-mapping@ietf.org <draft-geng-teas-network-slice-mapping@ietf.org>
Cc: teas@ietf.org <teas@ietf.org>
Subject: [**EXTERNAL**] Review of draft-geng-teas-network-slice-mapping
Hi authors,

I'm not a 5G expert, but I think that given the work that 3GPP has
been doing on slicing, and given the role that an "IETF network slice"
is expected to play in support of a 3GPP slice, I think it is important
for TEAS to work on an informational document to show the applicability
of IETF slices in the 3GPP context.

My review here focuses on three aspects:
- how the document should be positioned
- alignment with the slicing framework document
- nits (as usual)

I hope it helps, and maybe the chairs would consider getting something
adopted so the WG can continue the work.

Best,
Adrian

===

I think what you have here is an Applicability Statement, and it is
(should be) constrained by the use of IETF technologies in the role of a
"transport network". Since the term "transport network" is heavily over-
used, perhaps we can focus on "5G transport network slices". Thus, the
document title might be better as:

  Applicability of IETF Network Slices in the Role of 5G Transport
    Network Slices in Support of 5G End-to-end Network Slices

The words about what this document does (in the abstract and
introduction) might be re-shaped accordingly.

---

Abstract

s/5G.  End-to-end/5G.  An end-to-end/
s/draft/document/ (twice)
s/intends to expose/exposes/

---

Requirements Language

You can remove this from the document header (it is already present in
Section 2. But please also use the up-to-date form of the text.

---

1.

s/Network slice contains/A network slice contains/
s/resources(e.g./resources (e.g.,/
s/Transport network is/The Transport network is/
s/for transport network can/for the transport network can/
s/which requests transport/which requires the transport/
s/Objectives SLOs)/Objectives (SLOs)/
s/an IETF network slices in/an IETF network slice in an/
s/procedure for lifecycle/procedure for the lifecycle/
s/to map end-to-end/to map an end-to-end/
s/draft/document/
s/in management/in the management/

---

You need to decide whether "transport network" is capitalised and apply
this consistently throughout the document.

---

2.

Add:
e2e

---

3.

s/The following figure/Figure 1/
s/contains AN/contains an AN/
s/Slices. 3GPP/Slices.  3GPP/
s/called S-NSSAI/called the S-NSSAI/
s/Figure-1/Figure 1/
s/and 02333333/and 03333333/

---

Please check the capitalisation of "IETF network slice" and make it
consistent throughout the document.

---

Figure 1 gives the impression that

- A slice may be supported by one or more CNs
- Each CN may be supported by exactly one TN
- Each TN gives access to exactly one AN
- More than one TN may give access to a single AN

It may help to actually list all of the relationships and give a
clear statement of the 1:1, 1:n, n:1, and m:n relationships.

---

4.

3GPP TR 28.801 needs a reference

---

4.

   Referring to 3GPP TR 28.801, the management of 5G e2e network slices
   from 3GPP view is shown in Figure-2(A).  Figure-2(B) illustrates the
   view of IETF and how it maps to 3GPP network slice management.  In

Are these references to figures in 28.801? I don't see Figures 2(A) and
2(B) in this document even if Figure 2 seems to be about this topic.

---

Figure 2

Note: Refer to Figure-1 for S-NSSAI 01111111, AN, CN and IETF networks
slices 4,6 and 1

I think this should be

Note: Refer to Figure-1 for S-NSSAI 01111111, AN, CN and, IETF networks
slices 4, 1, and 6

---

Figure 2 is too wide.

You can fix this as:

                   +-----------------+
                   |       NSMF      |
                   +-----------------+
        +----------|     S-NSSAI     |----------+
        |          |(e.g. 011111111) |          |
        |          +-----------------+          |
        |                   |                   |
        V                   V                   V
 +-------------+ +---------------------+ +-------------+
 |  AN NSSMF   | |       IETF NSC      | |   CN NSSMF  |
 +-------------+ +---------------------+ +-------------+
 |   AN Slice  | | IETF Network Slice  | |   CN Slice  |
 | Identifier  | |     Identifier      | |  Identifier |
 | (e.g., 4)   | |     (e.g., 6)       | |  (e.g., 1)  |    Management
 +-------------+ +---------------------+ +-------------+      Plane
      |           |                   |           |      -------------
      |           |                   |           |
      V           V                   V           V      -------------
      /\       +-----+             +-----+    +-------+        Data
     /AN\ -----|  PE |-----...-----| PE  |----|  CN   |        Plane
    /____\     +-----+             +-----+    +-------+

Note: Refer to Figure-1 for S-NSSAI 01111111, AN, CN, and IETF networks
      slices 4, 1, and 6

---

4.

s/The following figure/Figure 3/
s/mapping end/mapping an end/
s/in management/in the management/
s/data(user)/data (user)/
s/Information(S-NSSAI)/Information (S-NSSAI)/
s/Neetwork/Network/
s/draft/document/

---

Figure 3 and 5.1

The slicing framework is now using "IETF Network Slice Service
Interface" and "Network Configuration Interface" in place of "NSC NBI"
and "NSC SBI".


(Search for "NBI", "SBI", "northbound".)

---

4.

OLD
   The relationship between these identifiers are specifies in the
   following sections.
NEW
   The relationships between these identifiers are specified in the
   following sections.
END

---

Section 5

I would love to see these steps on a figure. I think steps 1-8 might
look like the following, but I don't know how to put 9-12 on a figure
because this is the first mention of this work (not even sure which
components would be involved).

                   +-----------------+
                   |       CSMF      |
                   +-----------------+
                            | 1
                            V
                   +-----------------+
                   |    NSMF 2,3,8   |
        +----------|      S-NSSAI    |----------+
      4 |          +-----------------+          | 5
        |                   | 6                 |
        V                   V                   V
 +-------------+ +---------------------+ +-------------+
 |  AN NSSMF   | |       IETF NSC      | |   CN NSSMF  |
 +-------------+ +---------------------+ +-------------+
      |           |         |         |           |
      |           |         | 7       |           |
      V           V         V         V           V
      /\       +-----+             +-----+    +-------+
     /AN\ -----|  PE |-----...-----| PE  |----|  CN   |
    /____\     +-----+             +-----+    +-------+

---

Section 5.1

s/management Plane/management plane/
s/Service Profile defined in[TS28541]/The Service Profile defined in
[TS28541]/

---

5.1

OLD
   GSMA(Global System for Mobile
   Communications Association) defines the [GST] to indicate the network
   slice requirement from the view of service provider.
NEW
   The Global System for Mobile Communications Association (GSMA)
   defines the Generic Network Slice Template (GST) in [GST] to indicate
   the network slice requirement from the view of the service provider.
END

---

5.1

s/analysis/analyses/
s/categorize/categorizes/
s/finished If/finished.  If/
s/is supposed to/needs to/
s/draft)/document)./

---

5.2

s/draft/document/

---

5.2

   Editor's note: The mapping relationship between NSI defined in
   [TS23501] and S-NSSAI defined in [TS23501] is still in discussion.

I don't know what to make of this note. It is surely not something the
IETF needs to resolve, and I assume the discussion is going on in 3GPP.
Yes, as you state in the previous paragraph, there is an assumption
about the existence of the mapping relationship, but isn't the actual
relationship out of scope?

---

5.3

OLD
   If multiple network slices are carried through one physical interface
   between AN/CN and TN, IETF Network Slice Interworking ID in the data
   plane needs to be introduced.
NEW
   If multiple network slices are carried through one physical interface
   between AN/CN and TN, an IETF Network Slice Interworking ID needs to
   be introduced in the data plane.
END

BUT!
This section needs to explain why this is a requirement, and a what
point in the network it is required.

Section 4 gives a bit of explanation about the use of the IETF Network
Slice Interworking Identifier. That implies that it is used in the data
plane to indicate onto which IETF network slice a particular e2e packet
should be mapped. In other words, it enables demux of traffic on a
single channel (we may say access connection) into different IETF
slices.  As you note in Section 4, there are obviously many possible
ways of doing this already (depending on the AC encoding).

And you go on (in 5.3) to say:

   If different network slices are
   transported through different physical interfaces, Network Slices
   could be distinguished by the interface directly.  Thus IETF Network
   Slice Interworking ID is not the only option for network slice
   mapping, while it may help in introducing new network slices.

Can I suggest that the "IETF Network Slice Interworking ID" is a logical
concept that is needed in all cases. In some cases it is encoded in the
physical interface ID, in others it is encoded in the virtual interface
or channel ID (such as VLAN tagging), or it may be achieved using IP or
UDP information.  However, in the absence of all of these, a new piece
of information will need to be encoded in the packet.

---

5.3.1

s/a uplink/an uplink/

---

5.3.1

I suggest you turn the Editor's Note into a new section as follows:

5.3.1.1 3GPP Network Instance

   [TS23501] defines the concept of a "Network Instance" that is used to
   indicate the TN instance intended to support an end-to-end slice.
   The Network Instance could be determined from the S-NSSAI, and it
   could also depends on other information.

   However, the concept of Network Instance is neither a necessary nor
   sufficient condition for identifying an IETF network slice.  That is,
   multiple IETF network slices may be supported within the context of a
   single network instance meaning that the Network Instance identifier
   is not sufficient to identify the IETF network slice.  Furthermore,
   an IETF network slice may be supported by more than one underlay
   network (in parallel or in series) meaning that the Network Instance
   identifier may not provide adequate indication of how the IETF
   network slice is formed or identified.

---

5.3.2

You need to explain "UE", "NS", and "UPF".

The figures need numbers and captions.

There seems to be some imbalance in the first figure between "(R)AN"
which is a network, and "UPF" which is a function.

I think you can just convert the Editor's Note into text.

---

5.3.2 and subsections

I found the 2nd and 3rd figures in 5.3.2 somewhat unnecessary. They are
interesting, but they don't serve any purpose in the mapping discussion,
I think.

Furthermore, while the subsections are perfectly correct, they seem to
be pointing to some of the options. I wonder whether they are really
necessary. Couldn't they be replace with a simple statement that the
fields of the UDP, IP, Ethernet encapsulation headers could be used
(where they are visible to the TN) to carry the IETF Network Slice
Interworking ID."

---

6.

The figure needs a number and a caption. It's a nice figure, but it
could use a few sentences to describe what it is showing.

---

7.

The "TBD" can be replaced with "This document makes no requests for
IANA action."

---

8.

You should be able to come up with some discussion of security. Does
the security of the e2e slice depend upon the security of the TN slice?
Is it possible to attack the TN by messing with the various identifiers
passed to it? Is it possible to attack user traffic by steering it to
the wrong TN slice? Who is responsible for resolving these issues
(specification writers, implementers, operators)?

---

9.  Contributors

   The authors would like to thank the contributors for reviewing the
   draft and giving valuable comments:

Are these Contributors or is this the Acknowledgements Section?

---

10.

[I-D.ietf-teas-ietf-network-slice-definition] is dead. You don't
reference it so you can remove it from this section.