[TICTOC]Intdir telechat review of draft-ietf-tictoc-ptp-enterprise-profile-26

Tommy Pauly via Datatracker <noreply@ietf.org> Thu, 09 May 2024 15:42 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tictoc@ietf.org
Delivered-To: tictoc@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E52C1C14F69A; Thu, 9 May 2024 08:42:12 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Tommy Pauly via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.11.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171526933292.44843.12865135419704340132@ietfa.amsl.com>
Message-ID-Hash: 47EKVZMMALNTSV7KXPANMV4UOENNNXWE
X-Message-ID-Hash: 47EKVZMMALNTSV7KXPANMV4UOENNNXWE
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tictoc.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-tictoc-ptp-enterprise-profile.all@ietf.org, last-call@ietf.org, tictoc@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Tommy Pauly <tpauly@apple.com>
Subject: [TICTOC]Intdir telechat review of draft-ietf-tictoc-ptp-enterprise-profile-26
List-Id: Timing over IP Connection and Transfer of Clock BOF <tictoc.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tictoc/SnRWxNVCapQkwBhal5PnAUPmPDg>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tictoc>
List-Help: <mailto:tictoc-request@ietf.org?subject=help>
List-Owner: <mailto:tictoc-owner@ietf.org>
List-Post: <mailto:tictoc@ietf.org>
List-Subscribe: <mailto:tictoc-join@ietf.org>
List-Unsubscribe: <mailto:tictoc-leave@ietf.org>
Date: Fri, 10 May 2024 21:59:16 -0000
X-Original-Date: Thu, 09 May 2024 08:42:12 -0700

Reviewer: Tommy Pauly
Review result: Almost Ready

This is a review of draft-ietf-tictoc-ptp-enterprise-profile for INTDIR
(https://datatracker.ietf.org/group/intdir/about/)

Overall, the document does need an editorial pass for clarity, and
typos/grammar. Much of this can and should be done by the RFC editor, but it
did make it a bit difficult to read. I’ve included some obvious nits at the
bottom of this review, but a more thorough pass is needed.

The abstract refers to “an IPv4 or IPv6 Enterprise information system
environment”. However, I don’t see “Enterprise information system environment”
defined or referred to elsewhere. I would suggest either elaborating on this
term of art, or potentially simplifying it to “an IPv4 or IPv6 enterprise
network”.

The introduction (section 1) does not discuss enterprise networks at all, or
give context on what this document itself is about. It provides background,
which is fine as an introduction sub-section, but I would suggest that the
content of the “problem statement” section 4 be moved up to the start of the
introduction.

Beyond readability and clarity, I don’t see particular issues with regards to
the INTDIR review criteria; the handling of IPv4/IPv6, NAT, multicast, etc,
seem appropriate.

Nits:
Section 1
“in stead” -> “instead”

Section 6
typo on “aloted” -> “allotted”
“Ipv6” -> “IPv6”