[TLS] Genart last call review of draft-ietf-tls-ecdhe-psk-aead-03
Dan Romascanu <dromasca@gmail.com> Mon, 15 May 2017 10:46 UTC
Return-Path: <dromasca@gmail.com>
X-Original-To: tls@ietf.org
Delivered-To: tls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EE7D0126E64; Mon, 15 May 2017 03:46:35 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dan Romascanu <dromasca@gmail.com>
To: gen-art@ietf.org
Cc: draft-ietf-tls-ecdhe-psk-aead.all@ietf.org, ietf@ietf.org, tls@ietf.org, dromasca@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 6.50.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149484519593.2843.448630358757818654@ietfa.amsl.com>
Date: Mon, 15 May 2017 03:46:35 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/F6QX0bJj1h0bwaSF_6cygmE2T5I>
Subject: [TLS] Genart last call review of draft-ietf-tls-ecdhe-psk-aead-03
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2017 10:46:36 -0000
Reviewer: Dan Romascanu Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-tls-ecdhe-psk-aead-?? Reviewer: Dan Romascanu Review Date: 2017-05-15 IETF LC End Date: 2017-05-18 IESG Telechat date: 2017-05-25 Summary: This is a straight-forward and clear document that defines several new cipher suites for the Transport Layer Security (TLS) protocol version 1.2 and higher, based on the Ephemeral Elliptic Curve Diffie-Hellman with Pre-Shared Key (ECDHE_PSK) key exchange together with the Authenticated Encryption with Associated Data (AEAD) algorithms AES-GCM and AES-CCM. The document is well written and I appreciate the effort to clarify in the Introduction the context, what was missing, and why the document is necessary. The document is Ready, there is one issue about support for TLS version 1.3 and higher that may need some text clarification. Major issues: Minor issues: Section 4 ('Applicable TLS Versions') describes in details how the cipher suites defined in the document make use of the authenticated encryption with additional data (AEAD) defined in TLS 1.2 [RFC5246] and DTLS 1.2 [RFC6347]. About TLS 1.3 it just says: ' TLS 1.3 and above version, negotiate and support these cipher suites in a different way.' This may raise some concerns as 'in a different way' is ambiguous, especially compared to the details included for TLS 1.2. Moreover, TLS 1.3 is still work-in-progress, and I believe that this document when approved needs to wait for TLS 1.3 to be approved for publication. Will anything change, or need to be added? Some better clarification text would help IMO. Nits/editorial comments:
- [TLS] Genart last call review of draft-ietf-tls-e… Dan Romascanu
- Re: [TLS] Genart last call review of draft-ietf-t… Daniel Migault
- Re: [TLS] Genart last call review of draft-ietf-t… Dan Romascanu