Re: [TLS] Presentation language parser on github

Martin Thomson <martin.thomson@gmail.com> Thu, 01 May 2014 18:02 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 699F41A6FE0 for <tls@ietfa.amsl.com>; Thu, 1 May 2014 11:02:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.4
X-Spam-Level:
X-Spam-Status: No, score=-1.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, J_CHICKENPOX_55=0.6, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mB_4TRlWmdCx for <tls@ietfa.amsl.com>; Thu, 1 May 2014 11:02:41 -0700 (PDT)
Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) by ietfa.amsl.com (Postfix) with ESMTP id 104991A6FDE for <tls@ietf.org>; Thu, 1 May 2014 11:02:40 -0700 (PDT)
Received: by mail-wi0-f169.google.com with SMTP id hi5so1148614wib.4 for <tls@ietf.org>; Thu, 01 May 2014 11:02:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=93qHfKztnGjHQJ5tantTFqKChnYUxMfRYTv+3JoL0QI=; b=lIdnGDWwoy5eCqd+zuBwS0PPjkdbiXnOAoUEEUUNRvXqaAFtwNymOZexf7fghHqoIf QMDAXYw1SUt3UnqqmfajLo8FLu6SAa/A86lrtmEIiX/gUem2ycP703rz2DxUiZlR4pXY HJYMHAMYFk12cR+uneyRUmH4I7D1K3erzTTV76fiFf4KInfryPygLycjqlDLycvM3sgy algWxQpiG/ep3NXL2eVqGjb2aD48lY5kV8tQzXbadc4D00R5B91ZXlZWLj4RJmVsl2hR wpg4449tXHDl/6nSXwHiWci4z/erQyFl4npMsuBqRhORwl3g0wB6aDCJvMVygY6ujgfc 6ovg==
MIME-Version: 1.0
X-Received: by 10.194.95.195 with SMTP id dm3mr9805999wjb.17.1398967358590; Thu, 01 May 2014 11:02:38 -0700 (PDT)
Received: by 10.227.77.10 with HTTP; Thu, 1 May 2014 11:02:38 -0700 (PDT)
In-Reply-To: <2A0EFB9C05D0164E98F19BB0AF3708C7130742BDE0@USMBX1.msg.corp.akamai.com>
References: <2A0EFB9C05D0164E98F19BB0AF3708C7130742BDE0@USMBX1.msg.corp.akamai.com>
Date: Thu, 01 May 2014 11:02:38 -0700
Message-ID: <CABkgnnV9_c+fpWwGQMK+95MLF-gSUOrneZ5Ooq9=S6d2m81_AA@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: "Salz, Rich" <rsalz@akamai.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: http://mailarchive.ietf.org/arch/msg/tls/T1c9qqgMb_ka6H_kU27e-menJrM
Cc: "TLS@ietf.org (tls@ietf.org)" <tls@ietf.org>
Subject: Re: [TLS] Presentation language parser on github
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2014 18:02:42 -0000

On 1 May 2014 09:13, Salz, Rich <rsalz@akamai.com> wrote:
> There are some minor nits and such that I’ll raise issues for.  BTW, better
> to open an issue, make a fix and do a pull request (more learning!) or both?

Sorry, couldn't help myself:
https://github.com/tlswg/tls13-spec/pull/30

In my experience, the preference order for editorial/minor stuff like this is:
1. pull request
2. issue
3. email

Issues with actual substance are best handled with email, or
email+issue if you are certain that it's an issue.  If you have a
proposal for a fix, a pull request helps, but I often find that it's
best to wait until some discussion has happened.