Re: [TLS] Review of draft-ietf-tls-subcerts-07

Nick Sullivan <nick@cloudflare.com> Thu, 23 April 2020 04:03 UTC

Return-Path: <nick@cloudflare.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFEF43A12F3 for <tls@ietfa.amsl.com>; Wed, 22 Apr 2020 21:03:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cloudflare.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5NuO9DNzc6Vn for <tls@ietfa.amsl.com>; Wed, 22 Apr 2020 21:03:05 -0700 (PDT)
Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 009833A12EF for <tls@ietf.org>; Wed, 22 Apr 2020 21:03:04 -0700 (PDT)
Received: by mail-ua1-x934.google.com with SMTP id g10so4353316uae.5 for <tls@ietf.org>; Wed, 22 Apr 2020 21:03:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yQOQGnxgYCxf65E3vwtZlWS1b0WxGg7b3VUra7B0psk=; b=DvTqWz0vM0wcH1dwGtgaeYCyUZYZpLqWx1ISpFsCBxDBJuaZI2r6YDWKnaaenWphMk XpDYy0qpKqO3fKNuD80/LwuIhPxUHctipiqhpi9ijrSrrv/XB0MI6pcUajqv/2ZldnO6 DmK4lFiTilY72PWy0kSRSkNWGaSURUm12QHHU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yQOQGnxgYCxf65E3vwtZlWS1b0WxGg7b3VUra7B0psk=; b=kll9MEBr5+agyrb0eKehzU2EYsD7ZC/WpxkeYy1qSJP1SpOxYn4mDQx3nVEQJni/a7 35kJQAoXXdo0BrjUjCX5r7abEVhCyAGWvHJ8D/auN85zoXbPvOZ5sghACCzsDY6U7Mvz r5uX/yTSZBg4tWiZZbTW3it+Thao6Qg7hEf8Mn0AgrbER33xhW2d0brQoNuNLE7LGT5w VBesU7I8vLidP+STNtkhayZEt26PgQUCtKy8Wc/O+Fcj2CJveJWHmFBa0JnwPNj0OVdm iVmRBIvIpIZ+K77q0xqTKbnf7E9ZnUTu4PzuBHznVdXaSbiG3+us4rUDNYqibKzIFOjr tFJA==
X-Gm-Message-State: AGi0PubZJ0iFhge46M8dmuWB035thOSZ3HpaE+8VAbKqlrIb8nbNThYu gl3ROr1eTZM2NRB2GZfhPom0jtBEG7OcDFiR9zChPA==
X-Google-Smtp-Source: APiQypKq5NKsU48GmlAQN4kIyZ6s8tdtaejpNaj+Tke5PFBX/nmuasIR+dgV5WrlfKuwATakg+xWyZE4Bw/xqRm7JkA=
X-Received: by 2002:a67:304c:: with SMTP id w73mr1538984vsw.212.1587614583528; Wed, 22 Apr 2020 21:03:03 -0700 (PDT)
MIME-Version: 1.0
References: <CALhKWghZ3DRjpPZzOhdqzjYwrkx0qpY12k-Hgdo395Opkabfzw@mail.gmail.com>
In-Reply-To: <CALhKWghZ3DRjpPZzOhdqzjYwrkx0qpY12k-Hgdo395Opkabfzw@mail.gmail.com>
From: Nick Sullivan <nick@cloudflare.com>
Date: Wed, 22 Apr 2020 21:02:47 -0700
Message-ID: <CAFDDyk8NGiQW-a_=C+9bP1CZpmFgQz_hui+G3UxEK1uJmLVjKg@mail.gmail.com>
To: Jonathan Hammell <jfhamme.cccs@gmail.com>
Cc: TLS List <tls@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004ad2f605a3ed5368"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/o-NkOLi9zCc9NVVeV4HihLYUbhY>
Subject: Re: [TLS] Review of draft-ietf-tls-subcerts-07
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2020 04:03:07 -0000

Hi Jonathan,

A (delayed) thank you for this helpful review. Your input will be
incorporated into draft -08.

Nick

On Thu, Apr 2, 2020 at 6:31 PM Jonathan Hammell <jfhamme.cccs@gmail.com>
wrote:

> The draft looks good.  I have a few minor nits and suggestions.
>
> Section 3, Fourth bullet: s/TLS hadshake/TLS handshake
>
> Section 3, Fourth bullet: To eliminate possible confusion, what is
> meant by "certificate’s working key" could be defined more precisely.
>
> Section 3.2, Last paragraph: s/Automated Certificate Managmeent
> Encvironment/Automated Certificate Management Environment
>
> Section 3.2, Last paragraph: "It is possible to address the
> short-lived certificate concerns above ..." seems to refer to text in
> the Introduction.  It is a bit far for use of "above" rather than
> indicating the particular section.  Even better would be to add some
> text regarding the concerns to Section 3 or 3.1.
>
> Section 4: The definition of "valid_time" could mention that the value
> must not exceed 7 days.
>
> Section 4: The phrase
> "Minimizing their semantics in this way is intended to mitigate the
> risk of cross protocol attacks involving delegated credentials."
> could be improved by adding at least one way that the minimized
> semantics mitigate such attacks.
>
> Section 6.1: The term "TLS private key" is used for the first time
> here. In the rest of the document we see the term "delegated private
> key"; are these the same?
>
> Section 6.1: The following phrase describes an important condition for
> using delegated credentials:
> "Thus, delegated credentials should not be used to send a delegation
> to an untrusted party, but is meant to be used between parties that
> have some trust relationship with each other."
> I think it is important enough to include a similar statement when
> describing the solution in Section 3.
>
> Section 6.4: s/cache the certificate chain an re-validate it/cache the
> certificate chain and re-validate it
>
>
> Best regards,
> Jonathan
>
> _______________________________________________
> TLS mailing list
> TLS@ietf.org
> https://www.ietf.org/mailman/listinfo/tls
>