Re: [TLS] Adam Roach's No Objection on draft-ietf-tls-tls13-vectors-06: (with COMMENT)

Martin Thomson <martin.thomson@gmail.com> Mon, 30 July 2018 23:13 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CAFAD130F25; Mon, 30 Jul 2018 16:13:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zONMwSAlksm4; Mon, 30 Jul 2018 16:13:32 -0700 (PDT)
Received: from mail-oi0-x242.google.com (mail-oi0-x242.google.com [IPv6:2607:f8b0:4003:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1CA94130E9F; Mon, 30 Jul 2018 16:13:32 -0700 (PDT)
Received: by mail-oi0-x242.google.com with SMTP id k81-v6so24456265oib.4; Mon, 30 Jul 2018 16:13:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AppOsoNLF524MlyK2tWIkFq9unJelBvpwVujtsVi0zo=; b=Z5K2U5ERz3SVc2ISDAisG2eNNnKRj3GJwt+tvClEaqzCz8b6tsdcZA2BaJLqY1zy3q dCDC+1tS/t5n3AkI2v2GzlkWyklsZ6HGnzZC4rJsMzkdS6iIVNn7vabWCXRv/+GZsl2B +BxCMIwnCgLmbDHYXM9ETcJk0loi1Ltc4taMLfODickrXwDqdPN7IDLQm/6WGdYDhgOx oHc/nUFZvoMPheCbd/waElTWd738Bh4on/DyrY0RE0Kzcv4R9uzcxIM7rtvpK+Fi+yHZ DZT4UgPNZrrjMu+ElfNaHIZ296hw5lLa5/vE+Hxuw33TGs9AWEuys4JsRfwtrNnzJbEV Sn4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AppOsoNLF524MlyK2tWIkFq9unJelBvpwVujtsVi0zo=; b=TS6LBl+2mBLRBu4D6NJpD9WZVTVPDEHNBCS8OHV0sEasLn5TWpRqmFiuLPSyL3sNKd 5M9OI/0sJQvtl8stZ9S8A8gds1ifudocUYHuAFTlmC8nM4O3WlY79waFiaxmfuHLwl3M KF6AcEm5Jd3ONgSMBTMCAwRybWcRyhz8RxcqryREG9qHjPkMEXCc/ghCCHIxihkDaGA9 Tl3sCOTKmC5z5y9WHWb8NJAjjxpyCuGUgoa0fdtM7Wu8Y2Izea32ttQ+UqGcCE9allnA g62xlO3RNreMUwNYrbnI1V/iOJGHiIqT8A9BgM8VfaEJKQgUyHKQENNEnkg1uT8f9JLu qTtA==
X-Gm-Message-State: AOUpUlGaph4QO9/Qm3RhSOzxzN2FR9A2tMdTMoVbTXLpG67gBHn+v65D plAjsAYwQt5eAM9wwBsmT1HyxJn6LXPT9xnaWR9roCX+
X-Google-Smtp-Source: AAOMgpcl7ArM5Y4pq0Y2WYtQ+wX+hulML51FV8QBktbuy/0WWjchwiprTHSqlngTK/6PxuoJQt84ybgp2CMW7vLKiOw=
X-Received: by 2002:aca:5841:: with SMTP id m62-v6mr21368326oib.346.1532992411387; Mon, 30 Jul 2018 16:13:31 -0700 (PDT)
MIME-Version: 1.0
References: <153299001967.7842.14757350576096250364.idtracker@ietfa.amsl.com>
In-Reply-To: <153299001967.7842.14757350576096250364.idtracker@ietfa.amsl.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Tue, 31 Jul 2018 09:13:20 +1000
Message-ID: <CABkgnnWpN6tJ0ATpKnavtGyo8u4kCvZtef8VALwBV7GUZZc53w@mail.gmail.com>
To: Adam Roach <adam@nostrum.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-tls-tls13-vectors@ietf.org, Sean Turner <sean@sn3rd.com>, tls-chairs <tls-chairs@ietf.org>, "<tls@ietf.org>" <tls@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/ruqLx0eJehCVistshd4vCBnwEPg>
Subject: Re: [TLS] Adam Roach's No Objection on draft-ietf-tls-tls13-vectors-06: (with COMMENT)
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2018 23:13:34 -0000

On Tue, Jul 31, 2018 at 8:33 AM Adam Roach <adam@nostrum.com> wrote:
> This doesn't parse. Probably should say "...through the use of labels..." or
> something similar.
> [...]
> I'm not sure what to make of this. Should it say "...private RSA keys for this
> example..." or something like that? It may also be useful to include a sentence
> or clause explaining why the omitted private key is not useful for users of this
> document.

The private keys for certificates weren't included (as you noticed,
the key exchange keys are).

Both fixed in https://github.com/tlswg/draft-ietf-tls-tls13-vectors/commit/ca4896c7a3b3cc6d214a1e6fe94b64ba1b1230e8