Re: [Tools-discuss] finding reviewer name in review objects

Benjamin Kaduk <kaduk@mit.edu> Wed, 08 May 2019 00:30 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA2401200A4 for <tools-discuss@ietfa.amsl.com>; Tue, 7 May 2019 17:30:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WjSwDS7RfK1S for <tools-discuss@ietfa.amsl.com>; Tue, 7 May 2019 17:30:21 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAB4812006E for <tools-discuss@ietf.org>; Tue, 7 May 2019 17:30:20 -0700 (PDT)
Received: from kduck.mit.edu (24-107-191-124.dhcp.stls.mo.charter.com [24.107.191.124]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x480UDis030237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 May 2019 20:30:17 -0400
Date: Tue, 07 May 2019 19:30:13 -0500
From: Benjamin Kaduk <kaduk@mit.edu>
To: Henrik Levkowetz <henrik@levkowetz.com>
Cc: tools-discuss@ietf.org
Message-ID: <20190508003012.GS19509@kduck.mit.edu>
References: <20190507181846.GO19509@kduck.mit.edu> <f46c85a9-1179-35df-e737-77b9220af74b@levkowetz.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f46c85a9-1179-35df-e737-77b9220af74b@levkowetz.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/4fJHbqbOqvzFaF_8OqMR_ERtVF8>
Subject: Re: [Tools-discuss] finding reviewer name in review objects
X-BeenThere: tools-discuss@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss/>
List-Post: <mailto:tools-discuss@ietf.org>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 May 2019 00:30:24 -0000

On Wed, May 08, 2019 at 12:11:25AM +0200, Henrik Levkowetz wrote:
> Hi Ben,
> 
> On 2019-05-07 20:18, Benjamin Kaduk wrote:
> > Hi all,
> > 
> > It looks like the recent work on refactoring review objects made it harder
> > to find who did a given review.  E.g., at
> > https://datatracker.ietf.org/doc/review-ietf-netconf-restconf-notif-13-secdir-lc-malhotra-2019-04-11/
> > there is no "Reviewer name" field, so I either need to look at the
> > "Completed reviews" section that includes a line for the current review
> > object or look in the name/title of the oject/page and hope that the
> > reviewer's surname is in my wetware lookup table.
> > 
> > Not a huge deal, but I figured it might be worth noting.
> 
> Definitely.  I've created and applied a patch which adds Review Assignment
> information to the review document pages, and tweaked the display to match
> other document status pages.
> 
> Please have a look and see if this improves things for you.

Indeed, it looks more like what I remember (i.e., good), now -- thank you
all for the quick fix!

-Ben